Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Lin Ma <linma@zju.edu.cn>
Cc:     lduncan@suse.com, cleech@redhat.com, michael.christie@oracle.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        vikas.chaudhary@qlogic.com, JBottomley@Parallels.com,
        mchan@broadcom.com, benli@broadcom.com, ogerlitz@voltaire.com,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: iscsi: Add length check for nlattr payload
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1351bzba8.fsf@ca-mkp.ca.oracle.com>
References: <20230725024529.428311-1-linma@zju.edu.cn>
Date:   Tue, 25 Jul 2023 21:55:53 -0400
In-Reply-To: <20230725024529.428311-1-linma@zju.edu.cn> (Lin Ma's message of
        "Tue, 25 Jul 2023 10:45:29 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5t4oiLZO8lVRv/nTP2L7x8mXipasEr0jDnhEo1Z0+oe6lvRql2HnlecwUjJV?=
 =?us-ascii?Q?UBYMIz0vo8cOtByuhmyY7cMSQJuIIkToT/PrB3ixDybjQyJC/EkTJpIjym4D?=
 =?us-ascii?Q?G6+qLu0gMymswxHZPRbTmlM2gH5YcuBmBThh1p2Yd7WdAhsohKVd8Xck44dK?=
 =?us-ascii?Q?64FUD0Cbvb44AgU71wHgyNSxqSaPjeizPwzdLnPSXTqO+hiJ/O4zZKGjdGlI?=
 =?us-ascii?Q?0j1sdbdNagXNqp4Kh+mgJ/VG1PVPkuAQEPRj/aZT3TMq3nJ5O/SEDEeA5jgw?=
 =?us-ascii?Q?AYJcSyhYE2BXzTMZM3ZKjXb0f/agh7KgzXyIGS+Sn6EVxf1/PFICKs7FKNZ6?=
 =?us-ascii?Q?yPrIRaKN53AnySEu8xC9TjtwHgZtUfZnGpqtB7ET5zrFx4EIR3aOOoPBGcji?=
 =?us-ascii?Q?vMBbukqf5kPoZun9dFP6GSn1N7ukV8lARrilUFs7OJeZ9nc3PfikKzI7YTp4?=
 =?us-ascii?Q?0cpjTllx0Eo1YKQCFWPYgArExF3ssF0CmpanTNjzZUlrjvuc02i0jsDypDmA?=
 =?us-ascii?Q?fNAcIQ4A36Imw46Pq2zn9xum1zeJ1C8GQRlQo2JF1Umi+Wy8Kin3KPlS+wq+?=
 =?us-ascii?Q?xBKxkO/kXvob4Tv14A68psiBk2FkwgM1YVPmFGLG/9/rXYSIkZO0Knx56hh4?=
 =?us-ascii?Q?P76ctd2yW2VQEkQdURVs9w7CWUZA+YdWzvVqfVI9jdWykqRg4QcbQSQeOsw+?=
 =?us-ascii?Q?Wg8n/EKQKdYBk3QPri9yQ0qnLFASIVDYUN8sfATCBEKO+RywKkwgggcK8Ex7?=
 =?us-ascii?Q?/Pi2r5wG/wSs+Nl8mdMsBBnXtcwA/cuBKT5/xgryAtbgPtdZpuJ2269XVbzA?=
 =?us-ascii?Q?aqFeW6uadj7tQ/SkGtV6gKU0FIFsY0ajsX3l/XITO+d+fZ0lhotJcpnHaku1?=
 =?us-ascii?Q?62TWNiUbm4cxrpLSLzDASwOxoXtt/x7eLdf4FwEihPTf2znFgG9UU04mjW+e?=
 =?us-ascii?Q?nV357SBSiKDvZ+B4V4ieMtRe8UD9esLQchx8XcN7TP2bwr082cuuPFK0SRb+?=
 =?us-ascii?Q?5j2642pZMQibZcwHsM0urs1/kUlIWdbZ4aByzxCjenz+hHLD0GWocXvuc8Z+?=
 =?us-ascii?Q?KkM7Dda0yzSAP3c69Yh3fykCeu45eGjrr05TGbYPQ5adwsNSF4w25eiUL/GK?=
 =?us-ascii?Q?vso4bqlwQsIZEX1cUIy06I53VUwGzVOD/3DXvcNRqi3Ai4xDG4izZfkIiz3b?=
 =?us-ascii?Q?ooR9tNzU1nBgcK84/v4tC9xbzoWaRM3MsJ2G/jW6/zBQH736EbV6WPpCiGcs?=
 =?us-ascii?Q?BavpRlCFSQ4TYRdcO74kpBqF8Jg3ifq+X4hxupDM5e3P2NMvotBdxU/V8X3U?=
 =?us-ascii?Q?uKmfmsRT33XwV7ObQy4amCVPPqARYju9/ZyLvGNu8gSku91OlWfHeilkVzKD?=
 =?us-ascii?Q?6HUbMZlD6bXCxH3+PTstHzZKR7va83zK6Z5jdz1emRb9OVaOnn0+6BrAJ4fT?=
 =?us-ascii?Q?OC6KMvgoaHySNFGjmxAlxbaNwJpLQrdMoTYonE2R7Y4frwxYuUdQQ4phC9Jd?=
 =?us-ascii?Q?f9nd7vWMHsXeoV957qo7m7aTqakoTGWIYipk1WEG+m+OX6n0513nfFdzh8+q?=
 =?us-ascii?Q?b3cgObIGxD1SGySeISVhXTBO0FZCMg4FtfQdlSXOfo2+Mf+JQLXokH6Agb22?=
 =?us-ascii?Q?JQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?b6MVSdsaRp/3aOH8dWlj9+q+hhUzfle1V7yyp5ioUh0tgzERNxThRmncmNni?=
 =?us-ascii?Q?5m8SV9RkDc5X0O6QmUUPx3gu2qPxc3hBkXr5iORlhmBd/RwRmR6q5cTPVyKC?=
 =?us-ascii?Q?iCjquoIzEhCkeyJclCrzNZYwiSMVOHbOQyhe5umQUoUIwHRCYgtLU//QSeNs?=
 =?us-ascii?Q?JaIZyZCo85kP23kBW8yA2M0geD1FizWrQbnCT8eM9tPqQuF8AmsB3N/xydou?=
 =?us-ascii?Q?ZRC/fiBN7opJ6evZpPA+jhSIKUF6cNbZ6rNh+NjKhOLTD99E7vWdwHX/zTRz?=
 =?us-ascii?Q?DmZcerLJbodZg+cGP1cmHY12J7xee1Ccj22mgORJR4oool6XX4fPwjxeFQ5X?=
 =?us-ascii?Q?dglTTD6yaoSL/ENe517ydZOmSExQia/m+HsuxueFAtDtsrBAmMWnweNi2T9s?=
 =?us-ascii?Q?doroFQPZCVeRw0PHRzDe0q3tUGGOh5pIvKfqyVkxU3yfoReIdHUR0a2E6iLK?=
 =?us-ascii?Q?LVVkKMDBW99BownNVPnTUnu27Ai2CjNSEcQFduHF1BZARJRxsoDfkDwQa3ZZ?=
 =?us-ascii?Q?DoBUYF4gmYnTnBn5Jgq31i0BYgNrZr0zCG2cN5oPcxWDyMZ1yVvSu3jtYTTP?=
 =?us-ascii?Q?TtZVeSPhaGJt5k5B1xj7SFW5n3Go5nT0JOLyGR5wzlStAKJcIMaglYKk3FUU?=
 =?us-ascii?Q?NBjsjFBqH4MWZa+RDnErpmLVR6lyV1HbCmtXm2I8b5t32+LbIay0c9b6hrsA?=
 =?us-ascii?Q?64t8SyD745u0YYe/7J0u/8v9AaQzD8WReGqYZGKqOIUtng5UyA/UT1bmR3rW?=
 =?us-ascii?Q?vxVKYlc8fnoMvVEYQoOd9g1dxs9nTV5HcHFdG6AZ7nHG83g2iksyLKSinX27?=
 =?us-ascii?Q?GN2VlG8oMm0ZlERnjhtjhxMQLLVk8Lje4pqkf90bDWU8rY+Vb2Y3weJkB8n6?=
 =?us-ascii?Q?TMBRQF6keQ7Y/8axxUpOTOeBtsOkEHf1tWW1cxN4OfZoEJbtqnAUTQwqqoc3?=
 =?us-ascii?Q?A8RllXTtuGflgDTrwihNI2uNBN77ajroEeGWHUjia02hb5r+qKTtVYazbmsD?=
 =?us-ascii?Q?EbH+uuEmNgVz6Hi/ZYSwbx4X8UZIRRUihMas1kkt9iRU8ylg5T4UIGJYx44w?=
 =?us-ascii?Q?q7i7EWZk?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef0ba2bd-37ba-4237-ecc4-08db8d7b72b0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 01:55:55.0010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +o/FRamNQOO908QfcFTEvN5iMnl7U9qdwl5H0ogVGFZPgST8Wpp3le/smFdd3qdi6MDUaFkdk79d8v7liFfxWf9mqPfnQWJzG+gYQ4OeAtY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7152
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307260014
X-Proofpoint-GUID: lBYts2OW49kvYu47VDNPGiy4Dtmv-8wB
X-Proofpoint-ORIG-GUID: lBYts2OW49kvYu47VDNPGiy4Dtmv-8wB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Lin,

> The current NETLINK_ISCSI netlink parsing loop checks every nlmsg to
> make sure the length is bigger than the sizeof(struct iscsi_uevent)
> and then calls iscsi_if_recv_msg(...).

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering