Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Lin Ma <linma@zju.edu.cn>
Cc:     lduncan@suse.com, cleech@redhat.com, michael.christie@oracle.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] scsi: iscsi: Add strlen check in
 iscsi_if_set_{host}_param
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wmynxwow.fsf@ca-mkp.ca.oracle.com>
References: <20230723075820.3713119-1-linma@zju.edu.cn>
Date:   Tue, 25 Jul 2023 21:56:20 -0400
In-Reply-To: <20230723075820.3713119-1-linma@zju.edu.cn> (Lin Ma's message of
        "Sun, 23 Jul 2023 15:58:20 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SkLZSGYIKW0gB2wROtIApvhS7drdoo/XhYgjd8y3FQhkZaW9D5hbBfaZdLhx?=
 =?us-ascii?Q?bvXdo+5FKgg11SDvT7Pm74YRes7e9NDNA16XVdaFdXA5Cvrz7q8b9wPUxH7A?=
 =?us-ascii?Q?ua9FCunQZe85djPv7/CrMVND/wI3lJl5VSjEIOTaGss0D5i8v9u46nizbCWt?=
 =?us-ascii?Q?gKbLFA3fvTAlUk7l/ekUBsTKZNF6mEWwo0sp0vsZJZb0etPd9NbXJm25og/s?=
 =?us-ascii?Q?51pBP2IwnasZu5QnlWRsYyvAbso5dBKDdk2jJkrAZHuotpqCQDnPXxPi0p+1?=
 =?us-ascii?Q?gYv9+196mAx7002EWQi1dvVKgWsQfWeCHL8Jve7IN2fAnXt0V7hHhVTro3OI?=
 =?us-ascii?Q?NC2Eek8NwuN9BQ0KVTD7vX1grLhi+Djey8MsD9itjNb3Jw2B0B/B0haLQIV8?=
 =?us-ascii?Q?Zs5PYIXaRCIDIHmpHE0Qn/BD6QDHChRwDD+aL5IhQixR0afXSMEFDgRzsmBz?=
 =?us-ascii?Q?xOA+ZyF0/5lpZZhsuy7n0XAnPbuAhHES8wSWSk7CSJZpSUeSS2Bc9GGPNaTI?=
 =?us-ascii?Q?RNWnA+/uN1KimWV2PMfJe70KNqshlk4m8le4yG0CNqeRztpITjEmQpxXYJHk?=
 =?us-ascii?Q?Y4GQAKrhWqplJ3weN8etckbdD8wM+z52stflk3cD4Ik7j5MpBcIoqpj0q4jQ?=
 =?us-ascii?Q?mjxhmqb2KlWcDJhdSdVmkHnpRbMCeYemUmj6huGUi+0SsTEWPRqJp/ytq3T2?=
 =?us-ascii?Q?jIOBqNgeRHZ6In7tSChUhB/8XsWPj26shIt36f2689ABZr10sQHH6ifUeVY0?=
 =?us-ascii?Q?5rUYSF2mh4eIKF9EQTLGw4D8Or7XAmFr2vdrBcH+B2FNckxl3nq650npt3Rd?=
 =?us-ascii?Q?jxYqHCRHHcFyhe+pwqf60AntxAWRYIi+x2XSfjRzpHHrj3xgr0wAwDOt9fSs?=
 =?us-ascii?Q?J/w4lUIfgkfwZzPmHhrzU/icTy4q9NDZHuMpgdOTuAMOysmgNHC0XMDbHdby?=
 =?us-ascii?Q?/zN5oxBPaCGVJbx4gyx4NH189Qn4iMqRD+7agpaT1/VOMckI8Kfe46FVMMUz?=
 =?us-ascii?Q?SZtbAGq8CRTbeRDEkh84nfYIT4cJe/aWtVvXIl8yjHz1LKxoi3DElxo24LQA?=
 =?us-ascii?Q?tiCpL041kea2dbmvAAoINSWMREIrZHSWDjwdDYUxnqopQrHnGhNTLEASblCf?=
 =?us-ascii?Q?WLWhxYueQoTroO6sEPzCnc/ZNPqrxh/RF1Mt75/Hcx/HMJCKIowhM1OTYstN?=
 =?us-ascii?Q?OgRQKAsk8el990z5zIQTOjtIn0J9HNc3wXmjwpkl88DcdT2CxwnYYx0yLkTJ?=
 =?us-ascii?Q?jK995PDJT0ZiH5jWGjkge0E1ojOpFx8pW06DafzkiWRdwE6v0vOE1qMt+4sr?=
 =?us-ascii?Q?hIw3sJzn3fQtvCB+8GK+KuC0U5GyY2KvzMbjS9abGG5W9c8PlmZEADRqQi0U?=
 =?us-ascii?Q?+SXLYg430MRDem9/9hW66GaggRJwX12PnoduGzuGCSgyDAPDkkf3fUPMCNep?=
 =?us-ascii?Q?CBRmkPUjlrSAUiqsnOFC1jJwV2ZAsOB2ejV7gYx9aAWrIVoup2ztza36CYV4?=
 =?us-ascii?Q?Wmurr0EO6hoz4xIgzAOhoHcXKwYLINi2i56asDLebSvTq5+3Uj4OJk00LcxG?=
 =?us-ascii?Q?nTjiugUS7f4NZ2Y3ELCLJ0eZXGNL1CULS22Nt7x8mnYXX0GA+SBakzFI6+uC?=
 =?us-ascii?Q?Yw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: apR5nScK4gTKWLkGA5mnPov+/o2Tjgzsf3zK8x5EKWuSMZuF2e6v2DLURgognfovyiujeYBpk638Ro+EMuNnxTYbrB6qNt/5YgH6DDGIHC7knvlQT6+4U5paedNeg9Ek23ONdfvH8jss9KYgPyhjdaExMPOTNGrzgvzE3veGFACPbUVYKtMKKPZHEbYM1ja7ZWJRjK0C7yqKQItGUoptU+ks5rgH1U5Ij/CBGKigWpXsYZhxHhPBMmK4GHRt92UBeWpYaZb0BY+lUZavG4btBFUGf2TVFtA496yJUoZf4iwV2viiEfVb4wy1Qs9fCs67lFy0RkQqJJ1inTKStzK+vnAVWYQdO2j/7qRnR+jopFYkwD1WmXrssm/Yz4ZOk3ZzPcvKuI2rxrwmcTt7egLOJDMeIPGV7Obf3AKGU4zZVC0bNErf+yUF3q2c9kgKhT9gX7A/H80UfaSHGhELMrPox74QVCSLNoM6p+ibtuoX3/pvcJ5sfV8xvcXKEtZI6Ib/Mi9IR5BNjaKxU4A2P2H9IUPv5khjbRm/i/nzzHFiGl39aqSKWz/xucdi7Yj3lm/PHLBjoklIKgLqFg5V6TpyNRp17EG7WzfD/fiXnhuWg0Hb265TN++8ia24s57AiHXWXf70C/H/WK5rTdkUc97xPL7GWg/e1Wu/VsSLcWko133AwAicbWbNkh7aqi+3e2BHKFZoP/JGylXJb59+4sOlregXJgimeqgOlu16vBDd8UNbUE3hrwqH3y4ngf/KDbcgUkkwQmtW0RNoTycmFkkQXDWaA1XcwkVuvSMplvSTuMSPhNPmzBncaX6iDd1lN0OaFgNrbO39zIRh5LsCV3ViKBM4DtLrzyrMxJnmD9Nep6WppsgDf8zHd6W5hW3Ixzrk5Nj3rab02uMcWpbiVOH8WRW8gBAobiBWBbB44lpFuCk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a621f4bb-57ca-4c22-b7b2-08db8d7b8571
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 01:56:26.3995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YBF2aRne59mJYPF/VOR8OS+vN8w6N9DcArnFli0GrZOWELhkiuyMQ48mUV/F0eAJeK7zoKTGrMNDWhLeByV7Ww7/KyI1WyFIarZhPvx8cMo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4332
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=855
 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307260014
X-Proofpoint-GUID: SUKTxCbJOFHr8nibe_mJ11WjSecrUrFw
X-Proofpoint-ORIG-GUID: SUKTxCbJOFHr8nibe_mJ11WjSecrUrFw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Lin,

> The function iscsi_if_set_param and iscsi_if_set_host_param converts
> nlattr payload to type char* and then call C string handling functions
> like sscanf and kstrdup.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering