Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Lin Ma <linma@zju.edu.cn>
Cc:     ketan.mukadam@broadcom.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] scsi: be2iscsi: Add length check when parsing nlattrs
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1r0ovxwoh.fsf@ca-mkp.ca.oracle.com>
References: <20230723075938.3713864-1-linma@zju.edu.cn>
Date:   Tue, 25 Jul 2023 21:56:36 -0400
In-Reply-To: <20230723075938.3713864-1-linma@zju.edu.cn> (Lin Ma's message of
        "Sun, 23 Jul 2023 15:59:38 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WmFRabtlzc/QRnrherWUUZlIzrN/uv9TfJ2MipKuZw/NK2o7PQ764a7Y6MZJ?=
 =?us-ascii?Q?1jIRjccfEcqpE7X4qXHcdQXaONZvr7+pd/1J8fjfbQ6PwdyvnNBEh2E6hm68?=
 =?us-ascii?Q?ETxC8toC0n3pwkEMIl8vkmTTSHnw0M7JQ6eS3PDN6E+YDbY1bjMYEq4LLvLw?=
 =?us-ascii?Q?wyr99XtxrQuhu937K6O7jvS767nY9RNWwpiTOUSJMaSlsdsDGyUb7gGV56SB?=
 =?us-ascii?Q?k+7xQHUWAx8DydRt4E0oigE4atkyyYnJuTKwOCmej/mue+zMqXEBMq7FMH04?=
 =?us-ascii?Q?yy9OLhM4IJhx4OZe4t2CCkGpXDO3qpaLtDiiss7bJ6ra+WL1Hdb72gEItVke?=
 =?us-ascii?Q?ANWblNSEXFvGCFWiEJ/tjjfjQ/nR/FxsbL7EN58jRKrBlmo+E+vta/CWYklc?=
 =?us-ascii?Q?fXwMepFaESliL6NeE1sv6RIc1/eGyPlz5BTIp+tC+0pIh4v4tmca54QZ92Y1?=
 =?us-ascii?Q?fhUr6MzuIzVzau/15uqDlX4z9+u5+ZwxLzcMc5Wqs77Om4MbSZqg614ffr/e?=
 =?us-ascii?Q?gT71NuO3t250jcJ6WCrrFocgX5syC0RoPIGjaU9xn2H3ke2eKrjN9EbtCqK+?=
 =?us-ascii?Q?S//rEpYghc3HU6UCxoFWfpipXjlfReL1p5GjOmDZkfxyIgApf3/JAMHxbwOc?=
 =?us-ascii?Q?1wVRDW2gNXzWX9PfF7cHp9cYnEuNkplVAwvQJBSsURiy5UTE1tdw0YL4xVZT?=
 =?us-ascii?Q?9/5P/drYwNVWnYgnygObYrNi6j4vqdjYZ6EwjxPbAiZt156iThfw6CM+G1Dy?=
 =?us-ascii?Q?GRJprEZosaSkl28OLb02AiOGuu61guMRBK1Dw2ieketIRDnoyqfEi9P1X3/l?=
 =?us-ascii?Q?u2ysT8+alenN2xOP6/sG4lxBgy3Qt4G7XQew27FGfkTN7PyHF3MasAi+foFg?=
 =?us-ascii?Q?7SX62Lui8gFmMYig7bC8T/zemH3rWZQTqjXW2dBVwM7cBOXQrSiNYbbOBuvZ?=
 =?us-ascii?Q?IePwB0ur/X4AOhQts3RiJCXGxLoaKCQknJ1BzUa4iZ9DAngYHxY3iMP+qvK4?=
 =?us-ascii?Q?P/XlXU58a1xG4BHWdTFd0EpUeUfR5lzEmDvQ8QJPE0csSE+Lt19Z6UUoiDHB?=
 =?us-ascii?Q?OTgkjI+MwLBnY0GcVEzRUbEEsyCBbeqaA1jkkbexTFGjy7agngmlxRpmESLL?=
 =?us-ascii?Q?KmxeoC0SYS731kk1guN7vdu/+z+UerCQRxq44sj8D4L2QgVW2D2vrvJttAUP?=
 =?us-ascii?Q?TISy2xjnzNFK8HEIX36/oOR1tCbAafzGUdp12cu8A9vp8iuxWA2fls//9T2T?=
 =?us-ascii?Q?nNM5/1aiBkjxWPeTL3mnau2dTHRmD778LTE/R1sAB5K/JAQuKiCfr3CqHTLp?=
 =?us-ascii?Q?exEcOdGxr+EEc0Yoru/qpEFuDbF8+jxqTapqwqirL5JFq1wMxekOqOS+d0NV?=
 =?us-ascii?Q?fADnxvidNEpuYsyFx7cgUE40AeKHh2n3RsiBo5i03puER+wGyR867w7ROIi9?=
 =?us-ascii?Q?IMObh2Ndjo+mJHkENX5EEZQ+maXDOpfjlIyNBdP0jksmZUQoHLweGpeWgxIN?=
 =?us-ascii?Q?+U2fo1kUrWa84JDrjlKq7nLNsF3cc2NCRes3yVgKX3My69QSOtEAfkTyulAF?=
 =?us-ascii?Q?kxfaufbQGu2pDIBFIUixwiKpsmkWWPD3KkXDEQKJL/ARBcUWtGINp8G859Lk?=
 =?us-ascii?Q?Wg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: S/+xzbu0RZSbVe+4f3Zi6BpfcaJeU6QZzGTEB9vyKhLrkW0l2Bheeh1UFWUZG9E7DVOL3KU0EGGAMSFIxIx5V9imdDErwgSEpqxGI6V3HyW56t7f9dRkfeNL5m9TSeMde9QLO6TQoWhXqRvrRYR8UrKp+ysSWaU+uE+qSH4XX/ILfOFmvsPAZn/5njBuoJCQU/G76LjNKByn6UNk/zL+AX46Km/s4l5Jvk9X5T5iPPYK5u1o/7bzSMbhuAkXDY0F+pP7+b8QGvVXXRkMf270FUGWgixXZi1Q54dQlYS3Vbj/SvqyOhitvIfFMu6QmCslFKGdUFSZg6VhDrF2nIe4/gyeSu6wX54kqEYoUu6C7CE9nT7JD8uvCciFXaFJz9P3GgNlYuk2QBImkCWBSRaoiXz5rhPfQXIK8kMSlKKPtef46+lBJNUQM2tD0Bh8E4mBMdaG9mI8/NxeiVCe9coNNjLGLA64jto5ZeXRkXex9sL+wDgSc5tWXOX43Hn0SXo8GstwocD//InS1pDet9/UA97T+hNqOyzTXrx6z5QnCYcmzUIWCrIFCr8zouysGthWTcpN8RaGNYRajgH8t1y4JPznf0XsV/KNRfsClLHmyofm3aMAusLtURMTJsgxacu0AK9WAG8ts2uI4DWGvzqTxOXj82uXk3gADE+/dLFolrgEWBtJrLXPXRU03gTafyAAEI8rLa8QlGy/QnuNOUC22JYlq5AKPYuOzjgwJY9Xup4Iw9Nntm6cpQEKCerCpMBbvYnDrqGdoLQbxiiIG1c+ASWKuizxd5qbsJeYEtik6VyOggFWDKUTmu7HDP/DLMmH57IM/J/3zqGZBF7tLzlR2Pr95PMxAGUqnGjDGqMLP+Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f08e4bb-24cb-4c34-1d8e-08db8d7b8ef1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 01:56:42.3496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /MJyIEf/0gU6x597EpemNT5rKNd5MUe2PiNyjM7WUlsyiv6sg/Ce4fPFWLFqCnRvORdRzSqgXbriGiKhMOFfqHdi1a4E4jgkqCGXB0VXjkY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7306
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 phishscore=0 mlxlogscore=962 malwarescore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307260014
X-Proofpoint-GUID: YOmHOaglZoxN5sU7Nss7w8uIg_HRuaZf
X-Proofpoint-ORIG-GUID: YOmHOaglZoxN5sU7Nss7w8uIg_HRuaZf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Lin,

> beiscsi_iface_set_param parses nlattr with nla_for_each_attr and assumes
> every attributes can be viewed as struct iscsi_iface_param_info.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering