Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Lin Ma <linma@zju.edu.cn>
Cc:     njavali@marvell.com, mrangankar@marvell.com,
        GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] scsi: qla4xxx: Add length check when paring nlattrs
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1lef3xwo2.fsf@ca-mkp.ca.oracle.com>
References: <20230723080053.3714534-1-linma@zju.edu.cn>
Date:   Tue, 25 Jul 2023 21:56:53 -0400
In-Reply-To: <20230723080053.3714534-1-linma@zju.edu.cn> (Lin Ma's message of
        "Sun, 23 Jul 2023 16:00:53 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3zEZLB/Xvl6Y0i6EcGUJuSAAV5sAK9A1X0FKpVpDLjuLjN6/jyth1R/htupx?=
 =?us-ascii?Q?Zxs9XBT3MLEJ7gabDXWKEqumj3EiFSKwDx8d1gU2ZMCnAhuLeZTpbm/RPsng?=
 =?us-ascii?Q?LMJrMQVKajebTAKocAXJ224SdxVQoWBuEHrqHzseKZuiY2PUghAmH/Zte5ga?=
 =?us-ascii?Q?Z3LYVZZm7cvmMmGTrk4HRC7oj+ktmn/lYIq8DYP+ofTGp+bUTKCM1PjQVoKl?=
 =?us-ascii?Q?bCyAJI7z56v1Qtr6Hyc1N0quha3YMQxQ9qY0g0NmaBgitXH0UsvQyA0cNdbZ?=
 =?us-ascii?Q?UB3U1PLDnUo2FLbsIdyoohA2t+uXYzzaz0v+trgPwGjd52JiHKWW3KVb1kY+?=
 =?us-ascii?Q?T0agc/DkGJS/xtPryORugJsdGwfkA93/84RjbldCtJgNbcfJjYH9nDSsWNod?=
 =?us-ascii?Q?x2n2WNBy2k2Boc6azLcviZL86dz+TuC4OToZKY/5Nhj5c8A9Sw8Tyq/p1xkE?=
 =?us-ascii?Q?SwP3TSh4H3oc7BvkGcAuzsiDt/P+9/dtwxgZOLTD/x63DkDE/ndwE1Q139Kh?=
 =?us-ascii?Q?9+wv4OulUQJdnwXZ3XtjbMDQ8RreZgOQEwyzBCf1kCcxsRsHbXlPAhDUchWi?=
 =?us-ascii?Q?BFSkxTIWhsODPqLOJDrB+RoQXZ5qs+1EOktvfAoMJqIEiMu76ZnK6ziQEqG3?=
 =?us-ascii?Q?zcgYuGtd0Vq0wdN8WUO5H7uUm53nCIXXvQ+aRsJ9eCzi0VFYe+Uh+NjQhrbg?=
 =?us-ascii?Q?hPwT39cYyEFX7rVtWM21Vanf/9vQ0UxS6IkU8+zaMXJn2P51fQToK4qLHP1K?=
 =?us-ascii?Q?pCQdDs0bu14vD12KTSuWAHC/GP9QPrccutkfb1HlXzolmIVePe2yK5nibOWb?=
 =?us-ascii?Q?br51Z9cO4eP3VIKlGCdYxS9B4YbGBd7xVT8P0+TdDvIdA13DmuqRyJyn0DlN?=
 =?us-ascii?Q?rcRtuHWbhPIYlCTHFP/MgC+zC5MzKriJ5pLWntjZBHiPVYyMN4MkLRdOCkOp?=
 =?us-ascii?Q?7KVHEhEYlDxOEtf7uw+WXpGD9X4PksDXpwccgjSlBSccOd3dXCR1H4c+nDI1?=
 =?us-ascii?Q?KvWCL7LB+LeGsYwrrUk4IytIbhi3GN6u2gu87mnuu7/L8vlUPnBILq5/qGk0?=
 =?us-ascii?Q?muiHGv/YdVe0NtHIIJTYWpw2pC/uRhpL4bxVLkq496NY2VxlzAgw3cjFq/pU?=
 =?us-ascii?Q?aheJHHUjCvf2DNUji+hW9MreJCY3q1eOl909z+3cAjPOnUDD1NVAB+Wfl55G?=
 =?us-ascii?Q?cF85qNkdIXlwXCQKQcb5G2U4pHGG9qhjtGCPNB8oYTwUSwq5aNGsW8Y9gs1F?=
 =?us-ascii?Q?WPIvNJvA1lk1/CZhZTz/N4pVjZB7f2R4q0nDQUbpNF0sP+8wMH3GTTGxKnZ3?=
 =?us-ascii?Q?8rWfz6IDPuYRZewuNQt9cU9JLFlP6T/dzWJ4rhkr6er3kq2VYHj0WXNuPB6Q?=
 =?us-ascii?Q?6Pg4x82QxQcDjWRRKy5Jf9RlzQdOV8n5ySq5SBb9WT5m4Mu+fWHBtuMDWxu/?=
 =?us-ascii?Q?51qm37R/8NCom0dt0UYcuRfdEygjzyX+9xpqmDES4RFcg2cdS6v4SH2H5w9S?=
 =?us-ascii?Q?Gw4T3/S6nZdIM9GvPVAQ+ZTomBN1WuUhpXPTrOYNG6i726UPpM2CDu7tCkT2?=
 =?us-ascii?Q?0yq0Pyup76io2ltw7mn87N0M3as1wxeI2z7s4fHy6yJ1vlqAaENizf42JXOv?=
 =?us-ascii?Q?tQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CcD8/s+Vwd5C81LY4fk4LChvipNGWj4zZwqWXmHyMZlrHEGjmT8CalrP+pyxvzk24E0fXcfMhyOcMnN+lLTcrr3ZplVOQZ63yDt0Z6aOcL2g1jsMa3/6ktSZM32frHXboSjDIdsQ2w2UWreR4Qfgnqx8BHKJkF3P2NoTwkyinRNFwLP0Hr6HW2A+cIS4I+RmNtVH9qiQujGw+rtEzG6JnW92RfbXJDwjh/SY8UOMXu4qO3UkHA7ke5bs92nvSorxvDvVz3o1Ftpf44KgPisAC4GMyacr2gk7pAnl+FQdzoGhZM3ga6r+RFa5v6prDekVVBTaPqtZp2wXZN0x7CUxJRYQcJABrYS67FXB1jsIVc0EMFGj1jPjAMnTj3WQ8Um0fCvWEiF87o4Dyb3fi4fX7YSJnvHEtENkYsgn0SxjlJWKji0RJlmKseawKKd2TCTrTgtnwZSSagL7Tcsoyns2CHWJnAeAOd3x8bvjNKzVjNDFlibs3LVK2OhejM8VNfvLdxPThBhRIzd4Bbi4leHwcvEQNBS9Jh9X5c7zbQFCV3PNTdE7zxIisuOQYTut0a5ZCz9T2BF8lofu8vFgJ4Bv7qOmY+5qkTvbVxV3eupz0S5vB7iQA8QIYEbQd75bOOo+ccc6kb4nnIDuBLCSg92zmmXpvvgI1/ImmRKmX5qhzxRuI78Nw2gZTjLDCWsogSXQicuDQ71ULJ2QIl3HykQQaQZGGTjGcCwoLN8jLLym6sYeMh6AbSpMT6Oyncyr4v9mymSfO3Aed8bXOA8oK0kDNruBjHOfsp/+z6OGco4egWoPDI/Cgswh3TgSW9i6uiQDyyCHzsOrtE2tw3lWi32Cg02GAI2zmGZCoz7BqLfxwCw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f20bb702-6e7c-4e08-9a82-08db8d7b973a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 01:56:56.2407
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sT9mcuxe+SFErLJtLB+JeFDDNlcskPCtDvXF/O1F1eOuIglzv4aBznpgykwCRqtA2BHrrbaozZsmOd2gk8p5NH/zeN+Rk0QnsHI5u64S57I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7306
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0
 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=845
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307260014
X-Proofpoint-GUID: ekhOfNHEwRixiuQn_LUqEyfGsQhOvUUH
X-Proofpoint-ORIG-GUID: ekhOfNHEwRixiuQn_LUqEyfGsQhOvUUH
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Lin,

> There are three places that qla4xxx looply parses nlattrs
> * qla4xxx_set_chap_entry(...)
> * qla4xxx_iface_set_param(...)
> * qla4xxx_sysfs_ddb_set_param(...)

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering