Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To:     "Luck, Tony" <tony.luck@intel.com>
CC:     Borislav Petkov <bp@alien8.de>, Aristeu Rozanski <aris@redhat.com>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lim, Ee Wey" <ee.wey.lim@intel.com>
Subject: RE: [PATCH 1/1] EDAC/igen6: Fix the issue of no error events
Thread-Topic: [PATCH 1/1] EDAC/igen6: Fix the issue of no error events
Thread-Index: AQHZvs70SFSyROm3IU+Y3Dd4qGeH36/KohwAgACusbA=
Date:   Wed, 26 Jul 2023 02:31:47 +0000
Message-ID: <CY8PR11MB71348563C78864640BC3B9248900A@CY8PR11MB7134.namprd11.prod.outlook.com>
References: <20230725080427.23883-1-qiuxu.zhuo@intel.com>
 <SJ1PR11MB6083D914A12B64369E478BA3FC03A@SJ1PR11MB6083.namprd11.prod.outlook.com>
In-Reply-To: <SJ1PR11MB6083D914A12B64369E478BA3FC03A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mxTHSWPUcJaJUI0Joy/yPFdF5EH/TWTVXSziV96yKHMF6Nz0uneYcRBbF2J4?=
 =?us-ascii?Q?256WQgzUu78t919q/IhUm1ASKEWrjgVnfjq+VpI7Tor5fJ8JESqx3gtu6p6j?=
 =?us-ascii?Q?0u6uKmtxkbTzZy7Xkpdzo/HlauVs38fQnpr23F27F6aLLetI9yLywxy9rL+J?=
 =?us-ascii?Q?GHNRt5RSb6wpkvN2/X0hjEP8NUmUoUYDnIpI4RLHM1eCyAL/TE+Z/SlPn9wS?=
 =?us-ascii?Q?kH0tNRBCalY+Smg2TK7MvpOJluqFJpDUItw1nBXIZgOHqskxU5UpBhKA0XDH?=
 =?us-ascii?Q?iEgFUcQF5+CIv+HHHObl0pHNyCHLm37OC3kNJhoUQ1WKW8P5dbj+r24k6+hh?=
 =?us-ascii?Q?BZCgSO4CiowT4omZFErG4KRd+FntgHPoREbi904AiiIrvIfHLWsnsedp/S0W?=
 =?us-ascii?Q?Lkhoqot8FSnS+XwN3SRaO6LwMJqhmtjdQQl0Exq8Hm6Lwv/Adn6oEOYH5T/S?=
 =?us-ascii?Q?Ox21YB/Klm9tF3ht6vj0vrbDJMTKRuhbrp8Bqe9CmOYM4YpFbhVFWSR1JJtU?=
 =?us-ascii?Q?y6zZRv43UZxou1L68yfNg6to2J8u8voNIVb7jTD2QEIlMg1YXWQ0IcWgUMUV?=
 =?us-ascii?Q?7fZ+9WN1eNi/7AQFFfXPsyuQ2541ljqomT4jxXEl1Q3lQnk+aFzQ7TPWhqT7?=
 =?us-ascii?Q?wAniK0n+kex4mLxRTT0PRjVR8xLjfG3F/q7FguXtCOQj7BsHyL1bPS0Km9vr?=
 =?us-ascii?Q?sFXuPbtdqTegCzFU2tJO5kuH5HQGk3+/0TL77F3y3P9fslZnqLrXCPYSFWb7?=
 =?us-ascii?Q?ZxcWLR4hfbhi2qICFGo+WAEVF7K7N6mEQe0ECAAQJgS0VvW5mzU3deJB7v8N?=
 =?us-ascii?Q?Tr/Z/HDY3l96LlCUEl7TbpLiCBOdHgiF74vd2rPjlLDMV6oDD5zSBSPTL98b?=
 =?us-ascii?Q?gsgBTr9FTG+aVFrBew7bM/ROUxa25RNIShkbFnKVoEKYhY2muFQlXdWfAugt?=
 =?us-ascii?Q?vAzTytXuE2lT/gbJeLM+qFKZm/dAsJRC2Lo5+D/+VCNDpPjbDpGXkDObjc7v?=
 =?us-ascii?Q?m9uuwhKqDICJm0Pjrp2gaWEyfCpzPkoYa0IvGZfncYpFjS2PR1zPH/FAKwtp?=
 =?us-ascii?Q?QGdePhr2/Kbgujvha2d7OXoU0O/R6YbKy8lYwPsI9IS9iP3Uc6ttV6IjHyR+?=
 =?us-ascii?Q?oq3Fi9psbhh6wVfyWpd/Z747HEf/8g09pxol+PEJCoRkihxhVasQWWvKrWBl?=
 =?us-ascii?Q?c1PHR32Pjuk/1iF3v4ziUOaYXTJ4NiVia8Wow70bQwo+bvdEJHcncBSDK+Ol?=
 =?us-ascii?Q?uJ/WFEslNfTgYxIMjintwksYmO0xRwnGXVLCYpJ+bYJINkwbL4oa1nFUtBnC?=
 =?us-ascii?Q?cYTqO2N8aXAiH21vuD2uY7gNax7MYdKL2hnKSllDP5sgJ3AfoWF3bVxZz1in?=
 =?us-ascii?Q?KwiUytRw1Cig/fmJ8Ic7HilMyyt/dRmlM8l0XFrS9Ja03Wk8GcUu3rpmnhcz?=
 =?us-ascii?Q?u2dLARIK/4qtcngQBsiQg59yM0VRkyzMQXGRsJ8mh3fN2FHaqAnubPS3k1m1?=
 =?us-ascii?Q?IBgJhEqKnqH4moqlOPRAQN2iSzdwPVdcogf8b8A1oF01s8f0nejW1dsYkYjL?=
 =?us-ascii?Q?60AvrQ9LWKru3hAA/SPUeSadwQuag7GWCW4AXWRP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7134.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbbf804-43a9-4c23-d4af-08db8d80760f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 02:31:47.8966
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 25ZoU+VAofjgRCGQ34NcH28yRVzBVPEovmPvSouE9qOnyclFgV9cRZJTXL0VoX8MCZrRiKuxHUblK9hROPlu4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4929
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Luck, Tony <tony.luck@intel.com>
> ...
> Subject: RE: [PATCH 1/1] EDAC/igen6: Fix the issue of no error events
>=20
> > Fix this issue by moving the pending error handler after the
> > registration of the error handler, ensuring that no pending errors are =
left
> unhandled.
>=20
> Do you think drivers/edac/e7xxx_edac.c has the same issue?

Hi Tony,

Based on the code [1], the e7xxx_edac works in polling mode and the pending=
=20
errors can be handled within one period after the error handler registratio=
n.

So, I don't think the e7xxx_edac has the same issue.

[1] e7xxx_probe1()-> mci->edac_check =3D e7xxx_check;
                                  -> edac_mc_add_mc() -> if (mci->edac_chec=
k) { mci->op_state =3D OP_RUNNING_POLL; ... }

> 491
> 492         /* clear any pending errors, or initial state bits */
> 493         e7xxx_get_error_info(mci, &discard);

                   This function is also invoked periodically in polling mo=
de:
                   mci->edac_check() -> e7xxx_check() -> e7xxx_get_error_in=
fo()

> 494
> 495         /* Here we assume that we will never see multiple instances o=
f this
> 496          * type of memory controller.  The ID is therefore hardcoded =
to 0.
> 497          */
> 498         if (edac_mc_add_mc(mci)) {
> 499                 edac_dbg(3, "failed edac_mc_add_mc()\n");
> 500                 goto fail1;
> 501         }
> 502
> 503         /* allocating generic PCI control info */
> 504         e7xxx_pci =3D edac_pci_create_generic_ctl(&pdev->dev,
> EDAC_MOD_STR);
>=20
> Though it might be hard to find such an old system to test.
>=20
> -Tony