Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 60/61] mmc: sdhci_am654: Properly handle failures in .remove()
Date:   Wed, 26 Jul 2023 12:00:40 +0800
Message-Id: <20230726040041.26267-60-frank.li@vivo.com>
In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com>
References: <20230726040041.26267-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlRZTmlXdWc1Umgzc3dTOTQ2QU5hLzFac09kd20xbHFiRkVUM0NsU1FvOFJv?=
 =?utf-8?B?L0dTRkFib3ZXYU1NYTVLTDIrRFJUMGhrcW1uMEMzOWtBM3plUlRSdFpGTzUy?=
 =?utf-8?B?STUyTmVzd1NYYXQybkExa3lTdGZTNFhoR3ZxY1ZvUWo3UnFEbzAvN3M0UFFq?=
 =?utf-8?B?UUVRd2NYdmgyNzJmWGx2Q2MzUE1tQlZsNXlMYTdiTWp5SmVaeFNkeFkyZ09E?=
 =?utf-8?B?UVNWRnJJcUJVcCt6OWVoZG9oTDNlM1hsUktONnE5d2tONlFKOU0xK0d1K1lD?=
 =?utf-8?B?MDV2U21aUEJNNkFkSmI3UkdhZnBVQlJ2RUt2Z1NIQmx6ZzJ3Nk1nMC9XanNs?=
 =?utf-8?B?VGROcWRlbHUwOUt5NjFCcUZQT3ZueHd3dFhxVFpNV2ZoTjJ2aytVb0Y3c2dQ?=
 =?utf-8?B?eEVnSmd5RW5ySHFXM21BTHpIOE1ESTc4QnRHdnBYbXp4TkhTeWVsSGlWUFdz?=
 =?utf-8?B?NlJmeHJ4Rm9qMmwyejNhK01MdmhoeGdlVnRlRVRKWCtUZ2VXbnE3T1BpendK?=
 =?utf-8?B?VGNYYVRYNy9weHYwUXpKVVVrS3RtNytUTTI5enV4SUt1WXVYRzJQSHZMRnYy?=
 =?utf-8?B?TXY0UkpBV3VLS0E4ZEd4SlpTYlFKZW1UZ3B4T2Y1OEdmQ3NacVpXaDYxSUJC?=
 =?utf-8?B?aXMzaUlIeHNnd3RTM1RKU2ZWd2F0YjlGbVZ5aXlVQU9VNTNCc2R5K0FNVzBX?=
 =?utf-8?B?ajNCNTNKb0lYNWdieldvNk9yUU56Mm5vUHR0VXREdytldk9VZ25JcTF1RE96?=
 =?utf-8?B?S05JL0xuc2dOdkZmc3p6cllndjNpbWZvTjVNcTMwUXNiVU9ORjBnQzlFZEVP?=
 =?utf-8?B?cnh3OEZFOHVEaUhlUDJHalgvb0tXNkJTem5LZFBMZWRwVEZQeSt3Zmg2LzYr?=
 =?utf-8?B?akZoSGJsOEpsTzdraDNtYVIyejA2U2ZkdlE4aVNxWmR6bTJqV1JrMEFaM0xB?=
 =?utf-8?B?MGZNVHJPc3hwTGxOY0poSWtlV2U0eVdMN1ZPT0trZUwxeEN1MUZ1RWM4bENV?=
 =?utf-8?B?TnRydGMyanl1MVpWaWMwQjhrS3VjZjBtdDVJWGlUNjh3MnRna3hVLytKMWJ0?=
 =?utf-8?B?Q3czRzRmSmdIdU1VaEhlZ1M5THRWSWxnOW8wZ2RvNTZNZmI2YU5NMVhnczA0?=
 =?utf-8?B?T0VFOTAwUzJrTzllWGZlN0ltVDlwZ3NBMUJWOTgybFJJdVE5VnNBeXVEbGZ2?=
 =?utf-8?B?SlJTOVpxVWlKRk5DWFFoMmo3Z2RMQjFOUXBBSGtldnhYdUZ2UkxESXVoWkhX?=
 =?utf-8?B?UnhwaTZ4OEtnWml5Wjd2LzJuOXJjdEtBaVJ0c3pVcll4NVlOdm5vM2FNWXd1?=
 =?utf-8?B?UWpFbkE3c1JpRS9RSUZmamtsUDJpRDgySkF2eStiRmtQOVgxUURQU3ppblVN?=
 =?utf-8?B?QjUzQnVuZ3p2L2pSdS9TcEZ1R0hJbmJYcGs2d0k3RTZ2Rm9zOTFBV1Z4amFF?=
 =?utf-8?B?Z3RpaGUxeEJ2RTE4V0thc250b2lPMjBXSWM0V3dRMm53UG1KY2JWUDUwK2Jn?=
 =?utf-8?B?dDJXRnFMMDczUWxuZC9pbjJpcytxOElaZjV1NDM3SmZvaWI2b0M2YUFKaXMr?=
 =?utf-8?B?SmNpaWswVkx6bFdCYUx4eVFHSGhWc04xOXVMb2RzUGEwK3NuWDV5WlBqc1ZL?=
 =?utf-8?B?bXljS2tESmo3NUhzUko2eEExUmVlSElzTlcyV0xjOTM4S3N4UCs5c25oQm91?=
 =?utf-8?B?TDFvOHIwVnBjYVZKUGVQYmJGaGdnM2s4QVhxalJ5WEVtd3B1U09VRUZVQkM3?=
 =?utf-8?B?ZXB5MDVBdzhDQmE2ZGt0anRBbTNsNVlEdDNtZjhjQjVRY2RFZWNPYXdUcDgw?=
 =?utf-8?B?Rko4NXRNeVJXdG5RNStyLzhiQ0Z6bkVmbCt1YXduc3l3QlBzb1NjZklJejNW?=
 =?utf-8?B?MDNwM3czaVRaRkdjMnBZRzV3dk5CcjNobUIxQW9qbWF4RnlGNGxLMWlpSXI2?=
 =?utf-8?B?aHkwMEM5dzFNZldOT1d6bEp3Y1RDQjJadDFzWHRoaHU0L2FqTkNvNzJIZTJw?=
 =?utf-8?B?aVY3NmFPZTEvbjNsZFZxZEh5Rkl5VWpXRjViclRNdGpRUHlNVjY3YkMyMkwz?=
 =?utf-8?B?N0Q4NjZOc3o3VEYvaTF5TEplK3d6R1ZxZHVJZk5ydVZ3azh0b2ZoYXB3amVF?=
 =?utf-8?Q?AN8bemQeWwPBAI3ZUihzjT97w?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 299dbdc6-bba1-4a3a-b0e3-08db8d8d29ac
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:43.4139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nzmImaRH4xntLXGWw0CUzhdvlLw31KrdFlRZ/rj7c9dTox1fVRrvKlo3NVKBaaE16qUcard734UTY14HwK+gRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Returning an error code in a platform driver's remove function is wrong
most of the time and there is an effort to make the callback return
void. To prepare this rework the function not to exit early.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/mmc/host/sdhci_am654.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index 7cdf0f54e3a5..abe83736d396 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -873,8 +873,7 @@ static int sdhci_am654_remove(struct platform_device *pdev)
 	int ret;
 
 	ret = pm_runtime_resume_and_get(&pdev->dev);
-	if (ret < 0)
-		return ret;
+	WARN_ON(ret < 0);
 
 	sdhci_remove_host(host, true);
 	clk_disable_unprepare(pltfm_host->clk);
-- 
2.39.0