Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Angelo Dureghello <angelo.dureghello@timesys.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 49/61] mmc: sdhci-esdhc-mcf: Convert to platform remove callback returning void
Date:   Wed, 26 Jul 2023 12:00:29 +0800
Message-Id: <20230726040041.26267-49-frank.li@vivo.com>
In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com>
References: <20230726040041.26267-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmlvTDRrUGIrV212ZWdMOUhEaGZ2dlhNUzgvSEp6MUFEazBTZ1VSVkMzNWZX?=
 =?utf-8?B?c2ZDN3BMTk1nQjNxUmZYQkdDdE91c3k4c2NxbHg0c0ZXc2w3TkZUSVFaUnQr?=
 =?utf-8?B?N0E1dGdEeWt5UUFiV0dTNytkZWNzTWZoYWtLTnNFdktoaStmYWxFMVJCcEFY?=
 =?utf-8?B?bUo3MXd1VGdiZTljNGxnUDMvVFVPaVpzRjFmRFFuQjNtKy9NTmE2OFFOTkJE?=
 =?utf-8?B?NGk4T0gzZjd6K2RuYkdRYWVzQTYrVmltb29oNmgramFqWU9oNjVhclhFQTJa?=
 =?utf-8?B?TG9jSzZjNy9uRGlhdkJmVzJXUWl5cVM5bjArQXVpM1M1QnliSFFoajZ3K090?=
 =?utf-8?B?NHBOeVdOckFLS1RpZHVua0RBbGFxSEZKTEZBMi9LQmhMS2tYMFpORERzaTZr?=
 =?utf-8?B?SFhRQmQ0dmJ3UGFSYldRVDZlQjNZNUdSQmt2NEY0c3VweHBhV2pJWDRBZTAw?=
 =?utf-8?B?bHlwdlczRnBBNnM0NUZlZ2VxZ2FCbEV6ZE4zYTAyM080SHdlVnNTSzlaQ3V1?=
 =?utf-8?B?OWhMWWlQRlFSR3l5VVFTaFJ4YktBQnk4Nno2RnhmZWJDMXFZUklXT0JMR29Z?=
 =?utf-8?B?K1VoYnAyQklSVzI0ZEFCdlNhN3JDcEcrQjV5N21JK3A3V1VSWXBtUkVndFVi?=
 =?utf-8?B?SzUrWldrRGFOYlNPdG1laHJOak1FUDBqT1kxVGZOWUl5SVVTOHdId3oxaS92?=
 =?utf-8?B?NEdZODM0Z3FZQlZBdEdNeUkwbnV0cGlqVlA1aG04TGR1WCtiY3QzTTMzNytk?=
 =?utf-8?B?MGNrVTVkZ3AxMy9KZnF6R2NuRmRTWHRBbVFXS2xzMzJ4UTRibE8yK0NVbnpE?=
 =?utf-8?B?YWI0cnNteWw1Q3l0dldaWitFclVyUFkyMkcrSHRRZEZCd3hPMkNtbEVMTVVI?=
 =?utf-8?B?dS9IdjU5aElncVNKeUVzak1pa3lVTTZsTUx4OHJ1VHUrVmovd01zdGN1M2h5?=
 =?utf-8?B?aU5FMEYxdjFJMm92dzMvaERzaEZjRUFmOEVFczU3Zk55Ym54T0tKbGY3L2pl?=
 =?utf-8?B?ZncxbndnOFNoUXF3dXY2T3hvb3BxenBXcWNJQ2l0QTVjLzhHbWpmOU1yTDhk?=
 =?utf-8?B?NThLb1lzWSs5NmFmYmtCOHFXeWcyTFhBSkxFRGtpanJKZkw4akNTc3pkSWpP?=
 =?utf-8?B?NFVSTmowcldBNHpFTHExUCttWDN0ZEJqdTk5S1FEcUl5bndhTDZEQ2MvUjBo?=
 =?utf-8?B?TVhHKzBWVVBpT2kxcmJoNmU0WVdlem5qZkF0bjRXVXBERVp2bDVuckdDZSs1?=
 =?utf-8?B?T2FLSHdkTlBiV05XbFZCbWo3L2Rxd3ZBbkFiYUhCcmMxVzUwRU5BdkNrOTJn?=
 =?utf-8?B?SXkvM2FrZzFyWnVXZGNNNVZNaCtqMDRqTWZRWVFNdEVJZnlSanlSN1RwOTIr?=
 =?utf-8?B?U2p3NTAyVXVRb0pETStqMitGK3hrSFNGT0JoVlFzMWJ6eVpFVURSaGJPZE0x?=
 =?utf-8?B?anRncVIxSDVLYUhRbTFFMkxLUmtKWHRTT0h2U3lINjYyU2ZVYnpBMUNaeWZv?=
 =?utf-8?B?R1JUY05uS3JhOVErTDh3U3BYM2lsR0J1ODJhenYvNStoNkdvM0xJdGIxS0Fr?=
 =?utf-8?B?ZGwwdkN2SUNzR3pGYk1YeDFVcnhsSUx6MFd1ZnRLc2UrTGZacUNiUFBmbHhL?=
 =?utf-8?B?Qyt6RmVJY0JEVmYxVDZBYTBYNTRWTk5wSXdKWkpDaTYrSC9lYTFyOGtLdnVj?=
 =?utf-8?B?S1NBaGprZU5CamtrcGFONnlyOFVjMkVNQXF3U1FBQXZjV3pySCsrdnVCTUxY?=
 =?utf-8?B?MVozbXJRMy9ZUmNtTVRuTzhHS21Lc0l2ODZNLytrc3NDK1dtZDZqSndWL0hm?=
 =?utf-8?B?cnFVQUVyeDZoMXY1SXVBOGMyMHRMQjNCdXF6SXVFU3RXSGNnUFRKcjFDeFA2?=
 =?utf-8?B?SWtwdFJUMjZTaFJqWmppUFJQSFRRM1hCZUdTb1daQ1ZGdkYwMjhqVjVzU0Ex?=
 =?utf-8?B?TUJDc3JiaTc4QTRPV1dBMUQ0ZytGc1JjYnZTdGlvc0kxcnJiU3FCbGtuYkox?=
 =?utf-8?B?dEVDMkthcENyS254Z3JNalBLVXVTblArRUlaUDZ2SzNFaS84elRFMzRPb1N0?=
 =?utf-8?B?Q1JyKy9HMWRTUFNvVzdlR0VRQWhPZ3JNL2QzNGlLNGlXWmZiaksyUUpBcVVZ?=
 =?utf-8?Q?ReAvyCI+mqod3YzkaezaOWYmi?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9890010-9db0-4489-4369-08db8d8d1e93
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:24.6947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2e6/KT1yLzCuutA7LTshaDm6CJd7CQMXvjbkehI05pG/DvMqSoAvaGyZ9yeZ/uI3msAxpWwltp2FhVhQFFMRPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Angelo Dureghello <angelo.dureghello@timesys.com>
---
 drivers/mmc/host/sdhci-esdhc-mcf.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
index 05926bf5ecf9..a07f8333cd6b 100644
--- a/drivers/mmc/host/sdhci-esdhc-mcf.c
+++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
@@ -489,7 +489,7 @@ static int sdhci_esdhc_mcf_probe(struct platform_device *pdev)
 	return err;
 }
 
-static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
+static void sdhci_esdhc_mcf_remove(struct platform_device *pdev)
 {
 	struct sdhci_host *host = platform_get_drvdata(pdev);
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
@@ -502,8 +502,6 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
 	clk_disable_unprepare(mcf_data->clk_per);
 
 	sdhci_pltfm_free(pdev);
-
-	return 0;
 }
 
 static struct platform_driver sdhci_esdhc_mcf_driver = {
@@ -512,7 +510,7 @@ static struct platform_driver sdhci_esdhc_mcf_driver = {
 		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
 	},
 	.probe = sdhci_esdhc_mcf_probe,
-	.remove = sdhci_esdhc_mcf_remove,
+	.remove_new = sdhci_esdhc_mcf_remove,
 };
 
 module_platform_driver(sdhci_esdhc_mcf_driver);
-- 
2.39.0