Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 16/61] mmc: rtsx_pci: Drop if block with always false condition
Date:   Wed, 26 Jul 2023 11:59:56 +0800
Message-Id: <20230726040041.26267-16-frank.li@vivo.com>
In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com>
References: <20230726040041.26267-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEJucmp5dmdndzVsREZCOCtoOVFtRFN2SFBydFM0OEpxdUU0OU1GZ0p0Umh6?=
 =?utf-8?B?djBGVmtQa1hNZkVMalpsMFdRbHRiMjVqUHZqalVrRFBhTjN6ekRWWUFqNmpL?=
 =?utf-8?B?TDBDNWp6Y3hiNHhqMVBPejdDdjc4bzZ0VVR0cHlzUDVwTHRtNlVaVnFYVXN4?=
 =?utf-8?B?Z1l1cXljNmQ0cXllK0plNWwwMHdYZ1h0WmZGWGtBa1FQV2JRWkFRb1NPUFQ0?=
 =?utf-8?B?dmRYWXhyS2xOeVA5elNZQW9uK1RSVGtkK204NFdLMFNZWldYa1BaYVN5ZVNF?=
 =?utf-8?B?VmxRYlBqSnIxRFlIQTA1aWdJRk92YzZRTjljNGFUSllXQlM4OEJlbkw0S0lo?=
 =?utf-8?B?a2V0dndBcFFNb1pBV2hvMmF1SVprSHhaQVNCeEs2RnZnSEg4TGtHQlByRUxV?=
 =?utf-8?B?T041M1o1V1pUY2x6WGpzSEtrbUxRN0FDRExPYTQrT3JBdW92RlFyQjJVeEY2?=
 =?utf-8?B?VEJjTEpsbTRFNmFvcHFzUklENTVDbEVzblpmM2lXem1RK1BhS1c5WnRlWkg4?=
 =?utf-8?B?Sm1ybE8vaTZxbThTSkxDNHhMRk92VjFidkdiWXkrS3ZvQVcwcHFOY0FqcnJD?=
 =?utf-8?B?K1d0S3BsTk85czNFWG03a1c2VCs2QlVzV0FOR1JZcFZDcEh2RVVmM1BMZVc5?=
 =?utf-8?B?dTR0cDRaWjVjRmxWZ0tudzBCZDVscjkzeDgvK2JtYXFpejJFVGZnamIwb2Nq?=
 =?utf-8?B?MkhvYWdJQTJIWWRDbEVHQnpWV0tjK3QrVGNtcVBYU0xENnlCUHFTNzQ2SlE3?=
 =?utf-8?B?TXYxR3NPSkRTS1NHWlIwRVk0UGhZdS9Wa2JxZEhlN3daeVUrbGt1K2U3WE45?=
 =?utf-8?B?anZBWWFzZ2ZEN3p0d2NXbFRnRHlRYTdXTWRSOWNnMm0vWDAzcFR3bWk2bTNm?=
 =?utf-8?B?L2M0V3NCSXVKN0o4TXZDZkNlUUZHMmJFeUJLOTllU2JRRzVMUDZJTnBUOVlD?=
 =?utf-8?B?UktxWWtISFBEd0tDQjFhdDR2TnFtUm9oVlh6d2hnaSsvRVJzbFZ5N2tCVHhV?=
 =?utf-8?B?QnF2OG9BcXpiWnpuRllUZlBidHh2eGMrTklUWlNlQ1dyMFhncXZmdHNLWS85?=
 =?utf-8?B?UURZaVZqc2hJemhtWFpsUUIycjNTZURXa1VGTTNBNnl2bWdZTXUwZE1FTytk?=
 =?utf-8?B?aEZSQlQwWUJQbGN0ZWtBY3NWUjhtTWlUZExYVVgxdDZ3YmdONWVobWJObmpE?=
 =?utf-8?B?blJiNkxDTFdsSFBiMkx4OE9oaGNBNHB3OERySDl1U1hZTDBQWm13V2VLNmlP?=
 =?utf-8?B?bzhjOXFMajFyNGE1ZU5VS3FOTWRtSW5XOHR4SGlEMmFpZnlUVGtLb1QyWVVt?=
 =?utf-8?B?Zjllbzg5YXp2Rk5hQmt0MDZPSU5tTkpNOTVCUlUvQWFMNlU1dTZSa3JLTncv?=
 =?utf-8?B?eVVuZFpNNDV3eWEwZ084cllqOEd4ZC9JZlRJUi81YnF5MDF1L3lBZTdyZnMx?=
 =?utf-8?B?TGhINDZMaVdJUEVLZUQ5QnBuanYxb0p2WDVtTU4yc3dkOHJhelhvYjZYS3RF?=
 =?utf-8?B?TGllemNqblMzWGpBbWZwcGZsd2R5TGtORzNDYnI1bmF3MEo2Q1AvUytPWGIv?=
 =?utf-8?B?a0JvTlNkUytYMHZSQ0VKNUVMWXI4L3E4L2s4cC9rMHFyeGh3QnpEY0FEZzZk?=
 =?utf-8?B?TUZ4UlRXNXZoVTBlM3J2YVp2YUlka0hlQW15Vys4U09NTGFZekR5bTdScWl2?=
 =?utf-8?B?MnA2K0lSTUJ5OXRNWEhCRmNaUUVhZzdaQkFPaGdZRzNkVnUzK2xVazEvaElp?=
 =?utf-8?B?WTRuWnNJNiszd1VVR29vMUpLVW1SaVM2ZHJWcjVNWUJCVlY3SW5DRWdCUVl5?=
 =?utf-8?B?c3ZRYno2SXJhTHp3OW8zR3NzaWEwcmQxaXZrOHdSWWg1dFhRZGc0aXRHRktW?=
 =?utf-8?B?RkZmYms2NjZqdUVQZG5wN1h5cnN4RXhnWk1hUWEvdVJKVXJBMTdCajFRTHhr?=
 =?utf-8?B?aG1UOVRabk9sVzlZU2I2OVZjTStuN21tdjUwRFJuTG5uc3ZhYnNPRUtFRDhy?=
 =?utf-8?B?WXFpcEl1a1VMUmExbDdJTXRkeWdld1V6cWhsaW56UFd6SWFVbXJraTBNcWVt?=
 =?utf-8?B?c2tIUmUrZGg0Z1dsNTFaZlhqcjl6ZEdLRDlvRllMbE1GRTBxMmQwcS8wRWxr?=
 =?utf-8?Q?l7TagmVxs+jMXtovZPTbG/O5q?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5202d598-0408-45b3-31d0-08db8d8cfba8
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:26.2065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TKsUSwmPsYn3/wYiMVBsT1h9qk+Xa53U4r5rSrPgJfKH0PqUVCDmhqUebC7jTPa7aSB7uZZ11x7ntT6y4rJ3kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

rtsx_pci_sdmmc_drv_remove() is only called for a device after
rtsx_pci_sdmmc_drv_probe() returned 0. In that case platform_set_drvdata()
was called with a non-NULL value and so platform_get_drvdata()
won't return NULL.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/mmc/host/rtsx_pci_sdmmc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index 8098726dcc0b..062d07c2ae5e 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -1529,9 +1529,6 @@ static int rtsx_pci_sdmmc_drv_remove(struct platform_device *pdev)
 	struct rtsx_pcr *pcr;
 	struct mmc_host *mmc;
 
-	if (!host)
-		return 0;
-
 	pcr = host->pcr;
 	pcr->slots[RTSX_SD_CARD].p_dev = NULL;
 	pcr->slots[RTSX_SD_CARD].card_event = NULL;
-- 
2.39.0