Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <feb58221-e481-3d71-8707-6ffe90158b66@intel.com>
Date:   Wed, 26 Jul 2023 12:44:58 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v2 2/4] madvise: Use notify-able API to clear and
 flush page table entries
Content-Language: en-US
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <minchan@kernel.org>,
        <willy@infradead.org>, <david@redhat.com>, <ryan.roberts@arm.com>,
        <shy828301@gmail.com>
References: <20230721094043.2506691-1-fengwei.yin@intel.com>
 <20230721094043.2506691-3-fengwei.yin@intel.com>
 <CAOUHufY2tdO0JNTiY=RzHitR7CB1cM5kA=7bd6nbCUW6KM_OVA@mail.gmail.com>
 <05bc90b6-4954-b945-f0d8-373f565c1248@intel.com>
 <CAOUHufYJE40wcT4HTYFJ_7X5=my3OPbMyMBt+QNZdByuL6j58Q@mail.gmail.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufYJE40wcT4HTYFJ_7X5=my3OPbMyMBt+QNZdByuL6j58Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L21QVnlqV1JKWEVHUXptMDVLREhCOUNFTUtqQ09mSzBEN2xkVHlYSVdkby9R?=
 =?utf-8?B?Rk0za2tUcHNRNWgyVWlPZThOc2x3UUdlV1JXa2NMZWZsUzFwRCtDbDZUclZW?=
 =?utf-8?B?eE5uZjZDaEpZQ3E2Mm4wQXczS09LSEE1bStOdlg1Nk5WVnRHSEtHdWE5WllT?=
 =?utf-8?B?Q3NYSGhTV2lVdGZRUy9xRVppaWJ0UFVvSkZyNWpqbW9QamwxZXRwSUVPOVZL?=
 =?utf-8?B?dTJQYXRONnRab0VSbFFkN2RZdE5YMEhGR0dzeEU2MWllL3Jac1JsZmFWdTF2?=
 =?utf-8?B?M0RDcTBJTHhOM2FhSGdkV0cvK0ZzWGh6QzZPcnR6dFovNlg4SEdURWMvQTU1?=
 =?utf-8?B?ZFJocXlOa3ZRQ3lGUWJaOThSNnlzaUZ3TjJsYjFJTkRqUFFCRU5rVUJ3TGc3?=
 =?utf-8?B?VTFxcng5RTU1dGZweXFjNUhZQ2dSTE5qeGhnY2twelVDN0o3T1d3eGh0MkQ5?=
 =?utf-8?B?M2EyOFd4TW1UNzV3VW1ab0pOdmk2SXFjRTNpNndvS01SVndiVFZuenhlRExq?=
 =?utf-8?B?OGY3aDgyT2ZCbHAxcUhRUzduVzNZT3labUo4VUdYT045c2FCb0pmUmVidWJ4?=
 =?utf-8?B?dzFPaFZqOW1SK2hONXdVTFIyVkIwNU5PUGhtZUo0d0VvTzA5TzVETFJrUzBD?=
 =?utf-8?B?enFXTDVrbE9uUWRUUlhXTXM1R1JGaDlnKzd5QkNXZHhRdjQ0dmtiQ3lnRWtF?=
 =?utf-8?B?Q2l5WHE0VmpDalJrSE53dXpPeWJvMTBuMm40Z0JLVTFBeWZpTUp0alV1WUkx?=
 =?utf-8?B?N0pzU0hjK2NBSmVyMGM3dGE1cTFvR2hJZFFlaXFQTml4VEgwNi9vWEM5WmZL?=
 =?utf-8?B?ZlErMnZseEZqcm1nZDIrb3M2MWlNdVNDQ0NSSHZwT2JhYldRK204YTlQUnNz?=
 =?utf-8?B?WHlIZHNzYlAzK2FWWDVUakFvVXlzQmROTDQyQWZ0bWptS3lDR0UxQk1xZmxH?=
 =?utf-8?B?dTBBYmx3UXRUaUZtRm9lRHAyWVIwK2wvTkJTQzIvWU1Sck1XOVM1T2sreTA5?=
 =?utf-8?B?NlU4SWozU3pnSnU2V3BVTDB3Ti9TMlVGb0NVenZySVB6YU1vcjRHaFFPN1ox?=
 =?utf-8?B?aEx0a1pzdGw2dEtTaFMxUzBZZlAxME9kWlpPNTRRNW0zRDlmMHJYV2t3RUZ6?=
 =?utf-8?B?TWNaQjVnSUp1VDB3R0w1NHNBS2hIUE1ZTUd5YmVLdnNiZGVpWlJ5R29ra0Y2?=
 =?utf-8?B?UjlkRXNxckUyVm1sZ29sdnFNaTJrT25DWDhENU5Wa2ZaS3RHd0hCbXdaN1Av?=
 =?utf-8?B?bmVTK2FsK0R0NDNkOE95VkNlbVJzRmg1eGpZMnViVUtNU3dDb0FSUDRTUVVG?=
 =?utf-8?B?aWZwY1gwQ1B0d044Z2dNalE1NG1hVmtkRWZHdmtlMyt6ejFpUzd6eElvTVJk?=
 =?utf-8?B?NTJNRU5GYXNLQU5TOXZONVN6Z0ErdnhIK3FaMHJWZFpuOWQ1cUlOdVpwYnBI?=
 =?utf-8?B?YXRGd0pKOTNQWnRlci9EMVgwdFZVS1RiODZvMkRabkF3SjZMSkNPU21qUjJv?=
 =?utf-8?B?R1ZFU3lVVm1xSEZIa1YrOHNBcDNML011ZU1JWXJzYkUrY0I4Q2x6MFU5QlhL?=
 =?utf-8?B?R0pBWGcvVjZub0s3dElmTkg2WnIxbTlCZGZQbEU1djJzYnhMY3ZOT214NWNw?=
 =?utf-8?B?VXNvOUN5L1dTMkU0YzhINjlQVTg1ZklxVzR4Y2gwcjhjQURnaURPclVPbm96?=
 =?utf-8?B?TGh2UUpCZTZTTEJOK1d5K3RQZXhMcDRLZkRiTzFYN1NSTlU4ZWVNRXl6a05x?=
 =?utf-8?B?UTBVYmx6WmRjc1lvaFM5UHdYRk1pZnNFZ0Y1dy9LM3RVNVBYSGYxd1lIdldj?=
 =?utf-8?B?d1NRRDlkWmNJKzRqRFN4MWZYYks4WHhMd1hUK2FhMzc0TGgycVkxOTc2a2E3?=
 =?utf-8?B?T29HZTB6eEZqNjVGMGxwL295dXE4aGI0ZlB4QjlPbisyb3R0aWJxVW5Ya3ow?=
 =?utf-8?B?ODVTNHRVcVE4N0hsbXlwMVN1NVdXUUdaeDR5cnlKeUNGL1N1cnZ2dkNQRnMx?=
 =?utf-8?B?SWIrVDI1bjJFSjE4Wk5LZHpwMmtXcVhYUlhzaUtQbndBMTl5Q2RaamFjOWdO?=
 =?utf-8?B?SkVLNHl6d21CS01xOUw4aEE4UUhzb3NtdVpsMG9Kbk9jWEE0U0h5VHdvVjZV?=
 =?utf-8?B?MEwwTFI1cHRzTmxreW0wbGs3ellCWncveHdxcjBsYXpRbENqVUh0ZHZxMWNy?=
 =?utf-8?B?c0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbbbaaa1-5893-4f3e-4131-08db8d930c8d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:44:51.9555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tFBHhmxZADlkHoRq9RnKWsjYDWij5IvpNn+MmNKBOXS9oT6zCDwYSm/h9y+X0CsC1UWEXQYmo/6IDgHfFxXtJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/26/23 11:26, Yu Zhao wrote:
> On Tue, Jul 25, 2023 at 8:49 PM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
>>
>> On 7/25/23 13:55, Yu Zhao wrote:
>>> On Fri, Jul 21, 2023 at 3:41 AM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>>>
>>>> Currently, in function madvise_cold_or_pageout_pte_range(), the
>>>> young bit of pte/pmd is cleared notify subscripter.
>>>>
>>>> Using notify-able API to make sure the subscripter is signaled about
>>>> the young bit clearing.
>>>>
>>>> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
>>>> ---
>>>>  mm/madvise.c | 18 ++----------------
>>>>  1 file changed, 2 insertions(+), 16 deletions(-)
>>>>
>>>> diff --git a/mm/madvise.c b/mm/madvise.c
>>>> index f12933ebcc24..b236e201a738 100644
>>>> --- a/mm/madvise.c
>>>> +++ b/mm/madvise.c
>>>> @@ -403,14 +403,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
>>>>                         return 0;
>>>>                 }
>>>>
>>>> -               if (pmd_young(orig_pmd)) {
>>>> -                       pmdp_invalidate(vma, addr, pmd);
>>>> -                       orig_pmd = pmd_mkold(orig_pmd);
>>>> -
>>>> -                       set_pmd_at(mm, addr, pmd, orig_pmd);
>>>> -                       tlb_remove_pmd_tlb_entry(tlb, pmd, addr);
>>>> -               }
>>>> -
>>>> +               pmdp_clear_flush_young_notify(vma, addr, pmd);
>>>>                 folio_clear_referenced(folio);
>>>>                 folio_test_clear_young(folio);
>>>>                 if (folio_test_active(folio))
>>>> @@ -496,14 +489,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
>>>>
>>>>                 VM_BUG_ON_FOLIO(folio_test_large(folio), folio);
>>>>
>>>> -               if (pte_young(ptent)) {
>>>> -                       ptent = ptep_get_and_clear_full(mm, addr, pte,
>>>> -                                                       tlb->fullmm);
>>>> -                       ptent = pte_mkold(ptent);
>>>> -                       set_pte_at(mm, addr, pte, ptent);
>>>> -                       tlb_remove_tlb_entry(tlb, pte, addr);
>>>> -               }
>>>> -
>>>> +               ptep_clear_flush_young_notify(vma, addr, pte);
>>>
>>> These two places are tricky.
>>>
>>> I agree there is a problem here, i.e., we are not consulting the mmu
>>> notifier. In fact, we do pageout on VMs on ChromeOS, and it's been a
>>> known problem to me for a while (not a high priority one).
>>>
>>> tlb_remove_tlb_entry() is batched flush, ptep_clear_flush_young() is
>>> not. But, on x86, we might see a performance improvement since
>>> ptep_clear_flush_young() doesn't flush TLB at all. On ARM, there might
>>> be regressions though.
>>>
>>> I'd go with ptep_clear_young_notify(), but IIRC, Minchan mentioned he
>>> prefers flush. So I'll let him chime in.
>> I am OK with either way even no flush way here is more efficient for
>> arm64. Let's wait for Minchan's comment.
> 
> Yes, and I don't think there would be any "negative" consequences
> without tlb flushes when clearing the A-bit.
> 
>>> If we do end up with ptep_clear_young_notify(), please remove
>>> mmu_gather -- it should have been done in this patch.
>>
>> I suppose "remove mmu_gather" means to trigger flush tlb operation in
>> batched way to make sure no stale data in TLB for long time on arm64
>> platform.
> 
> In madvise_cold_or_pageout_pte_range(), we only need struct
> mmu_gather *tlb because of tlb_remove_pmd_tlb_entry(), i.e., flushing
> tlb after clearing the A-bit. There is no correction, e.g., potential
> data corruption, involved there.

From https://lore.kernel.org/lkml/20181029105515.GD14127@arm.com/,
the reason that arm64 didn't drop whole flush tlb in ptep_clear_flush_young()
is to prevent the stale data in TLB. I suppose there is no correction issue
there also.

So why keep stale data in TLB in madvise_cold_or_pageout_pte_range() is fine?


Regards
Yin, Fengwei