Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 06:48:39 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        linux-ext4 <linux-ext4@vger.kernel.org>,
        clang-built-linux <llvm@lists.linux.dev>, stable@vger.kernel.org,
        patches@lists.linux.dev, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org,
        Theodore Ts'o <tytso@mit.edu>, Chao Yu <chao@kernel.org>,
        Darren Kenny <darren.kenny@oracle.com>,
        Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [PATCH 5.4 000/313] 5.4.251-rc1 review
Message-ID: <2023072631-repaint-ultimate-cc30@gregkh>
References: <20230725104521.167250627@linuxfoundation.org>
 <CA+G9fYuH-jyxJwgEgX4J4+eh=nEEk9aqt4YPNUW9j==mwtw=jA@mail.gmail.com>
 <a3849202-24f9-4ad0-f10c-a4a6f8627e80@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a3849202-24f9-4ad0-f10c-a4a6f8627e80@oracle.com>
Precedence: bulk

On Tue, Jul 25, 2023 at 08:48:03PM +0530, Harshit Mogalapalli wrote:
> Hi Greg,
> 
> On 25/07/23 8:16 pm, Naresh Kamboju wrote:
> > On Tue, 25 Jul 2023 at 17:06, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > 
> > > This is the start of the stable review cycle for the 5.4.251 release.
> > > There are 313 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Thu, 27 Jul 2023 10:44:26 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.251-rc1.gz
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Following commit caused build failures on stable-rc 5.4 and 5.10.
> > 
> > ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
> > commit c4d13222afd8a64bf11bc7ec68645496ee8b54b9 upstream.
> > 
> > fs/ext4/ioctl.c:595:7: error: incompatible pointer to integer
> > conversion assigning to 'int' from 'struct super_block *'
> > [-Wint-conversion]
> >                  ret = freeze_bdev(sb->s_bdev);
> >                      ^ ~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > 
> 
> I have seen this error too in 5.4.y build.
> 
> Just more information about this.
> 
> In 5.4.y:
> struct super_block *freeze_bdev(struct block_device *bdev)
> {
> 	...
> }
> 
> In 5.15.y
> int freeze_bdev(struct block_device *bdev)
> {
> 	...
> }
> 
> This changed in this commit which is in 5.11-rc1,(not in 5.4.y and 5.10.y)
> Commit info:
>   commit-id              : 040f04bd2e825f1d80b14a0e0ac3d830339eb779
>   subject          : fs: simplify freeze_bdev/thaw_bdev
> 
> 
> Thanks,
> Harshit

Thanks, will go drop this as well.

greg k-h