Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 22:41:17 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Nitin Rawat <quic_nitirawa@quicinc.com>
Cc:     powen.kao@mediatek.com, bvanassche@acm.org,
        alim.akhtar@samsung.com, adrian.hunter@intel.com,
        jejb@linux.ibm.com, stanley.chu@mediatek.com,
        asutoshd@codeaurora.org, quic_cang@quicinc.com, mani@kernel.org,
        martin.petersen@oracle.com, beanhuo@micron.com,
        ebiggers@google.com, agross@kernel.org, Arthur.Simchaev@wdc.com,
        konrad.dybcio@linaro.org, quic_ziqichen@quicinc.com,
        quic_nguyenb@quicinc.com, quic_narepall@quicinc.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V1 0/2] Fix hibern8 enter failure during host reset
Message-ID: <h6icfhn6xi2iuibrnum5rfre3yeycilkxtowzfu5gwh6mptbua@nhhitqvbwzp4>
References: <20230725192710.26698-1-quic_nitirawa@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230725192710.26698-1-quic_nitirawa@quicinc.com>
Precedence: bulk

On Wed, Jul 26, 2023 at 12:57:08AM +0530, Nitin Rawat wrote:
> Commit <52a518019c> ("Fix missing clk change notification on host reset")
> added clock scaling notification to ufshcd_host_reset_and_restore.
> This invokes hibern8 enter and exit on qualcomm platform which fails
> because controller is in reset state.
> 
> Fix this by checking the Host controller state before sending
> hibern8 command.
> 
> __ufshcd_wl_resume()
> ufshcd_reset_and_restore()
> ufshcd_host_reset_and_restore()
> ufshcd_scale_clks()
> ufshcd_vops_clk_scale_notify()
> ufs_qcom_clk_scale_notify()
> ufshcd_uic_hibern8_enter()
> 
> Fixes: 52a518019ca1 ("scsi: ufs: core: Fix missing clk change notification on host reset")

Sorry, I missed this before I looked at the individual patches.

The cover-letter is not included in the git history, so this information
will be lost. This explains the reason for patch 2, so please put it
there.

Thanks,
Bjorn