Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 10:40:36 +0530
From:   Pavan Kondeti <quic_pkondeti@quicinc.com>
To:     Elliot Berman <quic_eberman@quicinc.com>
CC:     Mukesh Ojha <quic_mojha@quicinc.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Sebastian Reichel <sre@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <kernel@quicinc.com>,
        "Satya Durga Srinivasu Prabhala" <quic_satyap@quicinc.com>,
        Melody Olvera <quic_molvera@quicinc.com>,
        Prasad Sodagudi <quic_psodagud@quicinc.com>
Subject: Re: [RFC PATCH 2/4] power: reset: reboot-mode: Wire reboot_mode enum
 to magic
Message-ID: <e6060e0f-7c1c-4c4f-bbc1-ebafb11cc91f@quicinc.com>
References: <20230724223057.1208122-1-quic_eberman@quicinc.com>
 <20230724223057.1208122-3-quic_eberman@quicinc.com>
 <27d9bd35-b69c-5596-8e1a-c42ec2b01f75@quicinc.com>
 <fa1c8f0d-f949-0e20-5ff3-b98fd4d64ada@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fa1c8f0d-f949-0e20-5ff3-b98fd4d64ada@quicinc.com>
Precedence: bulk

On Tue, Jul 25, 2023 at 02:04:28PM -0700, Elliot Berman wrote:
> 
> 
> On 7/25/2023 3:03 AM, Mukesh Ojha wrote:
> > 
> > 
> > On 7/25/2023 4:00 AM, Elliot Berman wrote:
> > > Allow the reboot mode type to be wired to magic.
> > > 
> > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> > > ---
> > > ? drivers/power/reset/reboot-mode.c | 30 ++++++++++++++++++++++++++----
> > > ? 1 file changed, 26 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/power/reset/reboot-mode.c
> > > b/drivers/power/reset/reboot-mode.c
> > > index a646aefa041b..4ea97ccbaf51 100644
> > > --- a/drivers/power/reset/reboot-mode.c
> > > +++ b/drivers/power/reset/reboot-mode.c
> > > @@ -22,12 +22,8 @@ struct mode_info {
> > > ? static bool get_reboot_mode_magic(struct reboot_mode_driver *reboot,
> > > ??????????????????????? const char *cmd, unsigned int *magic)
> > > ? {
> > > -??? const char *normal = "normal";
> > > ????? struct mode_info *info;
> > > -??? if (!cmd)
> > > -??????? cmd = normal;
> > > -
> > > ????? list_for_each_entry(info, &reboot->head, list) {
> > > ????????? if (!strcmp(info->mode, cmd)) {
> > > ????????????? *magic = info->magic;
> > > @@ -45,6 +41,32 @@ static int reboot_mode_notify(struct
> > > notifier_block *this,
> > > ????? unsigned int magic;
> > > ????? reboot = container_of(this, struct reboot_mode_driver,
> > > reboot_notifier);
> > > +
> > > +??? if (!cmd) {
> > > +??????? switch (mode) {
> > 
> > IIUC, mode will be filled up with reboot_mode during restart
> > notifier and not reboot notifiers ?
> > 
> 

I went through the patch in isolation and came to the same conclusion on
why you are using mode directly here. Now that it is clarified, why
not use reboot_mode directly instead of introducing restart notifiers
here?

Also you might want to clarify that we are using reboot_mode as fallback
to wire the magic.

Thanks,
Pavan