Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-36-frank.li@vivo.com>
In-Reply-To: <20230726040041.26267-36-frank.li@vivo.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Wed, 26 Jul 2023 14:00:37 +0800
Message-ID: <CAAfSe-tGktZs_yeprSw7o=Vi00sbjvwf1od2wEeX3-E0gog9_g@mail.gmail.com>
Subject: Re: [PATCH v2 36/61] mmc: sdhci-sprd: Convert to platform remove
 callback returning void
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 26 Jul 2023 at 12:02, Yangtao Li <frank.li@vivo.com> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

Thanks,
Chunyan

> ---
>  drivers/mmc/host/sdhci-sprd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.=
c
> index 7f4ee2e12735..379cb3892757 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -720,7 +720,7 @@ static int sdhci_sprd_probe(struct platform_device *p=
dev)
>         return ret;
>  }
>
> -static int sdhci_sprd_remove(struct platform_device *pdev)
> +static void sdhci_sprd_remove(struct platform_device *pdev)
>  {
>         struct sdhci_host *host =3D platform_get_drvdata(pdev);
>         struct sdhci_sprd_host *sprd_host =3D TO_SPRD_HOST(host);
> @@ -732,8 +732,6 @@ static int sdhci_sprd_remove(struct platform_device *=
pdev)
>         clk_disable_unprepare(sprd_host->clk_2x_enable);
>
>         sdhci_pltfm_free(pdev);
> -
> -       return 0;
>  }
>
>  static const struct of_device_id sdhci_sprd_of_match[] =3D {
> @@ -800,7 +798,7 @@ static const struct dev_pm_ops sdhci_sprd_pm_ops =3D =
{
>
>  static struct platform_driver sdhci_sprd_driver =3D {
>         .probe =3D sdhci_sprd_probe,
> -       .remove =3D sdhci_sprd_remove,
> +       .remove_new =3D sdhci_sprd_remove,
>         .driver =3D {
>                 .name =3D "sdhci_sprd_r11",
>                 .probe_type =3D PROBE_PREFER_ASYNCHRONOUS,
> --
> 2.39.0
>