Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 22:34:18 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Nitin Rawat <quic_nitirawa@quicinc.com>
Cc:     powen.kao@mediatek.com, bvanassche@acm.org,
        alim.akhtar@samsung.com, adrian.hunter@intel.com,
        jejb@linux.ibm.com, stanley.chu@mediatek.com,
        asutoshd@codeaurora.org, quic_cang@quicinc.com, mani@kernel.org,
        martin.petersen@oracle.com, beanhuo@micron.com,
        ebiggers@google.com, agross@kernel.org, Arthur.Simchaev@wdc.com,
        konrad.dybcio@linaro.org, quic_ziqichen@quicinc.com,
        quic_nguyenb@quicinc.com, quic_narepall@quicinc.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        Manish Pandey <quic_mapa@quicinc.com>
Subject: Re: [PATCH V1 2/2] scsi: ufs: ufs-qcom: check host controller state
Message-ID: <qlxiohqdw52tb3d7duvv3rlusfzo6n73wipmeracchbp7ajrzz@d6ebtuqaldsw>
References: <20230725192710.26698-1-quic_nitirawa@quicinc.com>
 <20230725192710.26698-3-quic_nitirawa@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230725192710.26698-3-quic_nitirawa@quicinc.com>
Precedence: bulk

On Wed, Jul 26, 2023 at 12:57:10AM +0530, Nitin Rawat wrote:
> Check host controller state before sending hibern8 command.
> 

Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>

Please read https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> ---
>  drivers/ufs/host/ufs-qcom.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8d6fd4c3324f..95412e98a598 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1254,6 +1254,10 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba,
>  	struct ufs_pa_layer_attr *dev_req_params = &host->dev_req_params;
>  	int err = 0;
> 
> +	/* check the host controller state before sending hibern8 cmd */

That is exactly what the two lines does, but the comment does not
provide any insight into why this is done. Keeping a comment here seems
relevant, please make sure that it adds value.

Thanks,
Bjorn

> +	if (!ufshcd_is_hba_active(hba))
> +		return 0;
> +
>  	if (status == PRE_CHANGE) {
>  		err = ufshcd_uic_hibern8_enter(hba);
>  		if (err)
> --
> 2.17.1
>