Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lu, Brent" <brent.lu@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "Rojewski, Cezary" <cezary.rojewski@intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zhi, Yong" <yong.zhi@intel.com>,
        Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
        "Bhat, Uday M" <uday.m.bhat@intel.com>,
        Terry Cheong <htcheong@chromium.org>,
        "Chiang, Mac" <mac.chiang@intel.com>,
        "R, Dharageswari" <dharageswari.r@intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: RE: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
Thread-Topic: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from
 ACPI
Thread-Index: AQHZuqoaXCiyShA7oEmUALJNRLZwbK/Ip3CAgAAMRwCAABEQ8IAABnIAgALQmIA=
Date:   Wed, 26 Jul 2023 06:16:41 +0000
Message-ID: <CY5PR11MB6257F604AFC69AEE6AF025599700A@CY5PR11MB6257.namprd11.prod.outlook.com>
References: <20230720092628.758834-1-brent.lu@intel.com>
 <20230720092628.758834-2-brent.lu@intel.com>
 <dc6de509-6984-1434-b53f-9600e8bc7c49@linux.intel.com>
 <ZL5Jzod5NBETv9Dp@smile.fi.intel.com>
 <CY5PR11MB62579D3B679BB437017529D79702A@CY5PR11MB6257.namprd11.prod.outlook.com>
 <ZL5dhosg28uIpcFd@smile.fi.intel.com>
In-Reply-To: <ZL5dhosg28uIpcFd@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vv9qSDdD+rGkBOs9dYjjYR8aW+4vpLljCb1767u/1owItru0z4haOFRGazGv?=
 =?us-ascii?Q?py87raFaWFvWU7qBC3tjcJscv/UEEcPzgwRDhSeb0SHV2PWnnA8Uu1fvddTz?=
 =?us-ascii?Q?wK6UXazhrP1CuOYmtfzLl8KHQDpEIa1/YQlygLJnE2AnJF5MgtPbnhI77Ud8?=
 =?us-ascii?Q?/b+SP+lSPs9RKu5+tKJDQ9RQ7tU8Gi8tSMPP6ppYZn2BZMDutVa2V2+8APlP?=
 =?us-ascii?Q?mjIg/acKZK+6J7NuASu5lrHThNVqX6aP/unT/0mkgwGvHIAWAXd6BgLYWhyi?=
 =?us-ascii?Q?eRcTg+VOwOv5xQfwj3LAj6hc6WnxKhiZ3g4gjB/1oMLPEQMkXFIXKrEcZ6E0?=
 =?us-ascii?Q?7yEw83P95rY0KVvdklKrh8oTxNDyYnkGzMB/hcNupxi1hFbJEQQOPVQHTAzn?=
 =?us-ascii?Q?c3XzXr6pATpoEWz6evXpJflTL0fw5ioxXnjOyciPh2DXWtdl7MUVqjvboJHE?=
 =?us-ascii?Q?Wzo9h3XxpU+HZ+tuX+oyePHvofHCgUfCy71rlr7N1WDkcd04ddC2OP5KJTmm?=
 =?us-ascii?Q?LYeZJ4RPkdDj6dd9nDS78L0NPM9OVmfScXmHAo02RLokF6c8mbzQ/4RDegPx?=
 =?us-ascii?Q?zQsFHefpviYkWtZOz8UvqU76Mg69ayacxn/pg3VTlisM4Ajj4XJ8KbUVB+Cx?=
 =?us-ascii?Q?5bPXQWX66Lv5pjNF9a1iKNyobwjFEaUYF2o4zuiRViVy0O+1y8jfatbDhFMT?=
 =?us-ascii?Q?MMg3lolPBARkoTB1JQUq1NeroiU0Zb42jCvzS7AxB6lpzVqo+UZ9FufvUv6k?=
 =?us-ascii?Q?7e+ZzaZqf439OIZ+5z8K+qLPjGTkjQgbAbWHdANoQD3O6tOZGkiwiGMeBt/t?=
 =?us-ascii?Q?mDveEjjd4xVZlIBMqzSUVK6d353L42/toosZGqZ4pwwVIQJNVQRJN9T0J3f+?=
 =?us-ascii?Q?WG3PTDEjVUGIexXaZbPoFjjxNEGwAekt0CKNf/YK1zuLGqNpliqdc7EGq9NV?=
 =?us-ascii?Q?vkoupodIzDUv2gUOY7qtcQc/dduaR5uSgMbLfXlKXyzDg+4uKCl2K9F1t+6M?=
 =?us-ascii?Q?6a2/4+WdT+goa7171VhtqyP2H0eI3v26IY8IQ5JEBw7YMBUdfKgKNgVmYfHz?=
 =?us-ascii?Q?MhvGy4zWK/xu49mPhHyc6akES/QJdcDagMCX3ASbDeYpKMWb6z1oYC18UW6w?=
 =?us-ascii?Q?1cnL1c0HlNzzRLNBcJTGnLcXjogEknAW9tB2mA8RXKYed0By1+YXO4Pw/YbB?=
 =?us-ascii?Q?6GUedLk6VHHwVqohXDzdf7ZdwC+hTkVvVMfVgPlEHGoRX2rfFYoJsq0gjkt5?=
 =?us-ascii?Q?pHEHoPK9qlfjcQ3dnXcy1Ti3byEwL6w7aIeIfC0tn+3E735wHXjSFa4LTBjW?=
 =?us-ascii?Q?qPkGc6/LDzQ0NpzwzPpet10jzwXnQvxYMX9/+uot+mkEfPjyDTglotIburfT?=
 =?us-ascii?Q?d01RUWea4Rp6O1/XmvfQ1vcGuLrfa0/U5/+/JfIvPVSqtReztAVrCgSLBQwe?=
 =?us-ascii?Q?t/5YAbisJFdwidkuqqy4uAjpRZ8LTxvHF2VSURBMNBQK6QH2HREyotspIvuQ?=
 =?us-ascii?Q?gPCRZ2WxMf0dBWbeHkyY+aQ2PhrW1zq1qerTJMsueiiuOvWQ7UW1kOvrde94?=
 =?us-ascii?Q?k+J0xEiXhvuqo9eQyLs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6257.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 920c7602-6802-49af-f625-08db8d9fe09f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 06:16:41.0735
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tNDdEEGft4D2HQLuOMDCzITtFTbsPDjGHOQ+QvYt5Mw8fgbE38lonyUWugYtiYYyYZ4xKTpspiVxYnTaOWL++Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5973
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>=20
> size_t here or at least unsigned int is more correct.
>=20
> > 	for_each_acpi_dev_match(adev, hid, NULL, -1)
> > 		dev_num++;
> >
> > 	return dev_num;
> > }
>=20
> Otherwise, yes, that's what I have in mind.
>=20
> > Will test it in next few days.
>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20

Thanks for the review. I've modified the v2 patch accordingly.

Regards,
Brent