Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ratheesh Kannoth <rkannoth@marvell.com>
To:     Ido Schimmel <idosch@idosch.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
Subject: RE:  Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors
Thread-Topic: Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors
Thread-Index: AQHZv4WcdOjFet+fgEO5Lq9DdQwRQw==
Date:   Wed, 26 Jul 2023 05:54:16 +0000
Message-ID: <MWHPR1801MB191836F446F204B6A36844F7D300A@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20230725032451.505189-1-rkannoth@marvell.com>
 <ZL+gHkLnLE91YBkS@shredder>
In-Reply-To: <ZL+gHkLnLE91YBkS@shredder>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TH/Z/Pz3+mD9L5DBDKvd2xrhOjgCD0gGN0uoMw2PEpV9YXQokKRZ2VOj/itZ?=
 =?us-ascii?Q?PKTJptwLfMAIESo6t/1dobaie5guzFYBTXcXhIPSNlPnlwjAwG7og90QavaX?=
 =?us-ascii?Q?xa7iIyF+zUQshEBetUID0NP+ngYQJiX0zW2h7qOZ2yBzmTwHDGmMAVRaMNAG?=
 =?us-ascii?Q?egJX6VSx/ploZ7kHFhcgw1ixJQIIBcHRFtEETBPEVXBxFlXjGxLW5hXzPOVl?=
 =?us-ascii?Q?0YUMnv7drtjox+JEPCKlcKmEKjwt23WeR2wyaAhMyNmCfi/fMjI/L4Y9cnaF?=
 =?us-ascii?Q?6xz1WTbAcmpBSZ1InepMHrmjrKbyMXsA+1mm1bUSz5JaCVq/YCEfmW2wthip?=
 =?us-ascii?Q?VC+Op3YVb5mERsRAkiCwXjPBkrMDozS3eReuPydLVpINJCg1bx6hTH7hPhoc?=
 =?us-ascii?Q?9yIJugncuR0XVY1L9s8pPV/HK6dxeKOS/dCsdK52Wb52iP4kuOyyE5LztoyT?=
 =?us-ascii?Q?Jj0XB/mnRaVUd2M2MT0eNxKlsCi2ZYPLiU/U+3K2kFeO0uS/+5JtUufAx3P4?=
 =?us-ascii?Q?HgP3VcKJX2lYKiD+6LhKzZV7fc9/yOUBq5zvrlnMEHeBSBjRAbapsfzwg779?=
 =?us-ascii?Q?PP40Lb1iWbUqEcbb/e4ZFmWCiljcjvpYoElUaUJRXbobKBkmTemJWQlY6eef?=
 =?us-ascii?Q?XkGW5ALOUzFHWGmykx5ZBPIQOvNdG9KZ/c64uu3iORVe3ccmLj3muwfk4Wht?=
 =?us-ascii?Q?SADG/PHVq2WXtbcBL2fOACIiiVZfmmIkbUFLMt3Ux0UfQL7KC3HMn/IRVbrN?=
 =?us-ascii?Q?78AgB+gyzT3AWzrOY5G4IzyXnwRhpLkxP8y96lPTrAEhwPefHfZVUL/s3NHO?=
 =?us-ascii?Q?KlvjIuZG/o5luHP0MvzYSyCddg+RobAwD5772ieWVlU91l8Cw0LeupmAWCdz?=
 =?us-ascii?Q?0wUSGEjcHyL8UwVhn59AimWuHbAqyblxcl56nEgWmyaUbPXLiaSFxKoI8eBM?=
 =?us-ascii?Q?gbuLKxe+iYSWJRUEfQ8IfjBX/+m9sSdp3twTScVgN1o/u2dVHOQGulK8efup?=
 =?us-ascii?Q?M+hvnnN/kflBFSjQnDexTUy5nWlO07SbzO0aP8Yz/EWuZ+H3lkc594UahQ3l?=
 =?us-ascii?Q?zegEv/FbKoERABOvKfvKZmgo8P1Cp+Qu/0YhMKHrx53axrF6perKOKrY6UGN?=
 =?us-ascii?Q?dyKon4KRSKmUZM810p/q9fQy/6mQ23i54LTRBt+o91ifsIIxpdqUgYRJgbq3?=
 =?us-ascii?Q?EKvemNx560MDoxtXw2UiB8uucuHWJ77LfUXHJiMNqQNj8gNvxpZPKjRNN8FT?=
 =?us-ascii?Q?ecOMLKKxhcsFMUgA7u4gP+IkXkrimIKyKLtd7TTDQ7TD3hL2fZIxELdTMGBS?=
 =?us-ascii?Q?7yr0O/5b50JkX8WTs/N6z0scovdrEa3uqHpkBRy/3WmzQFYu2ZePFTRgJX4j?=
 =?us-ascii?Q?immsN4mMlhFFIxMkfQ3OyVsH8zin/4OptnNnvpGHAmJghxgori98Vn8LxgFN?=
 =?us-ascii?Q?4AMw8tu6LkU/sgEiXGxNm78WpXJN8O2dn6n8qAwWjHKMLZatxtg+1FaJCKr6?=
 =?us-ascii?Q?4K/SwWXAtRy24LTpUt1g7jGBadVRlHrjl20cf97nL8C8wA5oQjsqKCUo+fG7?=
 =?us-ascii?Q?ocILVw1sw0y+c3qfp9n9FX40ltC81qW9vmRIFjfq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10638db2-c68f-4dfe-2b4c-08db8d9cbf5f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 05:54:16.7952
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5lbt+OhQvyEqKbCtC+r+xDaOCe0W8j9XxNLJtQ/KbocvoV+eNMYm8XhDToyaeb9su9xAkDJxrDC3d6eLr/dN5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3625
X-Proofpoint-GUID: _SLW_JdJB2QxLLZWXsmwd3fxrgJbvvtU
X-Proofpoint-ORIG-GUID: _SLW_JdJB2QxLLZWXsmwd3fxrgJbvvtU
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Ido Schimmel <idosch@idosch.org>
> Sent: Tuesday, July 25, 2023 3:43 PM
> Subject: [EXT] Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors

> >  include/net/flow_dissector.h |  9 ++++++
> >  include/net/flow_offload.h   |  6 ++++
> >  include/uapi/linux/pkt_cls.h |  3 ++
> >  net/core/flow_dissector.c    | 53
> +++++++++++++++++++++++++++++++++++-
> >  net/core/flow_offload.c      |  7 +++++
> >  net/sched/cls_flower.c       | 18 ++++++++++++
>=20
> Please split flow dissector and flower changes into separate patches.
> Also, you can't add the flow offload bits without a corresponding driver
> change. Nobody calls the exported flow_rule_match_ipsec() function.
>=20
Ack, will remove offload related code from this patch.


> [...]
>=20
> > diff --git a/include/uapi/linux/pkt_cls.h
> > b/include/uapi/linux/pkt_cls.h index 7865f5a9885b..a90b0e3d351f 100644
> > --- a/include/uapi/linux/pkt_cls.h
> > +++ b/include/uapi/linux/pkt_cls.h
> > @@ -594,6 +594,9 @@ enum {
> >
> >  	TCA_FLOWER_KEY_L2TPV3_SID,	/* be32 */
> >
> > +	TCA_FLOWER_KEY_SPI,		/* be32 */
> > +	TCA_FLOWER_KEY_SPI_MASK,	/* be32 */
> > +
>=20
> This will break existing user space on new kernels. New attributes must b=
e
> added at the end.
>=20
> >  	TCA_FLOWER_L2_MISS,		/* u8 */
> >
> >  	TCA_FLOWER_KEY_CFM,		/* nested */