Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 09:02:34 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 60/61] mmc: sdhci_am654: Properly handle failures in
 .remove()
Message-ID: <20230726070234.4im3v23qbago763b@pengutronix.de>
References: <20230726040041.26267-1-frank.li@vivo.com>
 <20230726040041.26267-60-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mb7py2dtbfutl63d"
Content-Disposition: inline
In-Reply-To: <20230726040041.26267-60-frank.li@vivo.com>
Precedence: bulk


--mb7py2dtbfutl63d
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 26, 2023 at 12:00:40PM +0800, Yangtao Li wrote:
> Returning an error code in a platform driver's remove function is wrong
> most of the time and there is an effort to make the callback return
> void. To prepare this rework the function not to exit early.
>=20
> Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  drivers/mmc/host/sdhci_am654.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am65=
4.c
> index 7cdf0f54e3a5..abe83736d396 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -873,8 +873,7 @@ static int sdhci_am654_remove(struct platform_device =
*pdev)
>  	int ret;
> =20
>  	ret =3D pm_runtime_resume_and_get(&pdev->dev);
> -	if (ret < 0)
> -		return ret;
> +	WARN_ON(ret < 0);

You must use pm_runtime_get_sync() instead of
pm_runtime_resume_and_get() here because in the error case
pm_runtime_resume_and_get() already calls pm_runtime_put_noidle() which
is repeated here in this driver.

Also WARN_ON is a pretty big hammer, I'd go with a dev_err() instead.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--mb7py2dtbfutl63d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmTAxQkACgkQj4D7WH0S
/k51NwgAktdF0e8v1rBrxIzaK20EAwbITFou+8sdxKFCWruhIUq7bNIBj1ws7uzO
ztJL2yqPQpj4T28JKALELmkcvuvAf3RG2BKHfbdETIMOjhNr58Xpk04PmrQMQU3W
cmWBYnItCndnmLNbyTSEHFM86hjpWMx3hoF37XImhU71vnpHeLAfRUYWLfkG+X4H
ke48+SUE33kWgjjaBb8+9P8aNdxrKnVNO+KStb3b+JONRbpRmDVM6wIiow1b/dwS
mqZlLpznQxIwtp5w47eKj3ThZttrB0WVQnG6BaYahIDNz/dxfVurYEmvbQjcimhS
O/xpTYl5WyP+qzfgDT2QLIbbH0/1Gg==
=VGBu
-----END PGP SIGNATURE-----

--mb7py2dtbfutl63d--