Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ratheesh Kannoth <rkannoth@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: RE:  Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors
Thread-Topic: Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors
Thread-Index: AQHZv4s+7k5xaAqBg0mV3Vs3ZY/+NA==
Date:   Wed, 26 Jul 2023 06:34:34 +0000
Message-ID: <MWHPR1801MB19180BF179A96933AC4E0070D300A@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20230725032451.505189-1-rkannoth@marvell.com>
 <ZMAnk5Kl3qp17fko@corigine.com>
In-Reply-To: <ZMAnk5Kl3qp17fko@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/gCYtkGV16f0MdEhrGeAm50d+el7KX2dH0BNJpSFBgF2xMDKiyNngLZ57+Zk?=
 =?us-ascii?Q?20OVfGVkNaGjMqqKLGBkjqQeRzDwwn5TzbePGSlIhNPqDDlVeTyvhl7Znyzj?=
 =?us-ascii?Q?Apaq/xNRDk88OVaiJI91Ku1afdJ63o8G3ezx9lEvRph309DKA2sDfeK17Lvv?=
 =?us-ascii?Q?DfeY7cLce4jfXq3o7A2nnzIQAKbDM4rMPRS9fZdSdfGsmQx4XNlW+Ay0l0pp?=
 =?us-ascii?Q?83r3ID3LMnX/BjRUOwx6hh2677ujf4WataRSMEkoK58YUB30cvHpRtXFiZ7p?=
 =?us-ascii?Q?HF+MxpUz9ZPI4gTf2xMeZqcQ5sVt0Hxf4ShS8Kl4HDmJ3M0YQBqrW64km+zt?=
 =?us-ascii?Q?cZm7uedxQ4X+mhDGRAh0bewAzgFbtna6xtENnANTg5Yb6EtPxLgZW6AjKKhP?=
 =?us-ascii?Q?rgah54QmLdGhjGtdz4nsUcbQ3D4UoInwHJyZiTNr4GwqChDppKKsHpbA3H2x?=
 =?us-ascii?Q?pb4Rs/enD0qvIkMbepYvhdB0hT4OmNQ5Ko5YMPjl0UZGnUb2FgpM48GBh1rA?=
 =?us-ascii?Q?fLoSKg0R01OBX9wAXhrzQdGudTCkuObTzE1Z6dGX2rNxlZEipVhrGbuHce8e?=
 =?us-ascii?Q?7kRnITMn5bsfA05cXYpIzDNLAZ+tqyNEPGSltTWM106GU3/CX6A2zzkNfbTI?=
 =?us-ascii?Q?iY7C2L9mhovJI/KPwNvsKs2+RfNV64Z1UE8dKZaMavVKRcp7aXL2FskwlgG4?=
 =?us-ascii?Q?JiX9nyGWWar6chN4CXuMO1jMf/N4ky0/L/4stKTrmEYI0txxcNwVKBM4Kp6u?=
 =?us-ascii?Q?YzTHoXmJ2IUzZLTM3jREadSaeuOEvgoInmMZoxtRQfU4hEcU6OklxoVDFiRR?=
 =?us-ascii?Q?VAq3ZG6Abq22oJnKwtTdH8NhRa3LUYSYrZlrnA5HCKl5x3W2p0vfniMGaa0s?=
 =?us-ascii?Q?RkZSbOq7eW7KxvepKAjua80yA8mE0WiUA0hXO/71XTmmJmvjSEcYFXcbN/45?=
 =?us-ascii?Q?oIp/nusxpUxJOka3IQou/6nf2e28ylQ3O9C5jCfpOJmqEttJje05GxcKHOLa?=
 =?us-ascii?Q?Li39TZ2NG7BxIX+BT5hbHgNjkuTIqzKj0wKh3TdjrL1ctDPBkxditGA1tLOx?=
 =?us-ascii?Q?ltEqUFJkmbPii6GDiiDqa35tziuQ5pzw/2jH5LFMLYHMuCjtmSRmX0nyIFhA?=
 =?us-ascii?Q?fxKpSfjzjEx2Vh5x2Mw2SNbTql78LgjPPjaBZTEfc5afSvfLudhZmIiELCCQ?=
 =?us-ascii?Q?SgwwiswQWSRwjTcuBKAKqTX4M2VJ/hv5BOnG0tXhg0vH9fk4WTg4hJxg9Sn4?=
 =?us-ascii?Q?ijsHnV0cA5fTA8c7mZOrzc5ggsQRdVLA5U1SIcwon7p1JoaOKZGRz1zJUn3H?=
 =?us-ascii?Q?gD1U90s0+Ug99UzqFWY9Mse+voaWYFHHNDFFJ+H7eRBwBT2UTikMpkVFRO+Q?=
 =?us-ascii?Q?0Nmy/+/biiSlHlHQzBWkXJh28pkLUIlq5wZrS56hQsoXlWjqO6AA0gHi2kae?=
 =?us-ascii?Q?MaSMsjhcK8WO/ezhilkEcUwSTIX1nwXRTd3FZRZm4pvYCgzuvr1NbkHXTx1H?=
 =?us-ascii?Q?1C6HoTRGQn0sNAUUwOCVyK15M5bgqiGtMa1i1eWlf+ZSzbfKlwoyC4Vt3M+x?=
 =?us-ascii?Q?tKtnjynRH6fMOtvN9cCBpuOt9pUnreUkIaMk+gNH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c2fcb22-5870-4475-afb0-08db8da26090
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 06:34:34.6934
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ee6eXzIhpSelEqi62e05p6kKKajRdDGL0EQ9f5yGs9jvIehGvmpOkhCbb5I9KTeIzNp+g7chSGf9HITAmOV+RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4268
X-Proofpoint-GUID: KDPcTCxwHmQ1lq6g6cVZ1QmPS3abhUqc
X-Proofpoint-ORIG-GUID: KDPcTCxwHmQ1lq6g6cVZ1QmPS3abhUqc
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Simon Horman <simon.horman@corigine.com>
> Sent: Wednesday, July 26, 2023 1:21 AM
> Subject: [EXT] Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors


> >  	FLOW_DISSECTOR_KEY_NUM_OF_VLANS, /* struct
> flow_dissector_key_num_of_vlans */
> >  	FLOW_DISSECTOR_KEY_PPPOE, /* struct flow_dissector_key_pppoe
> */
> >  	FLOW_DISSECTOR_KEY_L2TPV3, /* struct flow_dissector_key_l2tpv3
> */
> > +	FLOW_DISSECTOR_KEY_IPSEC, /* struct flow_dissector_key_ipsec */
> >  	FLOW_DISSECTOR_KEY_CFM, /* struct flow_dissector_key_cfm */
> >
> >  	FLOW_DISSECTOR_KEY_MAX,
>=20
> ...
>=20
> Hi Ratheesh,
>=20
> With this change, this enum now has 33 values, excluding
> FLOW_DISSECTOR_KEY_MAX.  I.e the range of values is from 0 to 32.
>=20
> But dissector_uses_key() looks like this:
>=20
>=20
> static inline bool dissector_uses_key(const struct flow_dissector
> *flow_dissector,
>                                       enum flow_dissector_key_id key_id) =
{
>         return flow_dissector->used_keys & (1 << key_id); }
>=20
> And the type of the used_keys field of struct flow_dissector is unsigned =
int, a
> 32bit entity.
>=20
> So an overflow will now occur if key_id is FLOW_DISSECTOR_KEY_CFM.
>=20
> This is flagged by Sparse.
>=20

Thank you !
1)  How did you run sparse to detect this error. When I ran  below command,=
 it did not throw this error/warning ?
       make  C=3D2 net/core/ V=3Ds
      sparse version is 0.6.4
2)   Is it okay to change  variable type of  "used_keys"  from "unsigned in=
t" to "unsigned long long" to accommodate this.
       This variable is used at lot of places in the code.=20

-Ratheesh=20

> --
> pw-bot: changes-requested