Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756694AbXJ1RsV (ORCPT ); Sun, 28 Oct 2007 13:48:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752387AbXJ1RsH (ORCPT ); Sun, 28 Oct 2007 13:48:07 -0400 Received: from py-out-1112.google.com ([64.233.166.180]:62061 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381AbXJ1RsF (ORCPT ); Sun, 28 Oct 2007 13:48:05 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=K2RISwaHCZOK/D/9ULFgdn3kul3ipicOUqJ9xVKu52jJg3kyrZ5UJKn5lEz1cuViS0AWsd9/2urKI/lWLcxwolaYtTLEiuccI2Ftko+Hd3OVodH9IBa9ur0kabQ49cwvT0PxHOrFTm1glx4eSyR0b1kpurwp9wFzP/DaEHcFPyg= Message-ID: <64bb37e0710281048x589ab063o8a32294e30488979@mail.gmail.com> Date: Sun, 28 Oct 2007 19:48:03 +0200 From: "Torsten Kaiser" To: "Adrian Bunk" Subject: Re: [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH driver Cc: "Nick Sillik" , "David Brownell" , "Greg Kroah-Hartman" , dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net In-Reply-To: <20071028155212.GC7227@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071028155212.GC7227@stusta.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 38 On 10/28/07, Adrian Bunk wrote: > Nearly two years ago, USB_STORAGE_ONETOUCH got a dependency on !PM. > Considering that this also implies that the driver is not available > e.g. when ACPI is enabled in the kernel that's not far from a dependency > on BROKEN. > > This patch therefore removes this driver. Hmm... http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c9d00fc148b210aa8cf388d6e1eac187a0e855a6 -> Adds !PM because suspend was broken (17.11.2005) http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7931e1c6f8007d5fef8a0bb2dc71bd97315eeae9 -> Adds suspend support, but fails to remove the !PM (5.12.2005) So it looks like that !PM is false. I have the following device: Bus 001 Device 005: ID 1058:0400 Western Digital Technologies, Inc. Bus 001 Device 004: ID 1058:0600 Western Digital Technologies, Inc. Bus 001 Device 003: ID 1058:0500 Western Digital Technologies, Inc. aka Western Digital Media Center This firewire+usb hdd enclosure also has three buttons. But it looks like that uses another driver: hiddev0hidraw1: USB HID v1.10 Device [Western Digital External HDD] on usb-0000:00:02.1-5.2 Otherwise I would be willing to try to test this, if someone would tell me how to check that the second commit did fix the suspend problem. Torsten - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/