Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <479e4e09-899a-63a0-e606-40427bdd6cf8@collabora.com>
Date:   Wed, 26 Jul 2023 10:26:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 05/61] mmc: mtk-sd: Convert to platform remove callback
 returning void
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20230726040041.26267-1-frank.li@vivo.com>
 <20230726040041.26267-5-frank.li@vivo.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230726040041.26267-5-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Il 26/07/23 05:59, Yangtao Li ha scritto:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   drivers/mmc/host/mtk-sd.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 02403ff99e0d..9e2debd1edbe 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2887,7 +2887,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int msdc_drv_remove(struct platform_device *pdev)
> +static void msdc_drv_remove(struct platform_device *pdev)
>   {
>   	struct mmc_host *mmc;
>   	struct msdc_host *host;
> @@ -2911,8 +2911,6 @@ static int msdc_drv_remove(struct platform_device *pdev)
>   			host->dma.bd, host->dma.bd_addr);
>   
>   	mmc_free_host(mmc);
> -
> -	return 0;
>   }
>   
>   static void msdc_save_reg(struct msdc_host *host)
> @@ -3054,7 +3052,7 @@ static const struct dev_pm_ops msdc_dev_pm_ops = {
>   
>   static struct platform_driver mt_msdc_driver = {
>   	.probe = msdc_drv_probe,
> -	.remove = msdc_drv_remove,
> +	.remove_new = msdc_drv_remove,
>   	.driver = {
>   		.name = "mtk-msdc",
>   		.probe_type = PROBE_PREFER_ASYNCHRONOUS,