Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp738375rwb; Wed, 26 Jul 2023 01:55:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlG2opc325ua9TWA0ZekDXsTW/10DfVeQ99k+Jx4cQq788LpTWCYiCl2bofivJGKA7JFR69h X-Received: by 2002:a05:6808:1803:b0:3a4:1c0b:85d0 with SMTP id bh3-20020a056808180300b003a41c0b85d0mr2040332oib.55.1690361703580; Wed, 26 Jul 2023 01:55:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690361703; cv=none; d=google.com; s=arc-20160816; b=j9V8ODZsc4OmNdVjgnR8uxD/rTLeIAKIONM+XbTos4aJUfXdijVwiKqW6ucvrUofcz V94o4H+fKFghE7cU7nKJPwxhvUKg/b134qvqKG+WTPzqXtuqV4NaJexvPtUxlkLKUt2q 5VhQ6I9F0BFtaa7h6cQ5+7tLrMYz2471Tbr9vPCt4lF+ibZ0QCWvKdp1lCv2nHsgz+nH KOVvJMRaQCtnEIWQ8Fc5UKOqSDIohpnJwh8lICc9VYGnq/YG7c248PqvKSs+XtZQzs03 gSeBNOAttpYOoyXA5wLFka2rc2mRIbYKz8UKQcwXA5lH1/LxtdgBrHyQDXb71S4r6eg3 8/+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BNQhgI3bztXsDKLKL9Y51hRanaV6IoqzrzInBKdjpB4=; fh=OYRFC0kXd1esTfmWBNHV4ZIDeUr74jGDTZCltZPMuxQ=; b=vercVovGjecJA608PRB/gyK7Klx2O71vV2u7OTgS9TqagRuoD4CEIiBIwyTkdZMBh8 qEvP6EG/sB8BrzcJbhyVyPtMKm6ckHGqIJVcnaAgQNyzO4qER+X5lZ7rPPTsHmR7MRkT R3Kd6HvsZ18XRI/xebe4njdhawdzBy1UrFDdvPKkZChroXajsGZuwnNfJawTHCFKpUJB 2rFDamZcZ63ax0oKPEJn2+QeM7iGjw8wsFqPZKLlyNuQ0PuHllO5GEPTukJRQ2Veetk1 dK1UuLXb2wAy5JA7ZTsDpDQizZ01ycUm2gEYTcflBKPf/slxy0q7ZBuUMWnZPHmcW4hL wlmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fastly.com header.s=google header.b=EskMqoHc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fastly.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d198-20020a6336cf000000b00543a881db0fsi12136321pga.283.2023.07.26.01.54.50; Wed, 26 Jul 2023 01:55:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fastly.com header.s=google header.b=EskMqoHc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fastly.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233318AbjGZIjF (ORCPT + 99 others); Wed, 26 Jul 2023 04:39:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233324AbjGZIiY (ORCPT ); Wed, 26 Jul 2023 04:38:24 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 826E455B5 for ; Wed, 26 Jul 2023 01:28:19 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-52256241b76so1937757a12.1 for ; Wed, 26 Jul 2023 01:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1690360098; x=1690964898; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BNQhgI3bztXsDKLKL9Y51hRanaV6IoqzrzInBKdjpB4=; b=EskMqoHcrf+I1oDvZ7vE+vwdKapI2s4EtPHSd2O6GRmPDAQgEnsg4w2DuFGlJBZkYw ocIssKw1G5HEEK48lpLYg7iG3fHlvnxlherMdtpBvVhh5v4Ga8lpe+w5OLop13ui6ixn AwWFvow+tkZvLjq6RfGsOPqdzy24w//lZGjr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690360098; x=1690964898; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BNQhgI3bztXsDKLKL9Y51hRanaV6IoqzrzInBKdjpB4=; b=fB2ntxKJ1D75wewegRC9VOTeaI27vPDh+xcWbfYywq5WG74Pc9OV4oHbSI16emLXnn M9AplOxvp5oQCCbMdIqBQIbIF4+o7YQaWnZ2bAj9OLVdceiqhGdOg7xrpEqJTDx55qSR O+bySUpm2QlCWLK+Rx8xFgP2HFgm7EhEVjZj948r9DUw/8QnHhfO/h0SN0gzac+JMwq2 sI36esPcFGEBDMiXgg5OuuQ1b4AjxE0bGaHIaoGVzPwrRNgNyF2dnPD5vxctIZBtWVbo jMp9Wj/76aLyWdwhLi7HFVdMZY2HQdBAUW8OWf9gRQgGMrw3wFQGOgrwH16sMq0CF424 0bQw== X-Gm-Message-State: ABy/qLbvdL+/tzzn6CdJ7dSTj4kqi+RXMzofWPp7Ds5P3TH7HAUS5JzD 0j/qedF2c7IdBiESEhM5HKZVlhhoOlcJ3z2LY5dB49aDw3Ho9ZSUH4E= X-Received: by 2002:a05:6402:129a:b0:522:4d1b:3acf with SMTP id w26-20020a056402129a00b005224d1b3acfmr841200edv.37.1690360097943; Wed, 26 Jul 2023 01:28:17 -0700 (PDT) MIME-Version: 1.0 References: <20230723150658.241597-1-jdamato@fastly.com> <20230723150658.241597-3-jdamato@fastly.com> In-Reply-To: From: Joe Damato Date: Wed, 26 Jul 2023 11:28:06 +0300 Message-ID: Subject: Re: [net 2/2] net/mlx5: Fix flowhash key set/get for custom RSS To: Tariq Toukan Cc: netdev@vger.kernel.org, saeedm@nvidia.com, ecree@solarflare.com, andrew@lunn.ch, kuba@kernel.org, davem@davemloft.net, leon@kernel.org, pabeni@redhat.com, arnd@arndb.de, linux-kernel@vger.kernel.org, Tariq Toukan Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2023 at 12:59:32PM +0300, Tariq Toukan wrote: > > > On 23/07/2023 18:06, Joe Damato wrote: > >mlx5 flow hash field retrieval and set only worked on the default > >RSS context, not custom RSS contexts. > > > >For example, before this patch attempting to retrieve the flow hash fields > >for RSS context 1 fails: > > > > Hi, > > You are adding new driver functionality, please take it through net-next. Thanks for reviewing the code I sent; I made the changes you requested and sent a v2, but through net-next this time.