Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 10:07:32 +0200
From:   Igor Mammedov <imammedo@redhat.com>
To:     Woody Suwalski <terraluna977@gmail.com>
Cc:     linux-kernel@vger.kernel.org, bhelgaas@google.com,
        linux-pci@vger.kernel.org, mst@redhat.com
Subject: Re: [RFC 0/3] acpipcihp: fix kernel crash on 2nd resume
Message-ID: <20230726100732.1b9ae446@imammedo.users.ipa.redhat.com>
In-Reply-To: <46437825-3bd0-2f8a-12d8-98a2b54d7c22@gmail.com>
References: <20230725113938.2277420-1-imammedo@redhat.com>
        <88a06e12-600a-a4bd-f216-44753965ce48@gmail.com>
        <20230725171958.1eacd24e@imammedo.users.ipa.redhat.com>
        <46437825-3bd0-2f8a-12d8-98a2b54d7c22@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 25 Jul 2023 11:59:56 -0400
Woody Suwalski <terraluna977@gmail.com> wrote:

> Igor Mammedov wrote:
> > On Tue, 25 Jul 2023 09:51:53 -0400
> > Woody Suwalski <terraluna977@gmail.com> wrote:
> > =20
> >> Igor Mammedov wrote: =20
> >>> Changelog:
> >>>     * split out debug patch into a separate one with extra printk add=
ed
> >>>     * fixed inverte bus->self check (probably a reason why it didn't =
work before)
> >>>
> >>>
> >>> 1/3 debug patch
> >>> 2/3 offending patch
> >>> 3/3 potential fix
> >>>    =20
> >>> I added more files to trace, add following to kernel CLI
> >>>      dyndbg=3D"file drivers/pci/access.c +p; file drivers/pci/hotplug=
/acpiphp_glue.c +p; file drivers/pci/bus.c +p; file drivers/pci/pci.c +p; f=
ile drivers/pci/setup-bus.c +p; file drivers/acpi/bus.c +p" ignore_loglevel
> >>>
> >>> should be applied on top of
> >>>      e8afd0d9fccc PCI: pciehp: Cancel bringup sequence if card is not=
 present
> >>>
> >>> apply a patch one by one and run testcase + capture dmesg after each =
patch
> >>> one shpould endup with 3 dmesg to ananlyse
> >>>    1st - old behaviour - no crash
> >>>    2nd - crash
> >>>    3rd - no crash hopefully
> >>>
> >>> Igor Mammedov (3):
> >>>     acpiphp: extra debug hack
> >>>     PCI: acpiphp: Reassign resources on bridge if necessary
> >>>     acpipcihp: use __pci_bus_assign_resources() if bus doesn't have b=
ridge
> >>>
> >>>    drivers/pci/hotplug/acpiphp_glue.c | 23 ++++++++++++++++++-----
> >>>    1 file changed, 18 insertions(+), 5 deletions(-)
> >>>    =20
> >> Actually applying patch1 is already creating the crash (why???), =20
> > probably it's due to an extra debug line, I've added.
> > I dropped suspicions one, can you try again and see if it works.
> > =20
> >> hence I
> >> have added also dmesg-6.5-0.txt which shows a working condition based =
on
> >> git e8afd0d9fccc level (acpiphp_glue in kernel 6.4)
> >>
> >> Patch3 did not fix the issue, it seems that the culprit is somewhere
> >> else triggered by=C2=A0 "benign" patch1 :-(
> >>
> >> Also note about the trigger description in patch3: the dmesg trace on
> >> Inspiron laptop is collected after the first wake from suspend to ram.
> >> The consecutive=C2=A0 attempt to sleep results in a frozen system. =20
> > Thanks for clarification, I'll correct commit message once culprit
> > is found.
> > =20
> Good news. After removing the botched debug statement which was masking=20
> the original issue, the testing went as you have predicted, and on patch=
=20
> 3 system suspends to RAM OK.
Thanks for confirmation,
I'll post cleaned up 3/3 patch today.

>=20
> Here are the requested 3 dmesg outputs, #2 is for the bad run.
>=20
> I can retest with a final version of the patch once you have it ready...
>=20
> Thanks, Woody
>=20