Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 10:17:13 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Atin Bainada <hi@atinb.me>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is
 not found
Message-ID: <ZMDWic7Wo/bJBnjG@corigine.com>
References: <20230724033058.16795-1-ansuelsmth@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230724033058.16795-1-ansuelsmth@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9QFmQ99y3t98jG3vhxbRC9tjXZS/XkTxJX8aGJSOp7U/zegYpydJ62lkqdE5?=
 =?us-ascii?Q?AhsSNLfQTPvhqQ0spX17MAdz6hOVdfeJJia11eSVNsYllt81F0jLVnvc6R5J?=
 =?us-ascii?Q?q6SZgZeAyFZIcGPGK7M8IhpBTdkUN3FkIDgLW0yXg2mhsgbud5mMzdllixvi?=
 =?us-ascii?Q?Cf69rJqPQifgRDNIXuLHPu/sJmoocFTsJfd/Lr61iTgH3Wuvupd94TN3f3gL?=
 =?us-ascii?Q?MDV6b700B7ErlltjU1cXpv8M49rlKjqzdNy39m2znD3iMHzenB60iln0ntpH?=
 =?us-ascii?Q?pPIGJytgyXTVsPXxajpeam+TUkW1lZB++4hGEUq1jpK+M86V1ZvLHMW/IFoZ?=
 =?us-ascii?Q?vrx5jBgbf4YEarbGGy1qv6SxH78Qu+Fg5WxAiNenFvNakvtTvidfESMtuqBA?=
 =?us-ascii?Q?6n7Q5G/jr/yR6kxOXwkZoHfA9XpeDXsW3BgEN0zWIGr6FrDwuc1+h5K/Ljpa?=
 =?us-ascii?Q?ng/5rB1zIaimklWfpNdFIZSV1w1/Ez1LxEZgc4QC3/B9kYyC7Y7Z/kkedTAH?=
 =?us-ascii?Q?tRBF4LoMtjKMf8B5N3LBQlfLZp5gE+NOdEm2U3HBXxDjtpnsaszJ/XfRXsj4?=
 =?us-ascii?Q?cJZxtUMpEnW6OkmceuXzbCbgwdw4w2UYqkkQsXMJSbHxnaOV8DcYIR6ivyC+?=
 =?us-ascii?Q?WAWYX/QBI6Gh1/s0H2KpCRobsm1I4llNG7N3Amh2yELIdyUx+NsQMhOrbO+r?=
 =?us-ascii?Q?3qEMRqga7GBl/BssPbnHst2asItLx6hV1vq+cmdHBRdJ+GGH/IUHbonMiya+?=
 =?us-ascii?Q?41f4puHoA3+w/cXQfcnQqAyP28F2a2DyFIvaHrGX3a6ZBxZfimlyIzEAdPTy?=
 =?us-ascii?Q?hfEQU2zm9drXQkfHLw3Fw58JzQ8tNEVxfKtmmoLMN/Z7A3+AZH6uXQnmATSO?=
 =?us-ascii?Q?Ofu/drTR9BM3GFDTDWlVJuZp629Cb8X7pOS6fOOjJe680x2RN0dVRC2FfUIR?=
 =?us-ascii?Q?qQMa627rxUYNHwdahm3GDVmXL+Oe+j71mcxFRuvusFijVJd1VJpLWjClWKQx?=
 =?us-ascii?Q?FuHpLjfnNYqP8O+CognFpxaN0XOlszZ7bPpLwsxmfyDIcOn1Q/zPUTnFVtEK?=
 =?us-ascii?Q?vWBisxXtBSCOmemIfh/wBhwVuXtrds1W10Cq8R/IGKFY2sknppOcBkz6zZwZ?=
 =?us-ascii?Q?G/C1fRFMIPqqLddrzDKNYn2EFAUV16tKr0yZrlcoWL8yCiwTxk13Mxp1dl6r?=
 =?us-ascii?Q?RO4gaGd3HdPaIUttnEDCJnnjSkj17jiXBqNIB8vdHLrplufruTCLcNsUH4rp?=
 =?us-ascii?Q?pdfOfuMbgc2RiMBdZfU0ZzMe/Vn6Gxs1Kys0LjwnnIrC6yHZT/FpI+OGz7kn?=
 =?us-ascii?Q?kuxyS/xfukfhsaFBqTq+NuJiMrpmbjKoMBqvf9VTqj6WLIzjt8mjIHAKbU0x?=
 =?us-ascii?Q?CW1W7ZaAgoukhadLK51QrXBZRFnxJMrLNlSDs0CL5YksFdN5AZDLQ+Gf48qb?=
 =?us-ascii?Q?YW3HgNJUwobVEEMRgDMtMKtm4o2X9G1CiZDNeS80x9+AP5nCLBNYQ1SWg4zk?=
 =?us-ascii?Q?7GOeXtN7moe0cysXD0s0l5QXnfhBj3WnX3zn8b4DGMSLW4xMhpL9WH48ETWT?=
 =?us-ascii?Q?aETR3Hx0HIp5R5iSUIlXLfLB6jEeyfHLBphuNZYIAg0NVLQfqkFdNiPCP+fl?=
 =?us-ascii?Q?vxgPpzN7VCjMKT8NcHBxUsCjXJDRXQZoPkxUtaiTDFNx3aEIFQe68J/B87Rf?=
 =?us-ascii?Q?NEMyqw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a07d5ba4-9eb4-4321-9f62-08db8db0bbac
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 08:17:20.7105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q8pR1Ag2d+OAnVcpFwQL8Shog9uF+N+1PwPjLYSrH9NjfV40ITqBw0toRkQPhEdpsA5yF6sB4nEKQvsSLxieRT2OgNkzRwOjCn/1jT82meU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3630
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 24, 2023 at 05:30:56AM +0200, Christian Marangi wrote:
> Currently checksum is recalculated and dsa tag stripped even if we later
> don't find the dev.
> 
> To improve code, exit early if we don't find the dev and skip additional
> operation on the skb since it will be freed anyway.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>