Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a11f0ec8-7eaa-aa3e-8b86-555e5dbe6e3e@suse.com>
Date:   Wed, 26 Jul 2023 10:13:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v9 2/5] phy: realtek: usb: Add driver for the Realtek SoC
 USB 2.0 PHY
To:     Stanley Chang <stanley_chang@realtek.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Flavio Suligoi <f.suligoi@asem.it>,
        Roy Luo <royluo@google.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Ray Chi <raychi@google.com>, linux-phy@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
References: <20230725033318.8361-1-stanley_chang@realtek.com>
 <20230725033318.8361-2-stanley_chang@realtek.com>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230725033318.8361-2-stanley_chang@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmxiOHFucWVjWVZjZGVIc3kvOFhKL0N3S1g4N3ErdktMN0tuOHJGVXNDL3Jz?=
 =?utf-8?B?Q0M2VHVOTXpDTlFrbWtUQWlUQU1WZ1pQQjk1WDRBZWMwRlAvZ2RBcll2UEhG?=
 =?utf-8?B?K3VISWhwSjJvSklVaU1uaXVFR2RmNWZWWkhuSW9vQURLNGxvMzRCR3Q1SGVD?=
 =?utf-8?B?czlmdm9UZURIWlIzYTdZbFJVZTZteEpQaFd0T3pUcEJjNUhnOEpGMmd5Z2U2?=
 =?utf-8?B?M2JmNjBhL200SlpDTHlNOUVBcDd5NWpoN0pIOHRCNkFyK21VTzlxVVpsb1lR?=
 =?utf-8?B?cnpzVDRzUnpmS2ZxbTR0bFJGbFo3eUg5UnBZSDcvcStSamhpUTNkNTl5YjNv?=
 =?utf-8?B?V1FBZWY4VEsvUU9zeVk5Yld4cTkxTDRRNDZkQlN2WmUxS3Z0S2pkMzFPK1RJ?=
 =?utf-8?B?cXlsWElrdkRuTFEwS0RDTmVqdDdycHVucjBaSmxHK09LZis4cmhVTm5BMlc3?=
 =?utf-8?B?MjM3d1h2RDBCOEMvdjVBSGpRWlRHNGRGSG9yM092ajlFK2RlbWlYbEpwSXcr?=
 =?utf-8?B?NDVFc0FydWMrT0VVMzI3V1BJelltRmJCY3poSWthODdHa2ptRWczckZFTWVw?=
 =?utf-8?B?bS9IVlAyT0dDTnFHNFEvQU5NUHgwMzd5bHVDYWhzalJDUiszT1V2VWpzZE5L?=
 =?utf-8?B?WVRmdDYrZmVDYTM1MHhSV1M5bzN4Z2NIWWNXeUV1NW5GUjlzWEl1V3BDVjBz?=
 =?utf-8?B?MURtZFhYRUZ1K01UVi9sazhyaGRCdVhBUDNiYWpWcFA2NkRMV2hmWTNyc1NR?=
 =?utf-8?B?NlNBM3JuVGcvTWNId1NZL2cyVE9kNnYyMUFoTlI2UTcvaFpURFZpT25JNGVC?=
 =?utf-8?B?dkhVcnN5OVNXSEduRzRTWXh4Zy9NS0VqYUFIdDNoS1E5M2RYbVdYTWVvMEN5?=
 =?utf-8?B?aUJRMjM2UjZsaGN5NHlFdmlkK0NuNnRwdE04RmdiSkgxbndIMVlGR011TFFn?=
 =?utf-8?B?TkRWc3pVS2VBR3Y4bFNuR2lERll5MkwvS05RU3VHNmd0cFBIZnhwUlM1RVRn?=
 =?utf-8?B?SXBNMWFZaTFyODdUNXk4OUFSNFd3ZmxhU0hkWm9ZdlJua080d05IZWNDMk5G?=
 =?utf-8?B?aEJLaThFcG10YUNkSzFkK1I1Z3gzb3hCOEl4akI4K3loRXJRMEkvRXpSZWNM?=
 =?utf-8?B?MkNLYzBycGZ0WElWQjJySmxsUkRQd3lQeGpDRWFpNHZJWHBIQTFIdzgrWW5P?=
 =?utf-8?B?bGVSWEEwbzRWTXVKYWRlNUl4ZDFRMUhMQ3YwSC9EWHIvMTd0U3hZRkJJT3ZB?=
 =?utf-8?B?Wm8xSjZuMUZsdzZ3dlZSdnZJOU9kczJYZkFRWitubGwzOVlycGs1cHZGaWQx?=
 =?utf-8?B?REFma1BuNDZCS2tQSjlrOGU1b1IwNnIzZ2FNRURMSk56RTljNWtmS0JvVjM2?=
 =?utf-8?B?dzJLOWtJOTRTTDc1M0hlWTNSWDVxQy9nUVVNNlg4WE1aaWZtaFBYcVRGSTNo?=
 =?utf-8?B?SkpTMHIyYStsOWVJSngyTkgvdmZBNHMyUGRsZEh6SEJIVG1hVmpTaFlLWmI4?=
 =?utf-8?B?RHBsSU5GNUJJayszQTlJdVJjbUl6SWVTLzkyWWFaUDhHemdKblJ2S3MyK04r?=
 =?utf-8?B?L0ZDd3BKS01OS1RkZWMrcCt0b1ZrYTUxS1ZSclpFUElBNWZEckRFWGlQQUEy?=
 =?utf-8?B?a3VSbyt1TEdWQ3NoQ1k4VTNSOWlQQm5uaDNSUkY1N2lSZlpFZ0ZyY3gvVlBi?=
 =?utf-8?B?cWdWb0RPbCtGbGVZcWE2R0xBREJLclByOVhwcXV2RXNIcGc2RWo3ZUJ6QkJQ?=
 =?utf-8?B?QUtnaWlLT0lRdUtEUVZNTk9wRW9Mc0traUF5blB6Wkc4d3M2VlltdlpEMmdW?=
 =?utf-8?B?VFhWN1J1R25idEFWVldaYThSbzRRTHJLa0JSOFhxQXlsdTJ5YmljUmkrYTVU?=
 =?utf-8?B?WHJ0SWhCNlU1Z2hNY0FWbVFINVlramZseEU3SlpsL0xGMjY5c2lVYncvbjJN?=
 =?utf-8?B?RzV2Z2NtWUprSVMyMFoxeXVrYXFDaGZoUkg4c2lqaW5DNDJ4a0Z5M0NVdWpw?=
 =?utf-8?B?OSs3OURBUFlhZXRZSHJUS0hPVVRQNHA5YXBTWWFFUUtDaWt5LzBNVTkyNmdV?=
 =?utf-8?B?V1BhcTBuQXZ6eU1la0ZFcHMzS0l2TlBUY2NXTThhS2U1ZHVXU0xOZ0dNSExl?=
 =?utf-8?B?S042cFdBU1VaaFZTVStRM2s3cU1oRUhLUGdCVnVONEl4NE4vNHBiMysyL0Z1?=
 =?utf-8?Q?7VMDhDEW1QN4T3Y5hysj6nc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 566a16c2-8558-4519-04f0-08db8db041c2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 08:13:56.2397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nKG3vH1llCuTwD43/9rYPK2RIjPRlIn9Zw3kmWe7MusPHkZfmC6cmyuxKowyVBs0IcUeE9/JLiVGO1SLesXDvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6777
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

On 25.07.23 05:31, Stanley Chang wrote:
> +static int get_phy_data_by_efuse(struct rtk_phy *rtk_phy,
> +				 struct phy_parameter *phy_parameter, int index)
> +{
> +	struct phy_cfg *phy_cfg = rtk_phy->phy_cfg;
> +	u8 value = 0;
> +	struct nvmem_cell *cell;
> +	struct soc_device_attribute rtk_soc_groot[] = {
> +		    { .family = "Realtek Groot",},
> +		    { /* empty */ } };
> +
> +	if (!phy_cfg->check_efuse)
> +		goto out;
> +
> +	/* Read efuse for usb dc cal */
> +	cell = nvmem_cell_get(rtk_phy->dev, "usb-dc-cal");
> +	if (IS_ERR(cell)) {
> +		dev_dbg(rtk_phy->dev, "%s no usb-dc-cal: %ld\n",
> +			__func__, PTR_ERR(cell));
> +	} else {
> +		unsigned char *buf;
> +		size_t buf_size;
> +
> +		buf = nvmem_cell_read(cell, &buf_size);
> +		value = buf[0] & phy_cfg->dc_driving_mask;
> +
> +		kfree(buf);
> +		nvmem_cell_put(cell);

nvmem_cell_read() can take NULL as the second argument.
You are throwing away buf_size anyway.

	Regards
		Oliver