Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Wed, 26 Jul 2023 11:42:25 +0300
To:     =?iso-8859-1?Q?Rodr=EDguez_Barbarin=2C_Jos=E9?= Javier 
        <JoseJavier.Rodriguez@duagon.com>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "morbidrsa@gmail.com" <morbidrsa@gmail.com>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jth@kernel.org" <jth@kernel.org>,
        =?iso-8859-1?B?U2FuanXhbiBHYXJj7WEs?= Jorge 
        <Jorge.SanjuanGarcia@duagon.com>
Subject: Re: [PATCH 0/3] 8250_men_mcb: Make UART port autoconfigurable
Message-ID: <ZMDccXK4N4ZEwsPn@surfacebook>
References: <20230705131423.30552-1-josejavier.rodriguez@duagon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230705131423.30552-1-josejavier.rodriguez@duagon.com>
Precedence: bulk

Wed, Jul 05, 2023 at 01:14:51PM +0000, Rodr?guez Barbarin, Jos? Javier kirjoitti:
> Make configuration be handled by the 8250 UART subsystem

Actually this is not the best idea. 

> to avoid weird behaviours 

The opposite.

8250 detection is full of quirks and was developed to handle tons of different
UARTs when the driver was in a single file. Since you have a separate 8250_*.c
module for your UART and you _know_ the type beforehand, why on earth you need
to rely on the old and maybe not very suitable code? Have you thought about
corner cases with IRQ detection, for example?

> and for better maintainability.

The opposite.

I don't know if it affects your hardware to the date, but it may be different
for the future models, or models that you hadn't tested.

That said, I highly recommend to reconsider.

-- 
With Best Regards,
Andy Shevchenko