Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp762565rwb; Wed, 26 Jul 2023 02:24:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlGDOmCoJGhKctyIAgJM6QZ0C1DD8N19epErhzoJbnlLN+LWX0Mmbeg0Y+ZBPxRu6WpgfIQn X-Received: by 2002:a17:907:7806:b0:993:d536:3caf with SMTP id la6-20020a170907780600b00993d5363cafmr1261137ejc.4.1690363444058; Wed, 26 Jul 2023 02:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690363444; cv=none; d=google.com; s=arc-20160816; b=JIYVmXwYd3+FJOOqvuVwXrw06C72GO4jbK9nHL6YgIF8EPiWX65p/0yVKv1tin+6pY gSTfOKVsRKrjYFJUzm2LY6MGr19SCg/voMPqccOLbrpBpIqYBGWzZjanaKwGRWPI4Kbb Kc5gvj3a4106uT01aULa6F1wmbb9G4+LpHeO04kMCgVQaD1/0+iXqM6tk6RUWTQGCwRp 2KVQE33rpLh2Lknl0VvNecjQonGTCu6AFHtMUSUzcJ9I7ORJQ1vpjbkEaFXlGeIH89tb HFuFvznXTfZmiRcKt8qOZ/F0VJlYsyfXP5PkD3+1UzgbamHFHeDRyNRz1qygkpKGlhXC VZ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Qg0NCf5dnZz8OLk3qXrLeo5swLGusJY3RIjriGEawwg=; fh=Tg66vRFRAY1b6Au3bhKuhGCi/RzmMcfK0faRev1TJiI=; b=X+NZN0TwOKPx8SQymAAQz1KDBWVP1uy0CouspDIdcQLTfKVGfCrvE4rtZ3sJ0FGUXs t8GVkicrolBwASgLeRDhjB7Bsairboi0WA5qAsl1AKW0Pr/5u4y9hOqtj4zjE2ieH1hJ AoZrZq2jXyMaOWGJyPUlgzFd+1l+jAMljurPzTLyQ8pkAlHLvYtlF+CaOB8fiq+X/q6T 1b7pFlRDDQQckLfnLqdZwDAC9OsbpH/HTPm3JIiKPmytf8mk3ZWM2WAtScG17rQWQSlQ t6Z2AJmiTb3xpleAnVpeVouIHw/Pk9fGSVE2P7hInDlWEqymQ6reV3s6VI/km9Lt1GJv 9kVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n27-20020a170906689b00b009930d9d6b4csi9060375ejr.888.2023.07.26.02.23.39; Wed, 26 Jul 2023 02:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233558AbjGZJKZ (ORCPT + 99 others); Wed, 26 Jul 2023 05:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232820AbjGZJJf (ORCPT ); Wed, 26 Jul 2023 05:09:35 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A956B171E for ; Wed, 26 Jul 2023 02:06:08 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R9nwb6m79z4wfD; Wed, 26 Jul 2023 17:02:39 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 17:06:02 +0800 From: Ruan Jinjie To: , , CC: Subject: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err() Date: Wed, 26 Jul 2023 17:06:44 +0000 Message-ID: <20230726170644.2474917-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to call the dev_err() function directly to print a custom message when handling an error from the platform_get_irq() functions as it going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie --- drivers/misc/hi6421v600-irq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c index caa3de37698b..e5ed94e98a3c 100644 --- a/drivers/misc/hi6421v600-irq.c +++ b/drivers/misc/hi6421v600-irq.c @@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev) priv->irq = platform_get_irq(pmic_pdev, 0); if (priv->irq < 0) { - dev_err(dev, "Error %d when getting IRQs\n", priv->irq); return priv->irq; } -- 2.34.1