Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   carlos.song@nxp.com
To:     andi.shyti@kernel.org, aisheng.dong@nxp.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com
Cc:     carlos.song@nxp.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work
Date:   Wed, 26 Jul 2023 17:22:38 +0800
Message-Id: <20230726092238.3424116-1-carlos.song@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h1Zgi21/aa/b81uq/XwdakQjL52psZnSYo+rRBRGQYik88zV6ER0HJJjbiSF?=
 =?us-ascii?Q?9XhTaGLz7XMjuZ7ufMbkO0SqgQwUQ+1yHpJqTopTQ3zwYeaewlWfi0/qbL7X?=
 =?us-ascii?Q?HX03RO66SWflZVwIvF5ralaEv2//0ICsN87vVq5fjT8ijTERhsrUrjN4JqUK?=
 =?us-ascii?Q?rQxwrA+TGbP9TKZdFbTznXnml0iVoAlnjIGZ+mPlaK3PJj5q/44xLRgmew+t?=
 =?us-ascii?Q?PuflvTisyICclg1nFYgf5vDP8ztiE6n7n8eChshFQlrinEwfxFHF7FpjTIDn?=
 =?us-ascii?Q?CALT+C7HlrxQNjvXuZ/sKH9yx7ygr/ykNbo60Nt67+8HnM9hjdu7Ig/KWKqr?=
 =?us-ascii?Q?S5AP1Toc1Zy6RYjy/ubzut+30TFi5A1llSS63MNvbKGY5vdRl/q6rh8Dl4bB?=
 =?us-ascii?Q?X67oiJl0ps+/h8qTBdHwMaCfkAw0bZvzQbrQlf/+qdRHIqbGfuwQzK6uGrub?=
 =?us-ascii?Q?H9KsZdo2UG9RgmGG07FV0ZRG+4/2IIljMXiUhMWPPAvoe4xwYEuolPjEM9EP?=
 =?us-ascii?Q?GsVp+sP6r5aFLpR4uJOFc8FRgdDwywAtwcp9QuKk9QKNbDZHdSKiLIoLEYsL?=
 =?us-ascii?Q?Rrv54wWnGDswF1c3hkynty9r/vnWq7xGOC1bm+WAX2M31eVE6RXVBd9Vdr1a?=
 =?us-ascii?Q?oMXRSO6sziyqdh8jep0EeezEBwrSFJTVXhxdFXduU7PhkAJhwR4yJ2bvGVMp?=
 =?us-ascii?Q?j9/0pP7kzyatddjaVYeryweU5+bHDz2ajKaJy/4eT3aq7ry9Hl7yu73Mi0h6?=
 =?us-ascii?Q?gfdRLsVLvWZLkZi32DBro0Mi2jtaB3NlOSt0ALBu96tMRVuDqqx5bMSF8D+h?=
 =?us-ascii?Q?40bz7DGeLI9z7mu8AMowTqtVTZ0KxFl6glYfgjeCPuf2HCZgs6ukSujSEzlx?=
 =?us-ascii?Q?pIzZwb7+QhaBpr6iiQiXNnSHCg+VpKnx19rtT2usav5szVv33wBw1FI5RNBG?=
 =?us-ascii?Q?TH95CKpLY9qG/0I/IO5jbW/+Xw18vNQFFy10VquNu+xYSkWn1IK0FmQSsGu4?=
 =?us-ascii?Q?7ScRQlz+DuTHBzL6iSSLT4IRpsd7y613OqG7wCxy45bexjIR3k420JZsv6dc?=
 =?us-ascii?Q?F2/XyTi9kmJG7SW9naSaCLgz8SfFJpfwcNM6E9q69sMnOYU3DIKI9dDDfTpM?=
 =?us-ascii?Q?PcmQjXubSJ+RvKChuBQFgFvN2zjzUmgHLAHZ4l92j9/rARaa0Y62v7xPA1Pp?=
 =?us-ascii?Q?LgwtrmeTeFPuwzvrqE3vE5kM7f9S1eD/KYwLMxx6IVgh6VdWaMuynD5b2+w/?=
 =?us-ascii?Q?MHYGDiLP2443Z02Lf0jESbTn6jjQ3g20Pc4HvT7LTt0S+w7xnXtS+ZGLs/rb?=
 =?us-ascii?Q?/4OvpA1cbb68I2mai4apFluQnL9aBWPtnn1tfojlDK9zB+OCALKA4O2RFmkV?=
 =?us-ascii?Q?QLvAELWpF0M5eFfrX/DBG+bsR0I8a0jstY64YQTLFJwrnJBEfBhOwG632cdE?=
 =?us-ascii?Q?EomkE+IbuFSci/LNlmvgDqeJpZh8um/E2Q3e3St2lRndGZw0cOjmsUwO8csK?=
 =?us-ascii?Q?NlzkKhwC2OQ8oeh4jGcxhZfCp8wvaANO/S5+IkmVGfYCWNtImSbPOySeQBo0?=
 =?us-ascii?Q?Vtww6+WBXirfo5XTlgtHqO+XXIao5puQ9FQnZNGR?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70f86480-6b0a-4a9d-d2cf-08db8db951e9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 09:18:48.9092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zIepc2tCAQlWXGrYbMSGqSe/a5AIfCO3U7itQgXIooDRWyLzxEIcomhlXYJvi7d20b2j6w+ZeQdQN8Rr1+GoAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8953
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Carlos Song <carlos.song@nxp.com>

On MX8X platforms, the default clock rate is 0 if without explicit
clock setting in dts nodes. I2c can't work when i2c peripheral clk
rate is 0.

Add a i2c peripheral clk rate check before configuring the clock
register. When i2c peripheral clk rate is 0 and directly return
-EINVAL.

Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
Changes for V5:
- modify commit log
- modify Signed-off-by list
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c3287c887c6f..150d923ca7f1 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -209,6 +209,9 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
 	lpi2c_imx_set_mode(lpi2c_imx);
 
 	clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
+	if (!clk_rate)
+		return -EINVAL;
+
 	if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
 		filt = 0;
 	else
-- 
2.34.1