Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 16:47:35 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Yang Weijiang <weijiang.yang@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>,
        <binbin.wu@linux.intel.com>
Subject: Re: [PATCH v4 15/20] KVM:VMX: Save host MSR_IA32_S_CET to VMCS field
Message-ID: <ZMDdp1A7DOsRNeTd@chao-email>
References: <20230721030352.72414-1-weijiang.yang@intel.com>
 <20230721030352.72414-16-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230721030352.72414-16-weijiang.yang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3SV97OTDaIL8RR2+8LQpRsDJTuV6U20hEkzkD8m0D5RqcdOmesdkvUWC16H3?=
 =?us-ascii?Q?QEFX0Q/n/CFEQ+USS5sZNjP+5dOyJ+Yc9XBciPG2OlFlIkxZI/SSMOlXKM4O?=
 =?us-ascii?Q?ehNtj6JPjmV+YnwhSRTqcJUtYOP+PCwTDx13eZ0Wl+vbSpn6H1rqcn8owBLl?=
 =?us-ascii?Q?CogZOmmFsMVmW5OUw21q3rJpABnMlvH4Bk0tfxVJk6i+K7OLUpcbf4B2JhY3?=
 =?us-ascii?Q?vA9QDeE69U/v+cuPKCpSGIuQT+uLwSFmAYbn8O6/L5vJq4bBwXrc2i8MAtQV?=
 =?us-ascii?Q?ePLXWOnzs5cvJMUwDUyOxmQ4O0cZebY/aXbtve8LRap7A7/7I1DdREvmne2m?=
 =?us-ascii?Q?XHbCDPl4msTYsPV8Uz0VoaTS31vrzAsgEbk7QdtjuVGASPXBbngYJADr1e3e?=
 =?us-ascii?Q?U+whlDWaGhbCx8URZZzYhMSDn9pPq+OUuRKePx2+0hrbDuouSWlX1sLHt04A?=
 =?us-ascii?Q?Xt5QUlBoYzTUpImL9vluERdLh480sBVaQba811F2CrHT7Bl30o8lia6+9frt?=
 =?us-ascii?Q?MaiF4OtQPOXAhnBNL+iWoKbVsFgBJ3ajDZg6k2mNFiBEzYFDb155hlCzyBjZ?=
 =?us-ascii?Q?e/wIHl0QKUs0UtjMDyk2gwHtp7Hs71K+lHelbuqQPo4yJpXSO+0UjOnz5k2F?=
 =?us-ascii?Q?G8HjJKYp8/QdwyUACNyTns9YmYMBwcY/qoXY8C0nIaXG/WfANnxgtcupDE/4?=
 =?us-ascii?Q?64/Gg7eeF06q+2eEDNTNMluUGH9+d90/O8rAcR3ulCpy3YmVy8nC7xAxne24?=
 =?us-ascii?Q?ob/7Bx0BWdvz+QdpEJzOzzFVCMZCsCBCrEYthDuIuWLDDSyJmNkRvyb/hvH1?=
 =?us-ascii?Q?WoL6wIYlW6aw4FkU4dFA9pOFIYem9QBXJ3I2Lj8dB6Ey++QYfH/Gh+mLFjbo?=
 =?us-ascii?Q?12U0bs2/qHr2vm0X61OvsPDyESSU8wJ3tiW855KYgg7KQFLxjMjebZmnzorL?=
 =?us-ascii?Q?19znqCK52LoJXsmp0U4rxQeGRCURov5W5VyovQ3BZWPctpQOQ9QbE4186+2g?=
 =?us-ascii?Q?U8E5QLc72ohMNhGmACwlbjGXMcZi8DHBm1Nkq9qSO7uJLGt1UDSXZGJTRK0O?=
 =?us-ascii?Q?tcznvvPzC+QH51iegZNHva8SZS3SJGThEouT0DFNwSWMwznvRaRF9x0YMsS2?=
 =?us-ascii?Q?mE+3PoQz/BfagHElscO6dyzpfb6NXbKHN/hq6EN0CVOBP5eev+QkILHM+3dT?=
 =?us-ascii?Q?Ij8mqyuEL1tQxQgW6W8R1WBZf0eFUKNm5jTDrODSKxIWzhwuGfd9t9cRog4m?=
 =?us-ascii?Q?v5dH371l18fYV6a2yJ+PYI4wNQO9AorCk1/CfGI6mqSUbFyYWbuP7tl6ErTP?=
 =?us-ascii?Q?LvHm/kbtjPbAPpR692fCtWVCvtoBrTEJjYcERWRyHy2hhAGteTyBb/FdE8ML?=
 =?us-ascii?Q?5adV0lcsHfxxok963IcGwOeNCZgbcyz/m/wLQguxncygI7EjFmt8foXpIu3T?=
 =?us-ascii?Q?JgVZHRUFUzavLoKN+eJHx3UQW8pxD8GF6NbNB7oUnE5RQezjwLQNOdBwOsbj?=
 =?us-ascii?Q?SMVUhyV5A8gvTkfw9JvA13oxc8C+H5L2Jv02ev+t9aq5nWcV6pghEZlZBw/L?=
 =?us-ascii?Q?rhBDyAHkDjlxGkEsu2lfvDIMmwGQxWdSWDi6trkP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d61083c9-8881-4988-a5ab-08db8db4fbf0
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 08:47:46.4692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VQD8cOFYRdkUHaTV+QipV/NOUceuDrYne3myIMxyVNr17QoDQK6W4tSJOXKDbgVXilx5dwjl1ayGHCQWt/PEeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5774
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 20, 2023 at 11:03:47PM -0400, Yang Weijiang wrote:
>Save host MSR_IA32_S_CET to VMCS field as host constant state.
>Kernel IBT is supported now and the setting in MSR_IA32_S_CET
>is static after post-boot except in BIOS call case, but vCPU
>won't execute such BIOS call path currently, so it's safe to
>make the MSR as host constant.
>
>Suggested-by: Sean Christopherson <seanjc@google.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>---
> arch/x86/kvm/vmx/capabilities.h | 4 ++++
> arch/x86/kvm/vmx/vmx.c          | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
>diff --git a/arch/x86/kvm/vmx/capabilities.h b/arch/x86/kvm/vmx/capabilities.h
>index d0abee35d7ba..b1883f6c08eb 100644
>--- a/arch/x86/kvm/vmx/capabilities.h
>+++ b/arch/x86/kvm/vmx/capabilities.h
>@@ -106,6 +106,10 @@ static inline bool cpu_has_load_perf_global_ctrl(void)
> 	return vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL;
> }
> 
>+static inline bool cpu_has_load_cet_ctrl(void)
>+{
>+	return (vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_CET_STATE);

VM_ENTRY_LOAD_CET_STATE is to load guest state. Strictly speaking, you
should check VM_EXIT_LOAD_HOST_CET_STATE though I believe CPUs will
support both or none.

>+}
> static inline bool cpu_has_vmx_mpx(void)
> {
> 	return vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_BNDCFGS;
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index 85cb7e748a89..cba24acf1a7a 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -109,6 +109,8 @@ module_param(enable_apicv, bool, S_IRUGO);
> bool __read_mostly enable_ipiv = true;
> module_param(enable_ipiv, bool, 0444);
> 
>+static u64 __read_mostly host_s_cet;

caching host's value is to save an MSR read on vCPU creation?

Otherwise I don't see why a local variable cannot work.

>+
> /*
>  * If nested=1, nested virtualization is supported, i.e., guests may use
>  * VMX and be a hypervisor for its own guests. If nested=0, guests may not
>@@ -4355,6 +4357,9 @@ void vmx_set_constant_host_state(struct vcpu_vmx *vmx)
> 
> 	if (cpu_has_load_ia32_efer())
> 		vmcs_write64(HOST_IA32_EFER, host_efer);
>+
>+	if (cpu_has_load_cet_ctrl())
>+		vmcs_writel(HOST_S_CET, host_s_cet);
> }
> 
> void set_cr4_guest_host_mask(struct vcpu_vmx *vmx)
>@@ -8633,6 +8638,9 @@ static __init int hardware_setup(void)
> 			return r;
> 	}
> 
>+	if (cpu_has_load_cet_ctrl())
>+		rdmsrl_safe(MSR_IA32_S_CET, &host_s_cet);
>+
> 	vmx_set_cpu_caps();
> 
> 	r = alloc_kvm_area();
>-- 
>2.27.0
>