Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp805263rwb; Wed, 26 Jul 2023 03:13:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlG6c1QqwAi3Ln+bt1RpWLI5R/awsXwaZnh9dDJW5Vlc21h2plbPhAmL38goq76CCzkWpUgw X-Received: by 2002:a17:90a:928c:b0:262:e589:678f with SMTP id n12-20020a17090a928c00b00262e589678fmr2177464pjo.10.1690366407095; Wed, 26 Jul 2023 03:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690366407; cv=none; d=google.com; s=arc-20160816; b=qcbXL3OBxx24+M/MxtVRq9AVnhP8UuIVUoYaNIKV2LIMsrM/oxGC+Od487K8CJFpOl 6LJPZh4Mmispeq7ZCcHs17oVnGHzxy1dp6g1ZbB5Bke0MtKMPgcL4l24r+ipaobm3Twu OO40clX3NjpBhGXjHc9LHnoAU7pDFB+zYM71lZ5aiVA9Ya0JC5S5QFe+dkEPq1yr4KlQ zArLyySy+WU1/8lAw+phrkOBEJ2WF7xKXne+BxcRdqgmLo0ZMu1OC1LCjOq7ECuSJVei tMjwmmQfXuvV3ig+no4zzzE6yyeoARo0t8unyhdRZbfWg+VZfrYKFwbFON+xqFuqgoXq WXtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EWUaQxeKGJ4qJalm52aP93ztFzOZTVzpHXehk2zbXTY=; fh=HDIGOz5pJzGLaQ85fJLaMpHwV29mnmUwzXrLcWa4w8U=; b=fmWvbjiBRetH3NHgDOyY+J90quu1y/DFnm6gApTFi9cl9br9MNFYkaTArMuqYbtgBS 5c+WQ/NN9n9z0FgrgLcnMCS9i0XX3CBJ33msyp4qece/P6GhXmOyAZ8qAt66AMZsNfjj V1XYcteuSFbTQNSLbpTj00gRgTGiyWFLsh3u9qKhZebaU4F2kh0ePaCyk07Xt0lPYhvo sVi07fDkKeU/kny5fNbLRtDrixDbtfOGKXoH0PFz/JwT+0aGW9sGkFd1EhxdkHgIBY8e RF93K72BJ4mGE4C3Z0M7UhzfZUe0C+Dg8pIH6zwMeuj6vUXcjZwnD1P3PNWmNV4vqyJG TO4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=DhOnjCq1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lb8-20020a17090b4a4800b00263cdc45e92si916323pjb.28.2023.07.26.03.13.14; Wed, 26 Jul 2023 03:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=DhOnjCq1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233345AbjGZIrW (ORCPT + 99 others); Wed, 26 Jul 2023 04:47:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233408AbjGZIqr (ORCPT ); Wed, 26 Jul 2023 04:46:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14CC4EFC; Wed, 26 Jul 2023 01:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=EWUaQxeKGJ4qJalm52aP93ztFzOZTVzpHXehk2zbXTY=; b=DhOnjCq1ioxxsp65AMIiLHniTW 8m4u3Cq6Wa5ONKj85O7PiifX7Y+fCJIr+f/ZQcU8g1vR2VfjSyU45GbVxBOu+bDmYohMPh/yDWavW C0Oqng3Ws+tcykRjQO/uh5qiXviftFfrfJjdPzBUaZOjYHuup5AFxZr0YuiimBPGw+kI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qOa37-002L6O-Ck; Wed, 26 Jul 2023 10:39:13 +0200 Date: Wed, 26 Jul 2023 10:39:13 +0200 From: Andrew Lunn To: Hayes Wang Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net-next v2 2/2] r8152: set bp in bulk Message-ID: <0c42418b-7271-415d-991a-a4564cb3fad5@lunn.ch> References: <20230726030808.9093-417-nic_swsd@realtek.com> <20230726030808.9093-419-nic_swsd@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726030808.9093-419-nic_swsd@realtek.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - ocp_write_word(tp, type, PLA_BP_0, 0); > - ocp_write_word(tp, type, PLA_BP_1, 0); > - ocp_write_word(tp, type, PLA_BP_2, 0); > - ocp_write_word(tp, type, PLA_BP_3, 0); > - ocp_write_word(tp, type, PLA_BP_4, 0); > - ocp_write_word(tp, type, PLA_BP_5, 0); > - ocp_write_word(tp, type, PLA_BP_6, 0); > - ocp_write_word(tp, type, PLA_BP_7, 0); > + generic_ocp_write(tp, PLA_BP_0, BYTE_EN_DWORD, bp_num << 1, bp, type); > > /* wait 3 ms to make sure the firmware is stopped */ > usleep_range(3000, 6000); How much time do you save compared to this 3ms - 6ms sleep? Andrew