Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4fb1c846-2439-84b4-3423-223103878413@kernel.org>
Date:   Wed, 26 Jul 2023 11:58:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] tty: vt: Fix spelling typo in comment
Content-Language: en-US
To:     oushixiong <oushixiong@kylinos.cn>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-kernel@vger.kernel.org
References: <20230726091044.705393-1-oushixiong@kylinos.cn>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20230726091044.705393-1-oushixiong@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26. 07. 23, 11:10, oushixiong wrote:
> Signed-off-by: oushixiong <oushixiong@kylinos.cn>
> ---
>   drivers/tty/vt/vt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 1e8e57b45688..bcdd249e47a0 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -3473,7 +3473,7 @@ static int __init con_init(void)
>   		INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
>   		tty_port_init(&vc->port);
>   		visual_init(vc, currcons, 1);
> -		/* Assuming vc->vc_{cols,rows,screenbuf_size} are sane here. */
> +		/* Assuming vc->vc_{cols,rows,screenbuf_size} are same here. */

NACK for many reasons, incl. this is _wrong_.

Please read SubmittingPatches first.

-- 
js