Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4b7e173-6e77-b658-be42-eea64e7f2ed9@amd.com>
Date:   Wed, 26 Jul 2023 14:50:16 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Reply-To: nikunj@amd.com
Subject: Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static
Content-Language: en-US
To:     Li Zetao <lizetao1@huawei.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de
Cc:     x86@kernel.org, hpa@zytor.com, thomas.lendacky@amd.com,
        rppt@kernel.org, kirill.shutemov@linux.intel.com,
        michael.roth@amd.com, linux-kernel@vger.kernel.org
References: <20230726170659.2474934-1-lizetao1@huawei.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20230726170659.2474934-1-lizetao1@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enc4NXNyZXNuZUhFakVYMERBQzZsejAwUVlqMTUvdVR3eU5UQko5Vk01bGkv?=
 =?utf-8?B?RWJVSzJTc0ZNUjQ4cGp6STBMVVpWS2FDMXUrREtZb3ZpNEZtMG1GRjNFS3Jq?=
 =?utf-8?B?eitFYnM4M3NUSWgwcDJtVHRkeWJZQmZVcXJBN3VOeVd2M3UzUzZYNkNCSUxI?=
 =?utf-8?B?WTlEWjdGemdzc1FyV2pab2dWYWVVODcyZEFCdVo5eTdrZVdxdVRacFpkNnhU?=
 =?utf-8?B?bkd1eloydVpyalk1TVlQYlJpRkpDTkRsSHRPZk94N2VIa0pwWGVyZlJocVA5?=
 =?utf-8?B?UXJaTm5abkx1S1lXVERZbzZhNzM5NnRiMWx3cWlJSzNMTjVRL0pUQkNRVmdM?=
 =?utf-8?B?Um12c0RaQkNiQnIvR1V6UmxnOUZtczl6ZllEVENOTjVMQmoxUkhrb25oZmZs?=
 =?utf-8?B?RTFUNlVCanlCQUMyc1oyL0E2bUNzUkJDZE43MXhyV25LaFEyOG5ZT1EyUWdq?=
 =?utf-8?B?RUVkeHl4dm1zRXpZTHZ6bGFxK0pCNzFTZ3VMNW51MkcveFJHcHpmaEhiRmVT?=
 =?utf-8?B?R1hFbHlmcUMxSGdIQjM3NUR0YzZmeUxEWTVlSzhFL3pSOXo2VUhIRG0vazlW?=
 =?utf-8?B?ZmNHREl3YUd4K2VxRENuUUpqMEhNTEl1UFRzT1VFUXhoS1BNeTBhUk4yN3Jr?=
 =?utf-8?B?Ryt5cXAzWEJWRWtuaDc4MmJLOTlSaTU2dUt2Tzc4VG1CQXRwc1hSaU55ZFQz?=
 =?utf-8?B?bHdqeTd1RUE4bEhHUVgvTWdhanB2Ull4R3EzTE5MNkxOQlpvNlYxZWpVa0FZ?=
 =?utf-8?B?STlZdGxCZm13eGs0RnRodmQ1d01VMWJKUVNha3JFRG8wMzQxSCtPQUhtd3dK?=
 =?utf-8?B?eEJsWkJUQXhDc1V4RlpRd1BjYnhsSTB6WER1aktyTUpsakdJNy8vU1plUU82?=
 =?utf-8?B?dHZBWFRITmxsRUt1bTgyOXUvakx3cHZyZWdKcVJ2bXN0dnJtK3M1TjNJbFJH?=
 =?utf-8?B?TTcxM1M1WWRBUmhpN0NMTDFaV05CSHBwbm1LcXFKNFJJRkJHbGcrK2tyNkps?=
 =?utf-8?B?YTFhVStJR3JxYTlxY1hsUFhzemFpWGdwZk1kSkRjYjlIWHQzREc0Y0Y0VDFO?=
 =?utf-8?B?OWNPQkJ0TDNvSWMyMGZiSnZPVDlvTDhuRVF0WHhiZkRLOHVDa3hWZ0E0VWdS?=
 =?utf-8?B?V2VBa3NtU3c2SFhIOHp2RVNCRlFjcTFFWnlNOEZMNXoyd0cwOHI2bUliTC9h?=
 =?utf-8?B?djRPNis5ZG9xai8ybEg3VGlRd0FEUUhkd2NDS0V6czF6dmRLZlNBNHNYL0dB?=
 =?utf-8?B?dzBCV1hRZGFrUkluSFFjU1JyLytuOUpkTjVLU0IwY3F0eXc0WUVMcXJ0ZjEr?=
 =?utf-8?B?VzJ5VFVOSWZ2YXFOeW5DRHBSeGNtNkFJV3FlODkxaW5jOVZSUlJmSGFGOGV4?=
 =?utf-8?B?bHJFQmpEWlBWWEMxZFNJY1lQM1Myck93YUpDV0NlUEZ0N09Rb0lPYys4SEdH?=
 =?utf-8?B?d2NPV1hyQmZCODE2TjcrVnpXcWtnRWQrdytTL04xNVJZM3gzaGEvSnFRV1NC?=
 =?utf-8?B?b3ZvR0xFbXA5anhxTnA3V2FBMXZ6T0VJU2gwUHdkMkpHV3dyRitWeVBvN3Z3?=
 =?utf-8?B?YmVnZS9mckRiWnRTanFKSXZNWjV2NkVTUUJTWUpwNjBXbS9pdmpSYTcrOUZk?=
 =?utf-8?B?VWx6cEVCeXVleWJQOHJMOVhaamNVWHZRVTRYVkhNSmwyaHpSSDBETWRsd1k0?=
 =?utf-8?B?Zzc0Vzd5M2tzTUpoZTl2M0lsa2VVUUFKSDROaUMwWnJyN0VmbEVia2ZLb1NZ?=
 =?utf-8?B?Q2RBZDFITUkyQVpVbVdBNWl4ZmdFdkI4cTlEOUZjY2R0VlhEUlQ3bTBpZStQ?=
 =?utf-8?B?MGlqUXZBaWczL3dSakhsRVBpSU9VRUdFNXY2YnhZNHpBUDZ2WDBTQkJ1d21K?=
 =?utf-8?B?Z055aERnZWgvaitSVC9YbXNONUNvT0ZBUzVoMTRJWkxGdHA1R05oZVIreUZL?=
 =?utf-8?B?WXAvYmVpRVRVUnBmaTdqalFQaFlvZHlmQ21YRG12dC9WM2NqWlh3OFM1d1Nj?=
 =?utf-8?B?ZDYxMnRVYzN6c3lZTlpIV2lvWUtENHVocW5DaFFYdGgvdXoyaXB3czJqOUFk?=
 =?utf-8?B?M0ZZRU5nQkZ3ZEhub0RzcU5TTDZSQTNqTEt5TXlQN1p2QUpPb3dkeGdvdk9C?=
 =?utf-8?Q?JuNsPN3ogvQgv9QZ4spW7GLmi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03b6c84e-5c1d-40f6-de01-08db8db98dd5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 09:20:29.5114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kODCLwk8XZE3TKUF/aWsESIMsJ054EdbzwVMWYjBZzD+Wg1uew75ZV5h6lCX5axBENvD33fqFM15p6PnEEcumQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5602
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/26/2023 10:36 PM, Li Zetao wrote:
> This patch fixes the following sprse warning:

s/sprse/sparse

> 
> arch/x86/boot/compressed/sev.c:28:13: warning:
> 	symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> 	symbol boot_ghcb was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>

With the above nit fixed

Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>

> ---
>  arch/x86/boot/compressed/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
>  #include "error.h"
>  #include "../msr.h"
>  
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>  
>  /*
>   * Copy a version of this function here - insn-eval.c can't be used in

Regards,
Nikunj