Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp843703rwb; Wed, 26 Jul 2023 04:00:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlEqcSeLQ3SzQmRFzU/nQOM9BGTwGwWKjI3O1YwMmbZx8qHd/3EjkDiZYuO8Av7UqM1F4hpk X-Received: by 2002:a17:90a:2c2:b0:268:2862:7414 with SMTP id d2-20020a17090a02c200b0026828627414mr2143906pjd.0.1690369204411; Wed, 26 Jul 2023 04:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690369204; cv=none; d=google.com; s=arc-20160816; b=mlY13G9wJsu9YJRGqDG2JI4imCEzU7EIaP+U+r/0NgZEfqmBrAIELQuk2iDYeRcBFg 9n9MJkFoZt4Y+NRb16Zulm4NG2Sp1AAwipwI3AQ1ZpuvyVXiQWR4NCHqX0ZCL4lEz8x8 CxKKV9M11SYyveJuOBJfnvK5FivjNFJO/LxLNHeHszdpyX9bSjNcA0YMZbFhlvS7WpDH 0k9kY8btoI2pj5D3RDXOQ1v4SlfMXrSuJDDgbaBx/BuqtcO0vc8plUiCwTkkO8SOqMk0 0OGoPg9i6E34qm8ia9mzGSHROeMu3fBrlUUxrmkjMltObdb8YiV5UX3Uxej5RefiAwrI pLDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=2yAmYhGldVHhyT7ZSI6kVFbQb2yLkzPV11Y+1iitEP4=; fh=nk6OsamgPQrpzlAZ/cxLkZifN0Q2XVTQykTXU28aLc8=; b=Cp3kMcehQj+4dZE2WH1Y8lwAE+Gl+pES/w1+yUzYWpeYpOCG2nfDsB9+wUGdaVrRve YGKSr2dxeHHmYYNr95w54gk2W2TzOn8wJt4icRFubT8TvE1a7uhLj0jQKb1xamcYn24T H9gxb8mTjIR37gje+roVyT7BrKPQngVbO6YCw1kgRVB5o1NHxonSOwt05x/nAio5Ka5c VZZ81W+mtIn4wC6UGMbZl5V7VGt4aVQzWzWgtNiJlRD8kccEFlMl/6peDBnj8GqXighI 2kS/MNWO0uYEvLq2ey4qKkl7CVdMf8qbxCGLLRvOIUPDOFyTJEoy9SA6HH6avuV1p9c2 Su8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q99-20020a17090a1b6c00b002681def2222si924719pjq.129.2023.07.26.03.59.51; Wed, 26 Jul 2023 04:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233079AbjGZJue convert rfc822-to-8bit (ORCPT + 99 others); Wed, 26 Jul 2023 05:50:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232628AbjGZJu2 (ORCPT ); Wed, 26 Jul 2023 05:50:28 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2DD9DBF; Wed, 26 Jul 2023 02:50:23 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 36Q9npfpF021032, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 36Q9npfpF021032 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Wed, 26 Jul 2023 17:49:51 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Wed, 26 Jul 2023 17:50:02 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 26 Jul 2023 17:50:01 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d]) by RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d%5]) with mapi id 15.01.2375.007; Wed, 26 Jul 2023 17:50:01 +0800 From: Hayes Wang To: Andrew Lunn CC: "kuba@kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function Thread-Topic: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function Thread-Index: AQHZv253hmgza7BjuU+Y5BpmqDIk26/LM6YAgACP1oA= Date: Wed, 26 Jul 2023 09:50:01 +0000 Message-ID: <95ecef91f1b9446f8a69280d69422b40@realtek.com> References: <20230726030808.9093-417-nic_swsd@realtek.com> <20230726030808.9093-418-nic_swsd@realtek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.228.6] x-kse-serverinfo: RTEXMBS04.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Lunn > Sent: Wednesday, July 26, 2023 4:37 PM [...] > How often is byte_en 0xff? Do you have some benchmark numbers to show > it is worth the complexity? It is usually used for writing firmware. The firmware contains several blocks of continuous registers. I think it is worth, even this only saves several numbers of control transfer. This patch could replace 3 control transfers with 1 control transfer. If you could do it with one step, why do you use 3 steps? Besides, a control transfer is a complex process. I think this could reduce the loading of both software and hardware. Best Regards, Hayes