Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00c3acd6-4599-f7b6-be8c-5f605932a253@intel.com>
Date:   Wed, 26 Jul 2023 12:39:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH RFC net-next v2 2/7] net: page_pool: place frag_* fields
 in one cacheline
Content-Language: en-US
To:     Ilias Apalodimas <ilias.apalodimas@linaro.org>
CC:     Jesper Dangaard Brouer <jbrouer@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <brouer@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        "Alexander Duyck" <alexanderduyck@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230714170853.866018-1-aleksander.lobakin@intel.com>
 <20230714170853.866018-3-aleksander.lobakin@intel.com>
 <ac97825d-6a27-f121-4cee-9d2ee0934ce6@redhat.com>
 <e48185cb-3057-e778-75c4-d266a249088b@intel.com>
 <CAC_iWjJ-yfW2Bu-vYQHVw3Y0svkYQNOva3orsv0VzvWyfQkiLw@mail.gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <CAC_iWjJ-yfW2Bu-vYQHVw3Y0svkYQNOva3orsv0VzvWyfQkiLw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHh2c3FjS2xtYWEvSEJBRWpraEg0ckhib0d3T09PMkdzQ3pYVWk0dUZyWGtL?=
 =?utf-8?B?bHNoN3FMTzFsYkRWUXlmRVo1WTBCUmtHR08zWHQzQXpSU3RCN3dZYWdoWWxn?=
 =?utf-8?B?TGh6clI0Ty85REwrNUk4aGdvQmFIMTk1LzNiN0YzNzhXZ21oSW10dTcwMWR2?=
 =?utf-8?B?bUdQZHBqeU1DN0xtVlJhOXIxV0c0QjNUMDRESzJxS1pQVFgwVExkNHFpUm51?=
 =?utf-8?B?WUR3LzJpYjk5SUh6enRhWFJONlJoUFZXREMzVXhnaEZqUkJvb2lkWktXTUNP?=
 =?utf-8?B?TVBRSm5oUFpoWU03clF4QjRvMHpULzE4anRlbE9RZng0dUthR3U1R1lmaGdF?=
 =?utf-8?B?SWRBenN6TFRTSWY4N0JQcWUzWlFvRVRFK1UyazVaaWRLUTlTQkpVSXlNOVY4?=
 =?utf-8?B?SmlwNGovNUZ4V2VrVHFoMmhnL0tjSkRoZXV1UThXQkFZUEZLaW1QUjFiRm5h?=
 =?utf-8?B?ODkvWDRTdmpWZjZRby9aQzJaU2pkTEMyQThFWFJVRmF3cUFPeXlxZ0Q5RkEv?=
 =?utf-8?B?MXdIYjdaMzFGSksvVVp6UWxaV1Z4RTRLbDdOaUlMekppdTNZWEJwTDQrbnhC?=
 =?utf-8?B?VWQyMVRGV0d3aDBHWlFwZFZFYXUzY3dBeFgwTnhiUE55NS8yWE5yZjdhc090?=
 =?utf-8?B?TlJyTVQzZEVTS2RXRmtyT25CTHprZERUSmRCajQrZEJMS1h1a3FiY3dKVlR1?=
 =?utf-8?B?L1cxMDdOSVJ1S2JlR1dFZkFvM3pXRDM5RjlLR1hMV0RTdE5PcytxLzBIQnFH?=
 =?utf-8?B?N1NLUnV0eGxaRFZVdm9FNTlzWDNmYUdXUGdOUFdFanRXRy9henhxMFNMZjRK?=
 =?utf-8?B?R3RYLzVWTEEvSGFKc1JVLzFuak0zUFNYOGx0YVZNWi9nbVJZM2lWT0JFK1BB?=
 =?utf-8?B?VU0rQ3BMNlBFdUQ1dFRVYTcvcjNzQ3NtZUFaaXdnR2pya0dwWUJydk1tMVhu?=
 =?utf-8?B?dFFzVUkvTnhVNTEyWHU0Q1ZGZG4zK3YrOTdmZEUycUYwZ0ZlWVc2Qnh1blYx?=
 =?utf-8?B?S3dsbHhPUVN6T0dFc1hhYzZHVFBxd0FmYWczUWNnNTRqQk5rOFhjQWV2UTRW?=
 =?utf-8?B?NTJXUTNsWU1YZ0lOSTQzR04zZEV3RUFDRWxnUmdwdzV4VVgvdzRTbkJXUUNJ?=
 =?utf-8?B?MEJEVitTdURvdUxVWlVrYUp4WTNBNjFwYjVOd29GRUJTOE1JRXQwZkhrL0Fw?=
 =?utf-8?B?SVhucWxOWm5BbXg4YzdtNmFBVlBwZ0tEaU5XVWVlK092cWhwdlVqUGlsQ3Bs?=
 =?utf-8?B?WkE2UVlTaG90U1diODNId3NxaWt5b1pBQU9ybHluRCs3cWZqcEhOanNRZkVw?=
 =?utf-8?B?UzZFb3R2L2dHWVI4STZNWTVscDUwRFJQdjBCK04rQ0VuZmh4VExsY1ZBb1Vx?=
 =?utf-8?B?SXYyaDl6eEl0MGhBNW1xZ05wZzd0OGhnUDhxNlJudnN3TTdBc21VTnJNL2hC?=
 =?utf-8?B?aUprbWpDci8yZkQ0Y29Vd0hvWmZwSGtiZlMxNkR4NUZ0dUlWOWFUZkxMQzVV?=
 =?utf-8?B?OXhBK2VnMDlCcjkzQkNDUzBGc2xiK2F4cVlrY3VlWHQvQlFmQzlGWGxmVHIr?=
 =?utf-8?B?K2Y1VTV0b0E3U1YwRDBpL3NHUHNlbk9NR0pkMzlBWFFEdGY0YmVDbHRSZGlV?=
 =?utf-8?B?QkZYMHhHdmZEOXBNZFhXYW4xckpYdzM4K2Z2TlJNWVM3dUtBZTFFTW9NaFE1?=
 =?utf-8?B?b280NGlKZUp6bFp2SDFIWG52Sk1oTWE2cnFKWVhIa2ppMEJreDh5Yjg4elBH?=
 =?utf-8?B?YlRPRXA0dkkxdlZWZ2l2RVMvNlNMVS9OWHRGQU5UZDZQOC9ZUlFXWVROSERT?=
 =?utf-8?B?U0p1REZFQ040V2Y5M2tHZnZ5RzluYmpFWVlvNUhFS0hwTG8zN2xNYUZHNVFv?=
 =?utf-8?B?eURZZ2hYMFhLVFBiWnF0c2VpMTFvLzVGUEZPQ1ZLb09IK3YrSGlUWlpNS3dJ?=
 =?utf-8?B?WjBnWGI5bTFFVUJLN3UvcGRNbUNFZXNSVlowQzM4bGttNFBNTjdSYWIwRmJC?=
 =?utf-8?B?ZytGbjZPYXFXaTdUcWdmS2RsWUp4a0Z5RnV4MFFWOHpBSDhuTUhEdFRUSE4v?=
 =?utf-8?B?RXVjNWVJUGp4aCtacGt4bm1ZckREd3pVQ1JjbUYyVVdQd0NKb2g4N3p5b3lL?=
 =?utf-8?B?aG5xaW1LNVZCdFhhaXBSZjRFaEI3ZFpVaTQyakkrdVVDNkhFMEdRU0pGRzZQ?=
 =?utf-8?B?ZVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 20696385-df21-495f-24a6-08db8dc4d2cc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 10:41:09.5763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dAr3PtIPskKgkAdl3/HalmEuMFiGddUC3vMSF1w1gr0kJEU1c9ulnMsFa1fUpuyBtR6/WQHOJviI+bDpxH+cOjm89OKJigJhdZ7kKU+/tCA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6340
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Wed, 26 Jul 2023 11:13:26 +0300

> Apologies for the late reply, I was on vacation and start going
> through my email piles...

No worries. I remember having to grind through hundreds of mails after
each vacation :s :D

> 
> On Tue, 18 Jul 2023 at 16:52, Alexander Lobakin
> <aleksander.lobakin@intel.com> wrote:
>>
>> From: Jesper Dangaard Brouer <jbrouer@redhat.com>
>> Date: Fri, 14 Jul 2023 20:37:39 +0200
>>
>>>
>>>
>>> On 14/07/2023 19.08, Alexander Lobakin wrote:
>>>> On x86_64, frag_* fields of struct page_pool are scattered across two
>>>> cachelines despite the summary size of 24 bytes. The last field,
>>>> ::frag_users, is pushed out to the next one, sharing it with
>>>> ::alloc_stats.
>>>> All three fields are used in pretty much the same places. There are some
>>>> holes and cold members to move around. Move frag_* one block up, placing
>>>> them right after &page_pool_params perfectly at the beginning of CL2.
>>>> This doesn't do any meaningful to the second block, as those are some
>>>> destroy-path cold structures, and doesn't do anything to ::alloc_stats,
>>>> which still starts at 200-byte offset, 8 bytes after CL3 (still fitting
>>>> into 1 cacheline).
>>>> On my setup, this yields 1-2% of Mpps when using PP frags actively.
>>>> When it comes to 32-bit architectures with 32-byte CL: &page_pool_params
>>>> plus ::pad is 44 bytes, the block taken care of is 16 bytes within one
>>>> CL, so there should be at least no regressions from the actual change.
>>>>
>>>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>>>> ---
>>>>   include/net/page_pool.h | 10 +++++-----
>>>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/include/net/page_pool.h b/include/net/page_pool.h
>>>> index 829dc1f8ba6b..212d72b5cfec 100644
>>>> --- a/include/net/page_pool.h
>>>> +++ b/include/net/page_pool.h
>>>> @@ -130,16 +130,16 @@ static inline u64
>>>> *page_pool_ethtool_stats_get(u64 *data, void *stats)
>>>>   struct page_pool {
>>>>       struct page_pool_params p;
>>>>   +    long frag_users;
>>>> +    struct page *frag_page;
>>>> +    unsigned int frag_offset;
>>>> +    u32 pages_state_hold_cnt;
>>>
>>> I think this is okay, but I want to highlight that:
>>>  - pages_state_hold_cnt and pages_state_release_cnt
>>> need to be kept on separate cache-lines.
>>
>> They're pretty far away from each other. I moved hold_cnt here as well
>> to keep it stacked with frag_offset and avoid introducing 32-bit holes.
> 
> This is to prevent cache line bouncing and/or false sharing right?
> The change seems fine to me as well but mind adding a comment about
> this when you resend?

Right. Sure, why not.

> 
> Thanks
> /Ilias
>>
>>>
>>>
>>>> +
>>>>       struct delayed_work release_dw;
>>>>       void (*disconnect)(void *);
>>>>       unsigned long defer_start;
>>>>       unsigned long defer_warn;
>>>>   -    u32 pages_state_hold_cnt;
>>>> -    unsigned int frag_offset;
>>>> -    struct page *frag_page;
>>>> -    long frag_users;
>>>> -
>>>>   #ifdef CONFIG_PAGE_POOL_STATS
>>>>       /* these stats are incremented while in softirq context */
>>>>       struct page_pool_alloc_stats alloc_stats;
>>>
>>
>> Thanks,
>> Olek

Thanks,
Olek