Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp913769rwb; Wed, 26 Jul 2023 05:06:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlHaSybtmmKrv9+n5cuJ1XaE14cTWpgGExRyH5FF8VGF3QVnRY/gw4gqn+ItwLUCsZcPswQD X-Received: by 2002:a05:6a20:8e18:b0:132:87da:5b57 with SMTP id y24-20020a056a208e1800b0013287da5b57mr2130781pzj.59.1690373193045; Wed, 26 Jul 2023 05:06:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690373193; cv=none; d=google.com; s=arc-20160816; b=e8UjfQM+RgabC4+le9E44M4ZaMOddY3n7frtoE1jenC7wOjdrZW+o7+7NYHedSiXoL X2ks6SPHkiunpIy6FoNXMQLouUee/buumQZ5JEdSXyYClt4EJ1SSMxgIQ6/ZdhErwzG4 n/Q4ktacLd9nD5yN94IkUuh3OGnBn/hFcso1a08CS1vsdGDW76ktiL521xMA+CwKVstv Q4dQjMp3u6ZoNRyIK65XPWA70MgJ6PgumgJrqAcaidp3USjsZWFG0FNtP7Jka2UtqMhL iUBS/EADDpUNXpWxq3xW0aGI0zYzIEpc8VYRCPUy6YeoM+id8h6AEjWQ5sO678ABjDoY /6DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=69jj580P1DSe8cr6wdR9bzkleON+onBpdSJQbX0RqQQ=; fh=hECVmal3KRHLJ6jXQwvindS2Tviw1OE/GF1XgNo/KvQ=; b=KRW/vo6J9x3qd4ad33hX81crYOEqRrxvJs6H98JmFwQpx3xYJth4Girm5dChyYJVG1 QD9tuIkRlHVvL5SesCzMftcjZAUuR2SBnXHxIy0gY4Xh40Yn05KW4PS7XLCIOEjeuaE2 yiqxDsKTIj9JJhWMbMyNF0hqTuAAvNVkuWvTEK+W4eEnKnTRBRdTDZbZGJrJHSulbYiF bX6+UHeivjWGgEjsoQtmfyqg0wI+Mhm7tuw1rWrBs606zVymv7NneByrNvWnNDVeBoTI HC/UolTAwoNcNeqAZaiYHmLL421N7GyOwk3cffVwPXWbd/jtSdsO4wJavPtL7thqExK7 8lSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=abCtLTAH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t21-20020a056a0021d500b0065024e5049bsi13153711pfj.334.2023.07.26.05.06.19; Wed, 26 Jul 2023 05:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=abCtLTAH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233287AbjGZK6Z (ORCPT + 99 others); Wed, 26 Jul 2023 06:58:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbjGZK6X (ORCPT ); Wed, 26 Jul 2023 06:58:23 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6AECE42 for ; Wed, 26 Jul 2023 03:58:22 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-31759e6a4a1so3076813f8f.3 for ; Wed, 26 Jul 2023 03:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690369101; x=1690973901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=69jj580P1DSe8cr6wdR9bzkleON+onBpdSJQbX0RqQQ=; b=abCtLTAHxzLZQx3yZP7Jwy4wSL5/u0dolDfq845g7zh8r+qohhm8WyQ+I08DytVAGW ov2RCtlAbso2q1msLc44f4Pn2L4C5m4OhY/FW+ucsvoB1+dYUb91WvHy+R+wdv67Hf99 VBFCnBwPuVvzZ14c8i5mauC35jRBgiU7bRl3jo52k8wT5YXoSarMnQbycr5BopNVsxeQ BmDlAe2ugU2cpcJWzqTLcpMks9xh/dyZZ5aAUFuKqteDD7iRu7C0mZeBL17G+KpOTtgt 2DEn4g5qMf3a6AKY7IRjhPtr9qEuNY3RHTNaW2qC8xRijyBvzM/cPoWyu0lT7cQ80ceb ntMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690369101; x=1690973901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=69jj580P1DSe8cr6wdR9bzkleON+onBpdSJQbX0RqQQ=; b=chQvONZVB9cHIw0bwKMsYNByJ5AoPZ1TKSxdB0KPlFv9ad78JAiKeU1hV3J9hMsker jFUF4Oy79cy3mXAlpK0pdALj6oM0sJ0JFdtdUevtd4waa84oo/GNtmsVN7rTvdErRdTi /yNVNe1MdEZjxrrX8IINpKhKri4IGa1B0FRQ/OYjnsD1i4iLYg9U4q2WGfoZ+2SfatGi XDJGP/tudBddp2WgfU7unKrX4Oy20rxM/eli3j8Z9CHx8S+a2FOtvevDi1sOH1J7W84N T1yF9S40v6yLiBxJwWU5uN4bhJvcoJj4TLRKRN/kPcLGYcS2gqoa6QwdHKO4HsbzJGIW QxaQ== X-Gm-Message-State: ABy/qLZdJNwtKKfJ30W+D0Sta1EYV354UfY6Idr+xKHtCpJzjx6FfQ1p AZcyH9V5lcorytWVHfUk+9rcag== X-Received: by 2002:a5d:4450:0:b0:317:70cb:4f58 with SMTP id x16-20020a5d4450000000b0031770cb4f58mr997310wrr.63.1690369101230; Wed, 26 Jul 2023 03:58:21 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id r15-20020adff70f000000b003143ba62cf4sm19225643wrp.86.2023.07.26.03.58.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 03:58:20 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 11:58:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-4-jack.zhu@starfivetech.com> From: Bryan O'Donoghue In-Reply-To: <20230619112838.19797-4-jack.zhu@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/2023 12:28, Jack Zhu wrote: > Add basic platform driver for StarFive Camera Subsystem. Another nit here. "Add basic driver" isn't a great title. Recommend "Add core driver". Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc. Use "core" not "basic" to describe this. --- bod