Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>
To:     Jonathan Cameron <jic23@kernel.org>
CC:     "Sa, Nuno" <Nuno.Sa@analog.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] iio: imu: adis16475.c: Add delta angle and delta
 velocity channels
Thread-Topic: [PATCH v2 3/3] iio: imu: adis16475.c: Add delta angle and delta
 velocity channels
Thread-Index: AQHZuj0NjLsYHngaGEm/6L/IYLaHeK/HUCkAgASKudA=
Date:   Wed, 26 Jul 2023 10:23:02 +0000
Message-ID: <BL1PR03MB59925DFDE7AE86BF3B78AD8D8000A@BL1PR03MB5992.namprd03.prod.outlook.com>
References: <20230719123152.309624-1-ramona.bolboaca@analog.com>
        <20230719123152.309624-4-ramona.bolboaca@analog.com>
 <20230723133636.4b8fc5f1@jic23-huawei>
In-Reply-To: <20230723133636.4b8fc5f1@jic23-huawei>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2/YV6dPuGQ27K9nqPJAX9mNjao93kMJTReG3fTDHd9VWW/NIsk2WEyQOu3ny?=
 =?us-ascii?Q?dG2p8pGe6/7fGLpeXmnD5IgZ+80Gr5wJE0p+LxrpP6xW72/0ilceF9mquJo6?=
 =?us-ascii?Q?bXv5QUSwLm6BdxGH5JrdwNsKDobBB28KfkcpLCy++xwO09Gk6xrNuf0ZSRxn?=
 =?us-ascii?Q?hC4WCYi6NnS1pG+jblfOtjujSEhfzpwyK8oXorSVVmy8KggXwS/W6Ga+tHu4?=
 =?us-ascii?Q?5g3lQfM9fBtJ5hgl/LoBUJvp3rcezvOR1jKbtL6SsKqeQYhVG3He2+SZkK42?=
 =?us-ascii?Q?lbwQmtUVnwSEc6DLREVwRQ07ZFk6NJMT7JaCWLm1/YbU+Qf5GMzUX3W1c0Y5?=
 =?us-ascii?Q?LaeJESRHkQZBXvg6KNXo2DOaax/o9NvZWPTnlBLhFn88C81510vLOioYp7lb?=
 =?us-ascii?Q?LY3yy+Qxto5zYFjPVmgzx7yq+16soUq3iPTdhut5U9EA0LS36Mf8KBQcEDCy?=
 =?us-ascii?Q?qfH/tmsysw/guDnM04tQkzQh0BWd4uJ4fnyoKOlsB3eei47kodRux7uX28aQ?=
 =?us-ascii?Q?e1ytnKcvRG0U6F3GbAPEc7pOGrBMz7a6Xoe9SNsgXY651uGVu+H5qK4w7WNg?=
 =?us-ascii?Q?4dbwyUcDM/A6x6C3rj+KHHpZhTA2A3C9TAXxSN+9mvmW9hZXFezFPpbA//Pe?=
 =?us-ascii?Q?4Spa/PbzGNzSZvOCMXjUWbUvG47NQk32JlQwLrqCiOjErYbSSw/dbGf520C/?=
 =?us-ascii?Q?S/IDC/vRdDlB2c6UhEaIQErO1QzgXw1sEHboSGa3SG46jvKUGHsVBkVnqRd2?=
 =?us-ascii?Q?s5Bi9xkRnqYi8fkh09s/vSQus+4iz5JwjVeKQC0Ty7PaKQQ6mEaSL+80F8n3?=
 =?us-ascii?Q?bJYHqT91DvT8O2CCQNTQSU/NGZX3xjnczQ3H+aK5PlNq1XugJT3hhFTBT9aa?=
 =?us-ascii?Q?pL6yMMp1FLn6t0plcxzndH1KDSU6l4kXGpYMstLSrwPdCw0l+thMZGlglzCz?=
 =?us-ascii?Q?m8LivmYbHamTv7okxvc8WlYwFiARLccnUuoBHLTQrQspx9k6KP3VtkPJ36CI?=
 =?us-ascii?Q?tYLJtpZsdTs5KBPhZ7ORyLFpG0MIKBT2XehESnh29khwrRWuSCBGThz/ikcb?=
 =?us-ascii?Q?ePAxvRnPaI9OwCNtd4nCJxCMFvIURQK9lVkXLRpMyJE7TpT11rnRC6xpgA0i?=
 =?us-ascii?Q?ih0M6PRFf5OJtcWTUzdMnHAStO0UGiV17QvRqLHY1zuxCGI+eZM6KxuJkexL?=
 =?us-ascii?Q?JBNsaRTxQ0WoU/nRrnYmzDfx57oshAvgdnR1E6sBmvJ81ltnf5jAEozo/dnO?=
 =?us-ascii?Q?suRNi15SPR7N/r3UaA7EZ04cFr2EJHkkEGfwx/apHrqfYD/1n7I69oB+Q7DV?=
 =?us-ascii?Q?Fbvd/LwhacPV+zKRasBsO/gD5BzP7LBjj9uD1WIpM+7UwNHU2fnAd12NqcYb?=
 =?us-ascii?Q?qwAi+4J0bjK7dZJCD9G8o/yIM5tSAmM86Luz4+tfL4sv1ubMb2O2mmWl+yxh?=
 =?us-ascii?Q?FxVbaPXk1FxXnWAmmrBtQC8rk9Q8gubfCs+4qqFiNuFgIx4xIamrfowXzs3C?=
 =?us-ascii?Q?/Ftcfo93oqtjFiOTmQ3xSCEZb6crYh3F2YMoTatmoCgosthrz9beAk3y9RKR?=
 =?us-ascii?Q?Mx/javOBU8PEfhf6vsL+hO5vOlAmMkdcV1Zi9Ysa?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR03MB5992.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea151498-3961-41d6-0cd9-08db8dc24b54
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 10:23:02.9853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EyV5U/s59cyJtzisiwQgRpSyIwmprUgWoSIGfcR24ms2w5Gr5bT33nVgfLLOsuMgzVp0v2CxigxuIA3f/NXnGXSkolVmbmPVatGJd+Pggo8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5287
X-Proofpoint-ORIG-GUID: P5z8Eh0Sxn9XmAy_zRaqm3VzK0mi5ELh
X-Proofpoint-GUID: P5z8Eh0Sxn9XmAy_zRaqm3VzK0mi5ELh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-26_04,2023-07-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0
 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 impostorscore=0
 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307260092
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Wed, 19 Jul 2023 15:31:52 +0300
> Ramona Bolboaca <ramona.bolboaca@analog.com> wrote:
>=20
> > Add support for delta angle and delta velocity raw and buffer
> > readings to adis16475 driver.
> >
> > Signed-off-by: Ramona Bolboaca <ramona.bolboaca@analog.com>
> As noted in my reply to Nuno's review, the question of channel type
> is still unresolved.
>=20

Hi Jonathan,

I think Nuno already offered the definition from the data-sheet, but let me
mention it here again for context:

Delta angle:
In addition to the angular rate of rotation (gyroscope) measurements around
each axis (x, y, and z), the ADIS16505 also provides delta angle measuremen=
ts
that represent a calculation of angular displacement between each sample up=
date.

Delta velocity:
In addition to the linear acceleration measurements along each axis (x, y, =
and
z), the ADIS16505 also provides delta velocity measurements that represent =
a
calculation of linear velocity change between each sample update.

Seeing how we cannot find something more suitable, do you think it would ma=
ke
sense to add these new channels to IIO: something like IIO_DELTA_VELOCITY a=
nd
IIO_DELTA_ANGLE and specify in ABI docs that these measurements are relativ=
e
to the previous sample? Or do you have something else in mind?

Thank you,
Ramona Bolboaca

> https://urldefense.com/v3/__https://lore.kernel.org/all/20230720193457.27
> 2f02a9@jic23-
> huawei/__;!!A3Ni8CS0y2Y!52Dhq_Yj9srV_lE8JgPysp2b3Lbg9U2w94VIGTMa8
> 3hepJgv-NCnFWomV83Ud5C3TGp3tMMI0IDVRYZV5N8$
>=20
> Thanks,
>=20
> Jonathan