Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp935483rwb; Wed, 26 Jul 2023 05:24:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlEoLbGdziW4fD7qmR/vHDzdje6VX49R88SRvd8LXKnK9+Nua1XkKr9v2qxCCo74LwXScMNW X-Received: by 2002:a17:907:2bc4:b0:997:e836:6bb with SMTP id gv4-20020a1709072bc400b00997e83606bbmr2256889ejc.14.1690374252367; Wed, 26 Jul 2023 05:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690374252; cv=none; d=google.com; s=arc-20160816; b=im2zZD0I3QyffAmzkSwPUYEZuyQ56LyYiAovDT4zEKN4acXgfDE4Wv9m9QQux+kweN Mblae/rP4kPEUHGW+kRpQq4PR+SS//bYpgCyEARmA9pmz9iTUePUWzvdYysIFgaVO0qg Rrmk15O515py9sq7UDSW+46QyZGBYfPg05ts0zogNvpDz6YBmFHfirii8A65ZEAh2O6O cf85MDraXzF/s4XxQOxSG6jz8S8jHBrL8k3i3F6VH9J85bKbNBYvzKK+flPKuZw/9nHG 2AkT55uukD+gZ69JgI+iheK46PmMR1WGZRhVxXFje9JAhiwbmMAgQB5UZFx64QTwHjLX WpIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=mnQJuBYjxws9dKF7YJmo1pX1cJQyyI8SIC/3VVKu3MI=; fh=oSlViwBkEgesp8bQTVMtm2pNIQKrhWl0bnMCThtmI3c=; b=U2JN0/V9l9v/xFIm6CmUd4t2WPNjMYMxB1KJqHOvg1lUsfSD7HsA4fvuqZjYmodEsc iSpkKEoWVrjQZUbwbOkcH0aOVNvZq38HKkUrzSdIBqSyuVGYKieLNsLZWe3V0CMYo1Kj Qy8t5bJiS9zthtn/hERHz02AsKQe6DaL/WSddrO82VNKNVCRLm84Q4QnpU07CKjTbzpI 43rGIgQsw7FOK/57j6kJ2nTYFl01NwcOespUFrOQo3KAPl6ttgqFUY0avg1hDQ4eHila kccqfofGHq4ctHFAcEg5YeJn7lZLVaDqKs/nHef/Zc+90crv/tkgPBkC9nBQhnWnvatl RNhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ljM7kJzv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q14-20020a1709060e4e00b009828e8bec17si9396119eji.531.2023.07.26.05.23.47; Wed, 26 Jul 2023 05:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ljM7kJzv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjGZLZk (ORCPT + 99 others); Wed, 26 Jul 2023 07:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbjGZLZj (ORCPT ); Wed, 26 Jul 2023 07:25:39 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 736B2131 for ; Wed, 26 Jul 2023 04:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690370738; x=1721906738; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=mnQJuBYjxws9dKF7YJmo1pX1cJQyyI8SIC/3VVKu3MI=; b=ljM7kJzv+AA4JLsQCrpOT3Kf4EzWQiWwIE8MwgJliMGhRjMHUK5gFM25 L2BZwnAQtw/5rBw4DknI8/qDc541FEFWPszGQRd51ucjjdqcuRj1E+LNW 6prytfT7Qj79wnWo79TW/IwExzKjSuTsNRifm0QEGBFLGdKZhrNQ+Tu38 3/Qe7xMeXAVExPRo35E7wYnLqpmFWPhPw5u8LlIzxLJ/ogRPYtQ0Br0lm 7oR8WrwXuTH4GCz6HC7hRZsyC/cbMeGJi5EDXhTTJXShniQ53gkyiujys Xl7WRnhsiXE076ajZr1jEYwLA+wKVaVILJ/dL6xhQze1nOjgPlsQMhV+q g==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="454362780" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="454362780" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 04:25:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="840221570" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="840221570" Received: from yungchua-mobl2.ccr.corp.intel.com (HELO [10.92.2.114]) ([10.92.2.114]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 04:25:34 -0700 Message-ID: <00321a54-2c13-2a93-a6ab-7a76f1a87a3d@linux.intel.com> Date: Wed, 26 Jul 2023 19:25:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI Content-Language: en-US From: "Liao, Bard" To: Brent Lu , alsa-devel@alsa-project.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, Yong Zhi , Ajye Huang , Uday M Bhat , Terry Cheong , Mac Chiang , "Dharageswari . R" , Kuninori Morimoto References: <20230720092628.758834-1-brent.lu@intel.com> <20230720092628.758834-2-brent.lu@intel.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/26/2023 4:47 PM, Liao, Bard wrote: > ; >>   -    /* add regular speakers dapm route */ >> -    ret = snd_soc_dapm_add_routes(&card->dapm, max_98390_dapm_routes, >> -                      ARRAY_SIZE(max_98390_dapm_routes)); > > Don't we need to add max_98390_dapm_routes for the 4 speakers case? > Please ignore this comment. I didn't notice that it is a fallthrough not break in the end of case 4.