Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 12:49:23 +0100
From:   Mark Brown <broonie@kernel.org>
To:     justinstitt@google.com
Cc:     Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] ASoC: intel: avs: refactor strncpy usage in topology
Message-ID: <8f9467c4-06c5-4e48-8f7e-2565e6b3b637@sirena.org.uk>
References: <20230725-sound-soc-intel-avs-remove-deprecated-strncpy-v1-1-6357a1f8e9cf@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iADVvZ87iNIM/HX1"
Content-Disposition: inline
In-Reply-To: <20230725-sound-soc-intel-avs-remove-deprecated-strncpy-v1-1-6357a1f8e9cf@google.com>
Precedence: bulk


--iADVvZ87iNIM/HX1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 25, 2023 at 10:08:38PM +0000, justinstitt@google.com wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1].
>=20
> A suitable replacement is `strscpy` [2].
>=20
> There are some hopes that someday the `strncpy` api could be ripped out
> due to the vast number of suitable replacements (strscpy, strscpy_pad,
> strtomem, strtomem_pad, strlcpy) [1].
>=20
> [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nu=
l-terminated-strings
> [2]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
>=20
> ---
>=20
>=20
> Link: https://github.com/KSPP/linux/issues/90
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---

You've put your signoff after a --- which means it gets deleted when
applied, don't do this.  The Signoff should be start of the main
changelog.

--iADVvZ87iNIM/HX1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTBCEIACgkQJNaLcl1U
h9AFWQf+NwrKTGgyPU7rnOtBaswSIlcHbij0ClP3vSjtJ/15xC6XRDzxtti6UZa5
HIOsxjuMRRTq6JKuh2/uRKc3IY2ZXqL1Wy7paSR+YB23DY+IBl3npR2aL3Bz7bP/
YMvM2vvrzdLmxmkY+uvvuGGfA46jlgnKT6ULtHECymLHXUolMeXOGWsy0Gd+YPAO
BL2P3v2NuPBe1b0KWfljfVaeGYXVGGvq9Xm4BcZPY3PCFngW00BvduN+USbQZFOy
+EQV18D7MB3sYYXmzmukLOdRNRSkKwE7p2q7Vy3ab0QX/Cwj1bV+hpKnKo2ielOW
IrmADzy2JEdr5W1FP6jXtCemKMKkEQ==
=g3ra
-----END PGP SIGNATURE-----

--iADVvZ87iNIM/HX1--