Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v2] slimbus: Use dev_err_probe instead of dev_err
Date:   Wed, 26 Jul 2023 19:38:48 +0800
Message-Id: <20230726113859.4497-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?456dSlB/QZ0xUqb38N07Cwn8A14uppDJVYZg2ru3ekMyp5cBs5VnCwny1rum?=
 =?us-ascii?Q?fFh9CCRXI0O935mrJUU3GUG/vYjbhNDmmIy//50oTKUn7PKtLF9hUw8TAifE?=
 =?us-ascii?Q?ebUJWP8mdiXLACELFTN+pC1ZAzmKqwtusHUPfsNEtqD3UNvj+ge1YPS5+jVh?=
 =?us-ascii?Q?DzpjpJgAEGbzoEiQQHlILMeG1Auuq5qJziwV6FGELbRVP9OlG+R+Q9jQMtm/?=
 =?us-ascii?Q?0mZU7JQwL4gsOKvbmnuz75k4YLbqxLtlJUR4ScTQP43R4dxlkImY4ZQp24yw?=
 =?us-ascii?Q?/H1nYmYnFtUwv3OZHgYtw0M3kNLKmHksavaMZLP5Da09yLIrvU72MgtvJkDh?=
 =?us-ascii?Q?gHEDOPqIJFzFUxhpf7BtIZYggqCL9m6RZbQfsWV87j1HupRTHzKSqPDJqovz?=
 =?us-ascii?Q?mQf4xMPMM0IkUGbG79vOoCNkkg5/LrPXNVfvC4PafldvG1xXKp7tqyMUovB0?=
 =?us-ascii?Q?gVPNFOWmKvAySMW25eMlxz1EWtGp5+v4cfKDAFrcI0XnlNsLVNgbrpYYp4Q6?=
 =?us-ascii?Q?ZGdM2QOJSHZdIC26hxn1F9WzweBlI9gmd1ihr8dbtOhj9DpHxAsV0ygZi1kJ?=
 =?us-ascii?Q?cytDwfAecQbCUhFWuosJs9PzOmCaOVhDERy9S/AcuX2s4wBmPcMmAOlCBmpc?=
 =?us-ascii?Q?xDBAsTE9P6iFSJEoLsN73OiPj7viz3ylhw8S4wVHQsuP7GzCJLU4pm2ZjX3N?=
 =?us-ascii?Q?cpvNh5T+vQgMmq0nkDLb7vK5gFDDfe+RXBQdk6F4bgwZ99CrFb1+Bl4rIq3x?=
 =?us-ascii?Q?/B53xMV82MfyslSd6OFRKMFvjCc/fuivqy/vuZDG2T6GN/T1wlnX1XD0BsXo?=
 =?us-ascii?Q?Wr9rZjRUv3kIW0IL7aTyK3khiCXYfAMvBGIeRB8+pFrKwCAoP14vcpD3JV6F?=
 =?us-ascii?Q?f7MARRMBASxOB38y3myi7ageAFopOwPGbzVqoKHgzzkRd4wuSFduYivlC6bS?=
 =?us-ascii?Q?wwY1bfHUxYgEFbUj9I9SHnwUY8CVEBG1y0nu7uPE4SZsEWgSXgqA14gZAno6?=
 =?us-ascii?Q?TWPZ2gqwazNeJSjT3+Gu9tUa27d20sgUCXg2BQibYmmuaVtRcFCnRQthLXSi?=
 =?us-ascii?Q?xPxGbovvxPzSCB9nXTZV50icsi7ShZOMzyNJ5Jz3tclMQ7idUpgmX/X4BOZ1?=
 =?us-ascii?Q?nFaOCc0A7QoTOgTgbIgnNHed6UXLsvLwbTGqu6NQdP5b0bjHCsGynknuVOhj?=
 =?us-ascii?Q?GIYBTw5ABcxXCT7+821n9yoJkitNRhHAWKTROAbdSgGkzP2j/p3ibdl8RyUy?=
 =?us-ascii?Q?S4TTqJhnMa31HNlUOMk9JLbFYqTqwFk4qMzh1fQN5UaztTvWOXki70krl3p+?=
 =?us-ascii?Q?3LARY7iCm6ubbw3PEIQ+PEMdaZPZwO1InvTSnYwh5QIw99PamR8a45sYBu1i?=
 =?us-ascii?Q?E+Ffkgp0w59rId0TZ3dBsEKMoKhqwKVl/Cef4dRWBaBRJJpKx9XujegTK43v?=
 =?us-ascii?Q?F11LWqJGPxG/e27iAiROr1RHIjxLx3+LUbjtNifrLORFX1mMoSCQXtugFH4Z?=
 =?us-ascii?Q?WSaaGox12RNYAF5Q5Okru/oxAAGWTV5ICew/gAGqy0PUk1/ey4i148QIXOpf?=
 =?us-ascii?Q?i6mazQrmmzalFALf+jCxIEErxs2mOQmFEBwkVx3m?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28f79337-2097-460c-396a-08db8dcd2827
X-MS-Exchange-CrossTenant-AuthSource: PS1PR0601MB3737.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 11:40:48.6304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X64nPiRG0HMIzTtt2f9CV9sZ9J9GaJ0T8WtDEvalZ9ALoonlmjq48Uy/g2BhcTHOJ98ZteGwHt4f/t6CslopAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4552
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible that dma_request_chan will return EPROBE_DEFER,
which means that dev is not ready yet. In this case,
dev_err(dev), there will be no output. This patch fixes the bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/slimbus/qcom-ngd-ctrl.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 77aa6d26476c..d5c2a732f63f 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -679,8 +679,8 @@ static int qcom_slim_ngd_init_rx_msgq(struct qcom_slim_ngd_ctrl *ctrl)
 
 	ctrl->dma_rx_channel = dma_request_chan(dev, "rx");
 	if (IS_ERR(ctrl->dma_rx_channel)) {
-		dev_err(dev, "Failed to request RX dma channel");
-		ret = PTR_ERR(ctrl->dma_rx_channel);
+		ret = dev_err_probe(dev, PTR_ERR(ctrl->dma_rx_channel),
+			"Failed to request RX dma channel");
 		ctrl->dma_rx_channel = NULL;
 		return ret;
 	}
@@ -717,8 +717,8 @@ static int qcom_slim_ngd_init_tx_msgq(struct qcom_slim_ngd_ctrl *ctrl)
 
 	ctrl->dma_tx_channel = dma_request_chan(dev, "tx");
 	if (IS_ERR(ctrl->dma_tx_channel)) {
-		dev_err(dev, "Failed to request TX dma channel");
-		ret = PTR_ERR(ctrl->dma_tx_channel);
+		ret = dev_err_probe(dev, PTR_ERR(ctrl->dma_tx_channel),
+			"Failed to request TX dma channel");
 		ctrl->dma_tx_channel = NULL;
 		return ret;
 	}
-- 
2.25.1