Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] host: Use dev_err_probe instead of dev_err
Date:   Wed, 26 Jul 2023 19:54:28 +0800
Message-Id: <20230726115439.5640-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0PGqNgNcGGM6RTkMsWF9yS5kdzpKIhA1n93DduMVF5NjVIcV/yJDjoU+y6Bx?=
 =?us-ascii?Q?W/36RwBeKkAl6ciNEgLMTP30AYerMka0AaktAwCHZC9KUj+yDGLqzeE1lNO0?=
 =?us-ascii?Q?ByAMnLcGgw8KvrQI/GgFZtJxsEz+759oDG+8x0aWhhJeHKXo8NAZ9QFPojQB?=
 =?us-ascii?Q?5f1P9mU5DrY7bEeaQAhKWRTUEKxiGxRWcdG4cg7jSSFJCNIk72KuJsDODC7Y?=
 =?us-ascii?Q?GdcfWoVLgADyA7VNigFc9d5ZlKR90Leai8Rpk65UJN8lXg1kRUUMSykzs5q4?=
 =?us-ascii?Q?410rqRp1bnXDFdkCa/lTrWbL8lHUgiL73Lb8wrWGTDR4gJ6Wjw5z5MEsvZvl?=
 =?us-ascii?Q?kulqb6uN10se5r7OSN5H2jh19i0vQ0DL8MY+2UZXr19Oai86rwcZWfDN8FH4?=
 =?us-ascii?Q?OGnVvuzNV+gFxgEROtkZ5yRoHuP3sMm4OlvjJg+b2XO5nTy12IoBioMUsKGl?=
 =?us-ascii?Q?FTilwzIMY1htUryb+fDlNm7Jy1iNmnFvLlfzOxQnasmbmn4mfYEr8jwW9aBm?=
 =?us-ascii?Q?wCcRb6zsDGkWeXA8cs7HTqHhnqMKvTATEJBDbX4KRPTKdQyhpqYd2mHqNBlj?=
 =?us-ascii?Q?TL9GlpmxNWonQFVduaPnMPVRwmD5VzudYIQgcT3YI2JsbzMw78hQF5WJCLcs?=
 =?us-ascii?Q?7LkM6V0SBNjEfSAsLNAI3KW9G7JWByanpxn66KFo6ejCFS3T+r3zqlEfrhb+?=
 =?us-ascii?Q?EhyaEIWBOoSllaXQAnbGixRgJEwFdbmaiCDn2AHBST4GvJfz5sZ/DbgMfuaZ?=
 =?us-ascii?Q?ZusCzorh1TiQCSdyJR1HxM6SJ5F6tPp9Ro5xu6vGor2LTIIKhVqXGquRNkgC?=
 =?us-ascii?Q?PD7Ja6xQ2rrgio8U66RwX0n4qXQXmdPVvayDHDthu+/oitYNdlX78k9OHwvR?=
 =?us-ascii?Q?W3Dt0nAINetKmAt9zLubTKd69YNDAqCDn5barL8wkdbkXNNvCWkY9RbdDeSc?=
 =?us-ascii?Q?AlxYAlAcT53FoWmqCstSLPmPqBbr/UGxeHvfQZKRACxOjqBg77wyER4Wc/bR?=
 =?us-ascii?Q?cLWOqvd2uqOaWnno1RCGGgh6Y6MhrWSMlTOACTkHJH2chCH4ZXW1ytz5GTTU?=
 =?us-ascii?Q?egK9zolIAaKzSvJ3WEHbko0ktFSaorBVGIJ0JQXvJDnmwP3BwazXVbPRdT70?=
 =?us-ascii?Q?DaYdWw3yDnBpsGvCX+QU/xTeXbbpwwVHy0TkpLUaTtOtfHPA0ePq4SpOPbfV?=
 =?us-ascii?Q?55TRFSJ59tpsavZPw1Uc+GXpbzAgJHB909E6V/BkqSKTMhDRQ5uhBnD/oUiz?=
 =?us-ascii?Q?oGXoMuz5ON6jb8wP4n8dOiMugpRAXIhQvuO8J7WSGkv/r5y72j9Mn3hTVlad?=
 =?us-ascii?Q?OwfoVEIXGPQs2dERpjI85SfZ5xvVwZZ3EiD9D3bjJcdgsx9DATdw3JhEpDfy?=
 =?us-ascii?Q?T6SnAXFZDKAV/BH7CkCGVYZEgKqT1M6eYsMC7EBaMnDkkICxqCHCZA2vnLkS?=
 =?us-ascii?Q?/vQVGh16hvNpONu9UuWMuEfDeOGOJkVJR+GHAR3bFyPqYmFlHGzKYmo3Hhjh?=
 =?us-ascii?Q?6+TseALZ7CcoxmKn9vXw70QZiJVfXrSO1aYxDGkjHzgq5ECoXBRLgj4QbGdU?=
 =?us-ascii?Q?jMcCOuG0MODNZEJ3r38dk41Uv0gXXS8McNTxaGUF?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e02e7f4-7877-4050-b26a-08db8dcf1ede
X-MS-Exchange-CrossTenant-AuthSource: PS1PR0601MB3737.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 11:54:52.0220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NNjnb3qyQqWXGp3eSKWIHmRtroYMq29Qr61nhWXdeAld5jblbfqmiuUk+knTGOc7fS0r7qUSRRHF3FT/VwlrlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB4984
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible that dma_request_chan will return EPROBE_DEFER,
which means that dev is not ready yet. In this case,
dev_err(dev), there will be no output. This patch fixes the bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/mmc/host/pxamci.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index 2a988f942b6c..4068cdbed7e4 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -712,16 +712,16 @@ static int pxamci_probe(struct platform_device *pdev)
 
 	host->dma_chan_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(host->dma_chan_rx)) {
-		dev_err(dev, "unable to request rx dma channel\n");
-		ret = PTR_ERR(host->dma_chan_rx);
+		ret = dev_err_probe(dev, PTR_ERR(host->dma_chan_rx),
+			"unable to request rx dma channel\n");
 		host->dma_chan_rx = NULL;
 		goto out;
 	}
 
 	host->dma_chan_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(host->dma_chan_tx)) {
-		dev_err(dev, "unable to request tx dma channel\n");
-		ret = PTR_ERR(host->dma_chan_tx);
+		ret = dev_err_probe(dev, PTR_ERR(host->dma_chan_tx),
+			"unable to request tx dma channel\n");
 		host->dma_chan_tx = NULL;
 		goto out;
 	}
-- 
2.25.1