Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Michal Simek <michal.simek@amd.com>,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v2] gpu: drm: Use dev_err_probe instead of dev_err
Date:   Wed, 26 Jul 2023 19:57:56 +0800
Message-Id: <20230726115806.5702-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MgCTh7lWW37uP6kbdgjFDpYizZ6e3P68nLZIztzzfuddHPyowp42/e0g5Dd2?=
 =?us-ascii?Q?qrJBwA7WB2Z9I+tj3U3V4MgbSJK/JqYsOTHGbdfdBzBYjxV3WY8NXzqqUcOu?=
 =?us-ascii?Q?UsbjmWzWa/FUiN1vrXUbLnrkW7yAf+YbQSK8Q1fx7DvEzdmxXmvwjZOFSnfa?=
 =?us-ascii?Q?DFwQxhfbvl4RWkFgU0EubEGi1gG8I+ze9pqtHOzgeMDSwGyrVfyjbYOIlQ5U?=
 =?us-ascii?Q?cnD7UXilP4xjWfHKpVPVcClccW2YT88g4YXnL2H49hbIOCpKtzG8Bw+DTz5h?=
 =?us-ascii?Q?DkFwt6Kb4+HRX7PNFvIgGoBOvSSNc00gmyL8piI4gbk+MMIBIGnI41NOqhnR?=
 =?us-ascii?Q?OmHTk130i/a7hp4LVw/92T+8A+1EwVjSLoP3/nj9FgIyaAYp/PKTt/RLBfIo?=
 =?us-ascii?Q?ZkH9vuEh6CGJBq1KeocEKL6/W0L0v7tBnK5Oeiwt4NeCpQEbblgrGbPzQ+DG?=
 =?us-ascii?Q?t/yrfvoEcTZrh/KRScDouPslErPcLngaq64aShALkjsQEGvKsGh+0WbbPu1O?=
 =?us-ascii?Q?PzypHlM5Y4eUk1Fc+LP5Ei22GXGTQuihoT268h9tcnp1E/QoCkXal3vRY1vV?=
 =?us-ascii?Q?wdwFQOG36XVPXGMYu16qtoj89Gac+yWYUMGflI9rAPJHFCkA3ztWooMKQmLI?=
 =?us-ascii?Q?yIS2AIS9zXe/QnldAdUmwbMdEXRHQ5DCZb8+hqjb/dXc1KuUfw9Vq+oF0ePM?=
 =?us-ascii?Q?zYV96cUQljzI0CtqnSUh9+RMurGrCymT/+dAubzDTSRJjDBfb+hJBuF/e7I/?=
 =?us-ascii?Q?jRsCLKOFWS7uIs4CkehtXSDDL+K6C3AEKMZhgzH4ppQZQP6o14NT+DpeCYGQ?=
 =?us-ascii?Q?dpMloVySrlZYTR2EUIwiGzG16H1JsxuMKGX/fZPBBjvYCSN3SPVBSbp7bHMc?=
 =?us-ascii?Q?Bs1mVXFBH8hmAJY5i7/TiqooatUF1jVa/6p7v704TFyvYbblvvRVnthAY62D?=
 =?us-ascii?Q?E5q9/T2IH4RjCG1vBHQ3b2E3U4STbRLxzPe0IINx97NST3r/f8HQ8ek+klJF?=
 =?us-ascii?Q?GvNM+kB+uLAAcwFMSO7+cGL8R6T7JhkmGgWQ2YmGeGnxqktc3YTb/5gXD5q7?=
 =?us-ascii?Q?SxJb+znNd5MPmdglEss+UxNPxkyEiWI0Ry/s32yx9hs6gqLSuU/Xrg1G/4FI?=
 =?us-ascii?Q?VQJbkpCzhnx9/PyQCCvySSdcbNIM6mNX3TK/gvz2ilQDzbDWJ+QpdewOX5XA?=
 =?us-ascii?Q?Whm5f87TtU2MPdLW/vpjXGGYrV9WRtNA0opkL3Wfwk+4k3KqQAJmZpqzGpzm?=
 =?us-ascii?Q?2jXSpEBLCR5xr/iyPDCFbMb2vVOUUjhr27Xd4g0tQ2Ohu8B/cCOfDwxM8ayU?=
 =?us-ascii?Q?IkyyVW35W/gb6PT41HFVltqdBSxD5ZJ7Pi2tk0d7I3JCgsRG6JpxhJWD1ivx?=
 =?us-ascii?Q?IgrQ7BxJdfWgXgMZIrHUapdTjeB4XNZhkkR9IRPwQ2BOvfj4Y9oh4YqnpbV8?=
 =?us-ascii?Q?ZZ+oxbbiUf3xKdvJUAYdYPNxphrM0LKcpEIz8koGa9RYuMOTnZ4XLQjzSc7w?=
 =?us-ascii?Q?Smuz/MhweXkvCipL60ynClWsm+3CLBuJ9SgA1VX65wQlcgTYSV70saPGF0TC?=
 =?us-ascii?Q?2nBixu44mKc0VmjiGhJkMMRn2rhABt0gGBX0llV1?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc84672-4ded-4e21-26d2-08db8dcfa8b3
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 11:58:44.8974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XVEXZ8DKVpkfnRKy+FVLehs7k9v9OR56gRFK6Li825PHxIFsUR2D6B80L/KDnisuO7ylZhtfRcVHmPbEM/6oWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6580
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible that dma_request_chan will return EPROBE_DEFER,
which means that disp->dev is not ready yet. In this case,
dev_err(disp->dev), there will be no output. This patch fixes the bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/gpu/drm/xlnx/zynqmp_disp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 3b87eebddc97..676f09fe8594 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -1094,8 +1094,8 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp,
 			 "%s%u", dma_names[layer->id], i);
 		dma->chan = dma_request_chan(disp->dev, dma_channel_name);
 		if (IS_ERR(dma->chan)) {
-			dev_err(disp->dev, "failed to request dma channel\n");
-			ret = PTR_ERR(dma->chan);
+			ret = dev_err_probe(disp->dev, PTR_ERR(dma->chan),
+				"failed to request dma channel\n");
 			dma->chan = NULL;
 			return ret;
 		}
-- 
2.25.1