Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v2] bus:Fix error checking for debugfs_create_dir()
Date:   Wed, 26 Jul 2023 20:25:32 +0800
Message-Id: <20230726122545.6930-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n7uwryanuUwUNZ5ZOqimrystFLLIrQY0gEKlbzbBxP35Gu5JC8tO+AaOl8CD?=
 =?us-ascii?Q?dig5oHEQks6mznnCKMXtMfEgX9Xx73ExvEgGKSZ3M4avA7YtS3IlUuP2wEuq?=
 =?us-ascii?Q?sLWP1ZYJ2twUHYJH13t9ehjnD+SY0c9V3xJs9q+EMzus3DfTB3JWT3hMohDG?=
 =?us-ascii?Q?ErZi3ihPnSH7MC3UTL6AZiIclZkHe0LBISHMI41PqI1ioyljJpyihuo+iBkM?=
 =?us-ascii?Q?y153yRGhcrYBTJAFONKVnQQBWH2am8tdezV0DzftosIwS+XS7nPXCEtDWiV8?=
 =?us-ascii?Q?Hu5AWUUezlQFhXNOFAUGRLSphnFD4halyo9yr0IpyDEZfa+M31v45BV0xd2s?=
 =?us-ascii?Q?zwAtiY/XunIJKehAwi0i4rqan/tR7pdwLhE3da+NCwoh9TX2BYnwLRJdD66d?=
 =?us-ascii?Q?XPN6BafAQcefOzBYq7AsR+UBKv89XypyaSapsA0J7TTlFTxqRZ58Ppwvospu?=
 =?us-ascii?Q?0y3GdAdckSHoWCLVr59s704khnqxe6idhH0Jwt9WdKRNLytz0Nj92KS8G97d?=
 =?us-ascii?Q?NgvwlU+zLp0qmovOaj7ooQW1xfr2CH2KpxLmQMWEaP1MlJ3hTML/vb0l/6nw?=
 =?us-ascii?Q?Pe05Y9fC6fSqsh38Lo6PBML4PlL67F8fUwmW1N9YihanlAhTFmkEj/uDIUst?=
 =?us-ascii?Q?TslQn4uay1lY16IK4TM2ZvGQ2sfm4bUmynscO8ccxFTGf1pauHOONtzWoBSe?=
 =?us-ascii?Q?iAZ+Tt604hw940qEvWRLn0jhBfJKMgaCPnDjGulRZXX09AYfMiftmDihrWWX?=
 =?us-ascii?Q?MXh+fxWomiY/2IPlkAwJHzCRWWwE0Eap8d/Jy6z84WDIqqkd4Y+M0b2wLc0o?=
 =?us-ascii?Q?E/W0sy0oBUFwOljggUYop5M9rYfxG/ZczBfBFH9wdYEV6HhqF9lHtTQAMoxe?=
 =?us-ascii?Q?sIHnpo6hR6y0YPU02zGnsaHByUgLlbNwgGOXT++t5ojPpDfiwdlM5edokUQV?=
 =?us-ascii?Q?lWUsQwLGcjBuY8XZbzKOwkwCZ+E3cXTXVncDefVgxxGN0xRPBQgYl6Ndb54Q?=
 =?us-ascii?Q?455gfsmweoH3aciI1Neyy/+avmYxCqEjf2nf6jeEiexyfyplaPNEAfmROWfY?=
 =?us-ascii?Q?sKI6xhYXdD0T/7Wt5ffG2347iJXMiLz1Vq4G2rYBUr5K0+TfkM0Pd1uf57Tr?=
 =?us-ascii?Q?mqKw6Q254dgI7NXR+oc/7Dp0W3sBis9iReaPWKdeks3JO5ze+dGjrLrJFucr?=
 =?us-ascii?Q?kQJD4m2Y5pVLE/GUChKOjaQ+pqZLQaS6Ddtsbt6kdsjMWnoOcIC0JjS9eRa1?=
 =?us-ascii?Q?gfdL92KvQ4uBQCIiB34EBwspjvum08fAVrBQSxgiqcU6FV5RUQ/ZwMZkbKth?=
 =?us-ascii?Q?OTHK3qGGFqxCaQTXqU/lfa/t/EVPj7ZyL5w4GGsCvkqKwumDQOr/wRYEvAHM?=
 =?us-ascii?Q?FEeqEzW/QZ/m+RZj2DZsc6UnCnQ3lnknGRcAqslW+m+Wlodzpxf5C2Lh/6u3?=
 =?us-ascii?Q?h0tO+CyBzbpI6GfV/BFIbQTZpfmVN3UqK9+cdQkACewnJPApKUWJM4b4cWPe?=
 =?us-ascii?Q?4yrmXqvhhMAyy7W5qhkC0AaglSdm7JkJtUNYtthRSxGN4g9uTDMSH8wS5IVl?=
 =?us-ascii?Q?3UKa3dlVER/hYoI9NEX22c9xbJaYzpyuln4wuQqp?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24d644e9-e1af-499f-5d36-08db8dd3748c
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 12:25:53.8860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uSE6Ik9ZbUH66AHJx2bKa3dnbrNI2ND6tUK3/pm0XlgDEUdUi/06yxLiXNAD+649BBVkjAGvnjCh7RFts8OYVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5020
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

debugfs_create_dir() does not return NULL,but it is
possible to return error pointer. Most incorrect error checks
were fixed,but the one in mvebu_mbus_debugfs_init() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/bus/mvebu-mbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 00cb792bda18..4c514894cc1f 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -993,7 +993,7 @@ static __init int mvebu_mbus_debugfs_init(void)
 		return 0;
 
 	s->debugfs_root = debugfs_create_dir("mvebu-mbus", NULL);
-	if (s->debugfs_root) {
+	if (!IS_ERR(s->debugfs_root)) {
 		s->debugfs_sdram = debugfs_create_file("sdram", S_IRUGO,
 						       s->debugfs_root, NULL,
 						       &mvebu_sdram_debug_fops);
-- 
2.25.1