Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230726070322.103871-1-krzysztof.kozlowski@linaro.org> <20230726070322.103871-3-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230726070322.103871-3-krzysztof.kozlowski@linaro.org>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 26 Jul 2023 10:08:07 -0300
Message-ID: <CAOMZO5C1JN7w+LhK-J0_ttKVopyeRq6VmCpAHujN_tGPMobotA@mail.gmail.com>
Subject: Re: [PATCH 3/8] AMR: dts: imx28-m28evk: populate fixed regulators
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Patches 1, 2, 3, and 4 have a typo in the Subject: s/AMR/ARM.

On Wed, Jul 26, 2023 at 4:03=E2=80=AFAM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Fixed regulators put under "regulators" node will not be populated,
> unless simple-bus or something similar is used.  Drop the "regulators"
> wrapper node to fix this.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts | 45 ++++++++++------------
>  1 file changed, 20 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts b/arch/arm/boot/d=
ts/nxp/mxs/imx28-m28evk.dts
> index e350d57a4cec..6bf26f386a5e 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts
> @@ -18,33 +18,28 @@ backlight {
>                 default-brightness-level =3D <6>;
>         };
>
> -       regulators {
> -               reg_vddio_sd0: regulator@1 {
> -                       compatible =3D "regulator-fixed";
> -                       reg =3D <1>;
> -                       regulator-name =3D "vddio-sd0";
> -                       regulator-min-microvolt =3D <3300000>;
> -                       regulator-max-microvolt =3D <3300000>;
> -                       gpio =3D <&gpio3 28 0>;
> -               };
> +       reg_vddio_sd0: regulator-1 {

It should be better to write:

reg_vddio_sd0: regulator-vddio-sd0 {

regulator-1 is not very descriptive.