Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3bd7b290-91ad-347f-b1b5-5d45ac566f69@intel.com>
Date:   Wed, 26 Jul 2023 20:49:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
From:   Yin Fengwei <fengwei.yin@intel.com>
Subject: Re: [RFC PATCH v2 3/3] mm: mlock: update mlock_pte_range to handle
 large folio
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <david@redhat.com>, <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230712060144.3006358-1-fengwei.yin@intel.com>
 <20230712060144.3006358-4-fengwei.yin@intel.com>
 <CAOUHufYef--8MxFettL6fOGjVx2vyZHZQU6EEaTCoW0XBvuC8Q@mail.gmail.com>
 <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWpvT0tpaGEwTUxLbElZWmptcGNhVG4ydm16NlhuTmRpQlpPOE0xeWF0QWNP?=
 =?utf-8?B?TFk3RENsQnh6MHZsK28zTGJlcnNPeWRNdUlZYlFNVUhmVDQrdDJuV1kxWlBu?=
 =?utf-8?B?ZG82MTYvRFo1OTVlRmc0MkNsNUJkOU11RHpJZGNKYkZmMTZHd3llNHh3L3pO?=
 =?utf-8?B?ZDgxdlFkRkhDS1BOekdWdlJJVkNzLzhDVmo2blkwWURTc1lDZ2YxZUZ6S2RT?=
 =?utf-8?B?RE9HanBOdUdObzdqRDJGQ1YyOVQwbHo3TjFwa0VrenE1bkhBNFpQblptOXg4?=
 =?utf-8?B?ZytWMGhQQTBPWkthd1YrR2Z3cFFXWU1oOU91eHZWbkZGZFFCUHlNalZ1UzVr?=
 =?utf-8?B?OXlmNVZ6bmxFQjV5d1IrSFhoN1lnQkY3OXRUZ0U4N3ovMEZuZ0ZTamk3VjR4?=
 =?utf-8?B?TTZDOXhYNWRKQ3NZTlY4VWk5RDZxNDByUTJGUUhNRXAzNForRVhFUFlFQm9o?=
 =?utf-8?B?VEErZWNkb1dlYjVhbEtLQXdvSE4wd0NUZlBMU3hFeVBUM3dndDFRQ2RyY2NG?=
 =?utf-8?B?UXhaZDZJM0RMbnhGeGMwVUhqckZHU3ZlSFE3YlpEc0cyZXcrcDNVbFdISFhT?=
 =?utf-8?B?N1c3VkdobE5QbmZQWGtEUytxSTRpTmpUSmtLcllWSkdiVHYwWUxQVklpZjE4?=
 =?utf-8?B?akR3dERNb2U5RkVDRE84Q0w5MzdlZ3Qxcms3bDUxcDl1citseGxGOHJxZXhK?=
 =?utf-8?B?VXg5ajBlU2RNaFdPUTBhelcvZGpQMFR5a1NsSmd0ZlpiYWJxeTgybVREUmVN?=
 =?utf-8?B?MzNBUWt3OWxvdXBOcXZhaUNhYVNYNGw3VUlSU2JZRjVoOVhUTDdWbTYxYkYy?=
 =?utf-8?B?dytESDZLMG1KZk42N2RaLzNLcitVZEZWSnJmMDRRTnlBaXFMVlN3cmxuQVdq?=
 =?utf-8?B?UTlLVW5xTUVvTkE3K3pKK2VJaXR0dmdCY241aCtrR2xUZXVQYjVzTDlWcVBB?=
 =?utf-8?B?bkw1OElYWGU2ZGgvTEpqUW5FdC9kRkIvWEJaSkVoTUdaTzRPSmpPUmtxWUZk?=
 =?utf-8?B?WmhwMDF2MlI2VkNydjBvZU5laEx2bFpjOHczdzBkcGFQMXB4VzhmN1dXVjdx?=
 =?utf-8?B?ZStlZXBwaHB1YWlZZE1jZEprOTFiZXpzK3ZiS3lnWGswcHUzdzdUN2IyMjd5?=
 =?utf-8?B?ZW5vRUVRWUI0SS9iSTZoVFZTa3MzM0JDWDVqN25QdTlWMWxHTDhYZHlKR0w2?=
 =?utf-8?B?ZU8vUkllWERXL0pnQ3Z5T2wyUlFwTU40bnVPS2psMTlDZkVoamk2MDUzNzA5?=
 =?utf-8?B?Z0RMd2dLcTFjWWFRdnNKTkR0cEd6K0tlc1VJR3BqQ21NVEMrVVFsdzlJeTAw?=
 =?utf-8?B?N2RraWZYaFFXeWl0NHB5djdDWDJValBrTGpDWUdQR2o2Y3l1a2NnU3lQdEwx?=
 =?utf-8?B?aXcvcVJzUzl2cmNBWGNiKzE2bW1xbkh5MEUwdjRRV2lHZVpXcjcxTWszV2tH?=
 =?utf-8?B?US8xK0pJM0NzTGdsNFIyMUljK3E2QUNtLzRNVHBhWkpMQzVNNEhBYkdudmcz?=
 =?utf-8?B?QUlhdGxISFc5WVRMUVM3RGx6N1ZscGUzNTFtWVhQemNOSlBLTWZyTnZjVlZn?=
 =?utf-8?B?akU5UklKTWtNd2hkQTMzYnRvZmdVN3k1WUttRzJZdm40aUFRTXQwL0RNZXZ0?=
 =?utf-8?B?K2ZJK3pkNEY3OERUcjI5UWtwSmk2RjFuVmlwbnhtSlBJeTVEdlRGc2xoMHha?=
 =?utf-8?B?K1c0bGlnWnVyNStjYy9OT0EwcDlUSmVHN2lJaHQvV05oTmV4Uk1oS1l5MkdB?=
 =?utf-8?B?dmFpeDRUbjRjcFVEWnFaK0M5TmJKL1J1SUZUc1IrbGlUZms3bFNrWjZWZ1Vh?=
 =?utf-8?B?TWtKYWViMTlPWWdSNGJFeVMwVWFoZ0Y3UUJabnRSM21mUzYySEpMNlZhVXpr?=
 =?utf-8?B?Z3BXVlJMYUV5S3JNVEVYU2Y3NlE1UjVEMS8vU3BwMC9GY001VjU0U0lkMjdS?=
 =?utf-8?B?VGl6bllnTTRId2hLcE8zN1lHVFErTlFIMHlJOTdTZHZQQldKM2hLTWFhRjJk?=
 =?utf-8?B?MWpQbytXbEtVZzJmWWtVems5V1lnM1dzSFdPNWJtZWtWQmRpRlZlcisxU0I1?=
 =?utf-8?B?UGhCcTBGd0Y0alJ1emRKd0V2ZUl6QjBaVzA3aGwyUkluNE1OS0oraDJmM2Vx?=
 =?utf-8?B?NE8xRGtwZkJnNlE1ODhCZTZrd1Y1UzV0WFdqQUg4cms5REZvSXhZdElnYUJs?=
 =?utf-8?B?ZHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a11736b4-a5af-4ac1-6a91-08db8dd6cada
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 12:49:46.9859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /nr7yiJm7W40np7Q/q6tldsVdTR0HYvKcdOkyKShWwREAVMH5txlYy0hFlJKRwRFykrg/5o0T8TRSRPhvDZljw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7928
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/15/23 14:06, Yu Zhao wrote:
> On Wed, Jul 12, 2023 at 12:31 AM Yu Zhao <yuzhao@google.com> wrote:
>>
>> On Wed, Jul 12, 2023 at 12:02 AM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>>
>>> Current kernel only lock base size folio during mlock syscall.
>>> Add large folio support with following rules:
>>>   - Only mlock large folio when it's in VM_LOCKED VMA range
>>>
>>>   - If there is cow folio, mlock the cow folio as cow folio
>>>     is also in VM_LOCKED VMA range.
>>>
>>>   - munlock will apply to the large folio which is in VMA range
>>>     or cross the VMA boundary.
>>>
>>> The last rule is used to handle the case that the large folio is
>>> mlocked, later the VMA is split in the middle of large folio
>>> and this large folio become cross VMA boundary.
>>>
>>> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
>>> ---
>>>  mm/mlock.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++---
>>>  1 file changed, 99 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/mm/mlock.c b/mm/mlock.c
>>> index 0a0c996c5c214..f49e079066870 100644
>>> --- a/mm/mlock.c
>>> +++ b/mm/mlock.c
>>> @@ -305,6 +305,95 @@ void munlock_folio(struct folio *folio)
>>>         local_unlock(&mlock_fbatch.lock);
>>>  }
>>>
>>> +static inline bool should_mlock_folio(struct folio *folio,
>>> +                                       struct vm_area_struct *vma)
>>> +{
>>> +       if (vma->vm_flags & VM_LOCKED)
>>> +               return (!folio_test_large(folio) ||
>>> +                               folio_within_vma(folio, vma));
>>> +
>>> +       /*
>>> +        * For unlock, allow munlock large folio which is partially
>>> +        * mapped to VMA. As it's possible that large folio is
>>> +        * mlocked and VMA is split later.
>>> +        *
>>> +        * During memory pressure, such kind of large folio can
>>> +        * be split. And the pages are not in VM_LOCKed VMA
>>> +        * can be reclaimed.
>>> +        */
>>> +
>>> +       return true;
>>
>> Looks good, or just
>>
>> should_mlock_folio() // or whatever name you see fit, can_mlock_folio()?
>> {
>>   return !(vma->vm_flags & VM_LOCKED) || folio_within_vma();
>> }
>>
>>> +}
>>> +
>>> +static inline unsigned int get_folio_mlock_step(struct folio *folio,
>>> +                       pte_t pte, unsigned long addr, unsigned long end)
>>> +{
>>> +       unsigned int nr;
>>> +
>>> +       nr = folio_pfn(folio) + folio_nr_pages(folio) - pte_pfn(pte);
>>> +       return min_t(unsigned int, nr, (end - addr) >> PAGE_SHIFT);
>>> +}
>>> +
>>> +void mlock_folio_range(struct folio *folio, struct vm_area_struct *vma,
>>> +               pte_t *pte, unsigned long addr, unsigned int nr)
>>> +{
>>> +       struct folio *cow_folio;
>>> +       unsigned int step = 1;
>>> +
>>> +       mlock_folio(folio);
>>> +       if (nr == 1)
>>> +               return;
>>> +
>>> +       for (; nr > 0; pte += step, addr += (step << PAGE_SHIFT), nr -= step) {
>>> +               pte_t ptent;
>>> +
>>> +               step = 1;
>>> +               ptent = ptep_get(pte);
>>> +
>>> +               if (!pte_present(ptent))
>>> +                       continue;
>>> +
>>> +               cow_folio = vm_normal_folio(vma, addr, ptent);
>>> +               if (!cow_folio || cow_folio == folio) {
>>> +                       continue;
>>> +               }
>>> +
>>> +               mlock_folio(cow_folio);
>>> +               step = get_folio_mlock_step(folio, ptent,
>>> +                               addr, addr + (nr << PAGE_SHIFT));
>>> +       }
>>> +}
>>> +
>>> +void munlock_folio_range(struct folio *folio, struct vm_area_struct *vma,
>>> +               pte_t *pte, unsigned long addr, unsigned int nr)
>>> +{
>>> +       struct folio *cow_folio;
>>> +       unsigned int step = 1;
>>> +
>>> +       munlock_folio(folio);
>>> +       if (nr == 1)
>>> +               return;
>>> +
>>> +       for (; nr > 0; pte += step, addr += (step << PAGE_SHIFT), nr -= step) {
>>> +               pte_t ptent;
>>> +
>>> +               step = 1;
>>> +               ptent = ptep_get(pte);
>>> +
>>> +               if (!pte_present(ptent))
>>> +                       continue;
>>> +
>>> +               cow_folio = vm_normal_folio(vma, addr, ptent);
>>> +               if (!cow_folio || cow_folio == folio) {
>>> +                       continue;
>>> +               }
>>> +
>>> +               munlock_folio(cow_folio);
>>> +               step = get_folio_mlock_step(folio, ptent,
>>> +                               addr, addr + (nr << PAGE_SHIFT));
>>> +       }
>>> +}
>>
>> I'll finish the above later.
> 
> There is a problem here that I didn't have the time to elaborate: we
> can't mlock() a folio that is within the range but not fully mapped
> because this folio can be on the deferred split queue. When the split
> happens, those unmapped folios (not mapped by this vma but are mapped
> into other vmas) will be stranded on the unevictable lru.
Checked remap case in past few days, I agree we shouldn't treat a folio
in the range but not fully mapped as in_range folio.

As for remap case, it's possible that the folio is not in deferred split
queue. But part of folio is mapped to VM_LOCKED vma and other part of
folio is mapped to none VM_LOCKED vma. In this case, page can't be split
as it's not in deferred split queue. So page reclaim should be allowed to
pick this folio up, split it and reclaim the pages in none VM_LOCKED vma.
So we can't mlock such kind of folio.

The same thing can happen with madvise_cold_or_pageout_pte_range().
I will update folio_in_vma() to check the PTE also.

Regards
Yin, Fengwei

> 
> For that matter, we can't mlock any large folios that are being
> shared, unless you want to overengineer it by checking whether all
> sharing vmas are also mlocked -- mlock is cleared during fork. So the
> condition for mlocking large anon folios is 1) within range 2) fully
> mapped 3) not shared (mapcount is 1). The final patch should look like
> something like this:
> 
> -  if (folio_test_large(folio))
> +  if (folio_pfn(folio) != pte_pfn(ptent))
> +    continue;
> +  if (!the_aforementioned_condition())
> 
> There is another corner case I forgot to mention: for example, what if
> a folio spans two (the only two) adjacent mlocked vmas? No need to
> worry about this since it's not worth optimizing.