Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 15:15:20 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Christian Marangi <ansuelsmth@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Atin Bainada <hi@atinb.me>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable
 and keep off if standalone
Message-ID: <ZMEcaKWzoAvtz+CK@corigine.com>
References: <20230724033058.16795-1-ansuelsmth@gmail.com>
 <20230724033058.16795-2-ansuelsmth@gmail.com>
 <ZMDXFiSFI/hyr8j6@corigine.com>
 <20230726121435.stqwc3jzjll222ck@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230726121435.stqwc3jzjll222ck@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ez1hxRd6yiFeBrNvBd0FQacAj82T2d+oJwoE/gQZL99b9Qll1eN2zku62leq?=
 =?us-ascii?Q?cJ3DNVK7kTIQnC1/Y2JFEswlgNfXx/XWX+qNLiWRIQ2tiohmWqHD2IoXBMCE?=
 =?us-ascii?Q?N4u74nEwH/ndt7+RdI/CM8LASOSQ+gD6aW3fqVvp5MP2WrAF/pLzDKF5xAbA?=
 =?us-ascii?Q?ouG6TAVeFs/axbYTnE1ZVdSPgpxLd/N/VK/JNUOhAWYwiKinhB/yepmV+aJP?=
 =?us-ascii?Q?yaGLoTbj+4A2voelichMeOe4V+oZXOUxk7df1FQPdCk8gjeISWXEvScxjs5C?=
 =?us-ascii?Q?+oLxmTj/1egvVXfv/DuoT9TwaCIAQVn+vb4RG4NqQXWzYWF9WaLu8NYZUbut?=
 =?us-ascii?Q?mBKs946EbWwplGvHaxrC0bA6Q71gLweHKSo3Sedae/AxJUlratfeCWY7nYre?=
 =?us-ascii?Q?O8QRtObOcvWC2WC1m7C7VapQB1ZFIfG4ES9JEu7uIv/+RwLOvREjiHy9yetz?=
 =?us-ascii?Q?qF5pwaWRJLfefvjNuTPZYTIY6USOPSP9aAOfz39rI7Z6BhHYP/73mCXR187x?=
 =?us-ascii?Q?vbkpoFaTbCWo/GqxSb1IzkM/l/dydojW2A2ESiRplhrhwD2N/Sh+sSVGkDnj?=
 =?us-ascii?Q?S22DyeA0DwmBNk+lv3/pO5e3Xu8UWtLDr+FjSOQTY9GzOlCE5g+Z549sIb9r?=
 =?us-ascii?Q?qXVGnlK5NOEZtKHivvDDofTPJHPCMzl/jXBQz/+hde/FQ/AmJfoKwKlS/MP2?=
 =?us-ascii?Q?hNEcC6IWKnc356jsr2hsnP7D+HQd6+HV4gOzH496JTTv33jmQn1RoWxwdaT/?=
 =?us-ascii?Q?Ss1SBDgLF8UwwDBbXFilELZA6B3Jl+lin5xBYqpE4fQPQ6ABF7WDL4hL3ANa?=
 =?us-ascii?Q?jsfJ2JHH8UfW+jlhagwihflPDU1TycgvDMYBckGwPbfqdsNLaUa5bhnffuqB?=
 =?us-ascii?Q?duw9aNyTOOVWFCDs5L00UUL1HkDRJEBsAA6ZxhhXGXN8PvY4voNjORV5IYZr?=
 =?us-ascii?Q?acQUTgTIFsQxzHPQcCazJudMS37fYMZARQL/kEh3IQcNiqw1yWJ+IlyxxJ0Q?=
 =?us-ascii?Q?NVTwt11j3fS7Lwf2S4Q5+xdqEPlChXjEUjaPx/IAsP8JnRkfDOgyRDneGcDJ?=
 =?us-ascii?Q?krwd49D5alCfOT56O2dBlIjh0zoXlemzO6K1VHxoKNwE1XU2F3DfZ/Fw6HGb?=
 =?us-ascii?Q?ckMSGNrt521eTPIyWkQaAnbJiR0uaTJOUAV3yu6lzwdPb+czt2L5xqJx6AhM?=
 =?us-ascii?Q?r5+R34NTuBTqPCaO5OkJqGY0Gbx2S/q37Zc5gCvhgtE/k9Xq7PxCuG5OZ5Vy?=
 =?us-ascii?Q?iiEkcGP+NP+JTbJ0F5L986ViL68BnOEx+qlhlppDbozdWwjPGplj90qYqsz0?=
 =?us-ascii?Q?K5sLiArt6mDvSeshk4dqewI8HVCFQhYyu/55VVQW1m3iGNfSlT1x24rnaVIK?=
 =?us-ascii?Q?sQs89kIYkIiJ0/wxLtExVp5yM3lKnKz0v2hxSxRTI52ADWiTUpqG4D7WTKnv?=
 =?us-ascii?Q?ggjdTzOpLKvcCIfyen9eAEAgPzC8Wtkb8Gx+TxnkmRaF5rK33PtivhWXuOlL?=
 =?us-ascii?Q?FX3KhgSbRem1kDNvGzu+hg5Xi4j4nWN02+PKUOelpSgJhQ6J0mro7zfz871y?=
 =?us-ascii?Q?IPaisXgMpEa/KmcuA9Kq2y4wEzksaRM1DmzMKe7rORmgMTJxtJJquA5ce3Nj?=
 =?us-ascii?Q?Gx8XxRVjowsTIpT+thBiZC8jaQVf5xyAYF8ajD6RqjI+Z7DxLnqUEYBcovq9?=
 =?us-ascii?Q?dVDeaQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 697b66d4-ecb6-4891-99cd-08db8dda6087
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 13:15:26.6132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y4IVuJ2v/NhFjLmw1OKlepNHojA2NISqWgiDSeLhah2LKg4Pmzr1JZtrsEUsW93KEsMqG6vmJ3L+GprlIZHohBUZNx/Jk14LfIcSCJWDuZA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4085
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 26, 2023 at 03:14:35PM +0300, Vladimir Oltean wrote:
> On Wed, Jul 26, 2023 at 10:19:34AM +0200, Simon Horman wrote:
> > > +int qca8k_port_pre_bridge_flags(struct dsa_switch *ds, int port,
> > > +				struct switchdev_brport_flags flags,
> > > +				struct netlink_ext_ack *extack)
> > > +{
> > > +	if (flags.mask & ~BR_LEARNING)
> > > +		return -EINVAL;
> > 
> > If I am reading things right then some implementation of this callback
> > return -EINVAL when they see unexpected flags. And some seem not to
> > - possibly because all flags are expected.
> > 
> > So I'm slightly unsure if this is correct or not.
> 
> Which ones don't? All handlers of SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS
> should return -EINVAL for changes made to bridge port flags that aren't
> supported.

Sorry, on a second look I see that my statement above is incorrect.
I do wonder what it was I saw this morning. But this afternoon
I see that all users check flags and return -EINVAL as appropriate.