Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1161168rwb; Wed, 26 Jul 2023 08:24:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqXwWwJTdD6Lg5RwmnpTVnHoBJbtsS8z3v79Ga+6i1smcrN2nVaHoYpEadWe2PEqBeveZX X-Received: by 2002:a17:902:a408:b0:1b8:a936:1905 with SMTP id p8-20020a170902a40800b001b8a9361905mr1880686plq.38.1690385065360; Wed, 26 Jul 2023 08:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690385065; cv=none; d=google.com; s=arc-20160816; b=nk2RnPCdbrbQpTlPy62VHGmHIcRWRcPueHmPPtzcQsGUu+cRd8oe4TxgkLphNZt68b MEfiFyx/49hYpABg2IQiUZ75i5kDP87U2Y0Ehly01Brr+dElEbgstpJBindjDXbDio5a dk4k2CSKi6nv94nVxxt0thLDQU1P75SRz62EJ5pB8aLn6sWsaE+QlANGX9/HfqhGY0lZ jbz4SJGq92KhutuCMPS2fLpbEVkLFPNPaEh9V6rhKixSZbcmVjTogQRD6MKaFofBGKE7 L38gIwiSH7mdfRRglVQHg2weHQtQp0fgygE+mVOiu8XX7Qu19W7YomAkz13whJF2mrXl Pnnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pCKrrq0JKIPKrqYA1/6zPq3U1PIMLmzL5b3Qir8htZ8=; fh=VzfyGZheOmnVqJ0ayr4s3qhIyLDcYnjZM2S0CGUqqa8=; b=q0wQAUEQmikvj8DoLAl7zEMzy2H4uyLQfApE7/qiYOFjl7l+FJ9CIu8Jt9wJ3jX2yH DZ3cKvaynXhYIBOSwTnEVoRyfSNZpDcb9L0DtqCWhaB0payp9ioRChbBCnaJQKghmnlD /rdBnBluOqc1fDOohb0KYsYcafhB6QvajHnP3l+BZWFf8xSg8l2hbUlImmcAZh6dr7Pn c/sCI0EeQltt5HID1/BZcLxQlmeB6FWVVKZSSmmWb+PjRjbeZTfKOx0Z8OovIaFz/I08 BnTRu/Sf+xg0H3KUpfc4NQHqdkJSMaM4eKeX9lOtr/ZN1XPqtlrgfQL2sjHaE3LP1sX3 6/lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bYj32l3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id im23-20020a170902bb1700b001bb7b0a67cfsi9675512plb.31.2023.07.26.08.24.11; Wed, 26 Jul 2023 08:24:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bYj32l3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233092AbjGZOq2 (ORCPT + 99 others); Wed, 26 Jul 2023 10:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231690AbjGZOqY (ORCPT ); Wed, 26 Jul 2023 10:46:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF2A132; Wed, 26 Jul 2023 07:46:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A87A61B0D; Wed, 26 Jul 2023 14:46:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CCE4C433C7; Wed, 26 Jul 2023 14:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690382782; bh=ac1IB6GcnstuSIv+AKNdyB+dOcsk25Rvnlxcmo7PaCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bYj32l3QNuBWz/km5z/obm8ytBpcvAi4oaV4uV6V/QcA/6R3ma8nZUf/yuBqqJSRe rwoVNenutxR+yKSlDV9WoQgpUcLbGLs46BVhmHubJ0Kph1/yw2vEezRnlI2eoBlbTH hBIfcmvKFBHcq7B8cqYWAj0qvWMlgctamD9sGxHmMyOIKU8HAjFLm2LXMr0ld1Xn5y 1zZ0wCXlVF4JKMq6mr2CkB8lCAngn4A1+ONP7Y0n0q5V6HrzW6M+D6InWh1p3XAUPz ODMCRPRCpJLzDsN+SVwHeeYx2pQYO423j4q9ciPcvpByo4CQP+iXVvQoqHiCX3h66/ YKGNg3vZUyKhA== Date: Wed, 26 Jul 2023 16:46:19 +0200 From: Andi Shyti To: Ruan Jinjie Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err() Message-ID: <20230726144619.qo3ttjjmjvliwz23@intel.intel> References: <20230726174226.2480552-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726174226.2480552-1-ruanjinjie@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ruan, On Wed, Jul 26, 2023 at 05:42:26PM +0000, Ruan Jinjie wrote: > There is no need to call the dev_err() function directly to print a custom > message when handling an error from platform_get_irq() function as > it is going to display an appropriate error message in case of a failure. > > Signed-off-by: Ruan Jinjie Correct! Reviewed-by: Andi Shyti Andi