Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c690209-4a1c-842f-064b-66ae5c8d870f@gmail.com>
Date:   Wed, 26 Jul 2023 22:15:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Subject: Re: [PATCH V3 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP
 enlightened guest
To:     Jinank Jain <jinankjain@linux.microsoft.com>, kys@microsoft.com,
        haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        daniel.lezcano@linaro.org, arnd@arndb.de,
        michael.h.kelley@microsoft.com
Cc:     Tianyu Lan <tiala@microsoft.com>, linux-arch@vger.kernel.org,
        linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
        vkuznets@redhat.com, Michael Kelley <mikelley@microsoft.com>
References: <20230718032304.136888-1-ltykernel@gmail.com>
 <20230718032304.136888-8-ltykernel@gmail.com>
 <4d0715a5-70a8-9667-ccf0-de9bc933bb04@linux.microsoft.com>
From:   Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <4d0715a5-70a8-9667-ccf0-de9bc933bb04@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/26/2023 12:26 PM, Jinank Jain wrote:
>> +    /*
>> +     * Hyper-V SEV-SNP enlightened guest doesn't support ioapic
>> +     * and legacy APIC page read/write. Switch to hv apic here.
>> +     */
>> +    disable_ioapic_support();
> 
> Where are we switching hv_apic? May I am missing something here?
>

Nice catch! It's fossil comment when there is no x2apic support.
Will fix it in the next version.