Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9b7df8f-77db-d8dc-efab-9ae7e9ef6922@amd.com>
Date:   Wed, 26 Jul 2023 09:03:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [Question] int3_selftest() generates a #UD instead of a #BP when
 create a SEV VM
Content-Language: en-US
To:     Wu Zongyong <wuzongyong@linux.alibaba.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org
Cc:     linux-coco@lists.linux.dev
References: <20230726024133.GA434307@L-PF27918B-1352.>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230726024133.GA434307@L-PF27918B-1352.>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHZET0NmZXQ5dUZCZnRLcVg5NC9lMTBvT3pYU2ZTcWQrc0JPRThyQkRaaDJW?=
 =?utf-8?B?M1d3UUZDNHlBOHJOZEIvL01vOG1kWUlQVERpZTk5U29MS3VSL0Z1YzJmbmo0?=
 =?utf-8?B?OGZwSnhJWnl1dTJnOWE0V25wckl1ZUZsZVJMNllRZUZ2S2t4bERkbkZvWWd0?=
 =?utf-8?B?S2lkSjk1QWV1b0tsQXJ6RVlrTWlVN2x4UWZrZWgvYllCc0xJM3J6NStGaHhn?=
 =?utf-8?B?ZWVqWStjK2M4U25lcmRkNXJHSmZLMGNGd2RUWTJDemN0RW8xVUNMRERoeTZu?=
 =?utf-8?B?bmZUK0xYRjd1ZnBONGxaNHBseGloNXBncFRlVzllN0ZnYVozNjg0NE1VUE5a?=
 =?utf-8?B?OE9kWHExK1VKdGVmV2RJSENOaTI0MXhiWFlWK0lVSnFOZ1VqQVdyVkdHU0NE?=
 =?utf-8?B?cytRdzJoYmY1V0xpckpKdFlKNVlQeUtVOFJqRmZkQWdqZFJlS0lseDF1ZnN3?=
 =?utf-8?B?UnNJenRCN010emxhRkpJVE1DVUpFZ0RzOG5uaE9nWHRKd3FpcGxYNFEzSkMw?=
 =?utf-8?B?K1VkNEdNRGZzdW5ybWdxbHBkTWk5b05uUWNZRGdQWGRUZ0t4YVN4VnM1eUda?=
 =?utf-8?B?c2w3Q1ArcUVQQVAyM1RNYW9QV1pic2VKN0xrQUFBTUNSMm5MYTRDV1daeU50?=
 =?utf-8?B?aWxWRTVJVnJ1S21CNVp4QzJFTnhnS2twa21TLy9vVFJndDdHQWovNVNTNlRZ?=
 =?utf-8?B?M0hscGNsdFVmdzIyWElrY2d5YUs5cytvVjFZdDdSN252emxkaVByYlc3MmxV?=
 =?utf-8?B?RnNjMm56OTdFL3R4VThrajdWeWhuTE54NHB5UHJCRGhmRW5pOEl4TkRBekUx?=
 =?utf-8?B?dkxUMUd1ci9MbkFlM1M4WndoU0pBakp0N1l1VTZrWnBWQmU4N1JETktibGtR?=
 =?utf-8?B?dlhHZE9Jdld0d29ocEtsUlI5OUl3L1dVZWZKdFlucExVZEtjLytQNW1qRzE5?=
 =?utf-8?B?Rkpqc09semJnUUFpT3ptQWVmQ0QzM2NWZlJPak5RTStzeDRmTlRLb2M1L29Q?=
 =?utf-8?B?aFJhQ2Voc2VFT3VJTXMzUHZEbk9TUE5ia2oxY1pkNFRIN1hjM1JJdlZrSGY4?=
 =?utf-8?B?RVNuQXJhM0JOYndkb2FvVjlrcGF2d3QyNzdkUzVzYVV4NzBZaUpObkVZMHZD?=
 =?utf-8?B?Z0pVRXVLSi9JV0s0Rm1YM3NzRTFIeUY2SWRqNy9kTEhUU002SDlHSU03T0U0?=
 =?utf-8?B?MFlFeFV0VTJRSTdYaFY0ajcxUjM3MlhRbkR4TTZUaGxFTERBOXlZUFFXaXZU?=
 =?utf-8?B?SmxTckNPdXBDNW1YNFQ5ZTBYWEZobWhnUEkrREN3cXhhRE9qb0s1MFk5MDJJ?=
 =?utf-8?B?Y3phZ0hWQXlnVEpaQm80S2pOYkRvSGRhdkV3NFFlOHluMzBaMVJUM3p6L1pz?=
 =?utf-8?B?Vk5TTkQ1YmZkbUxuMldjRzRpaG5yRUV1T3p3VWMrNGRTU1UvSk9yd0VZS1kr?=
 =?utf-8?B?aEFCUTJqSlhPVmU0cmgrM3dSb0tacndLaE1ac3pvbklmOFVIUXJCeEhPcjM3?=
 =?utf-8?B?UERZZVdDcVZJVFNPZGtzUkhlTDV5TnFoQzFiWC9iYndNZXlncnpITld2ZlBU?=
 =?utf-8?B?elhxaGIrdkIyRHdNdGtSYWcvRUJsdm5tSzlEMlpIVG1KRHFwSE1zWGpZcWNO?=
 =?utf-8?B?WDcrTmhOdngzK3ZjOGFsblZnZVVmbkdTRDNkOFJWc2txclZzS3k3UVlkZTd1?=
 =?utf-8?B?K2t5Q3Q4U0xINXpscUVzbTRnVFoyRER5TUhsRmo5R0ZjT2hpNTNxektQdUkr?=
 =?utf-8?B?b29rT0NRb01OanZra0dMQUNqeldjNlZzMlNyeURKTDZOVGpSa2I1aDYva09Z?=
 =?utf-8?B?RjU0SERSMlBMd2JIQlNyblROT0JFZHJjY24wK2srekltQVd1R0pKVVVpdnNV?=
 =?utf-8?B?bEw4NC9pWE1xSmpIR1lSUTRlbFBCNmNGNENicVVFK2hUdGdQY0pkdlRpcGNp?=
 =?utf-8?B?V1QwV0ZFQzJnV1dtNVo0N0EvaTJPdzFOWFNTVFJOT0ZabVhmcHluVzdNd3dE?=
 =?utf-8?B?Y0FqMW8zYitPNU01WmtsL3Q3WVRQL1RXY2EzaWN2eUc5R3UySGhxWGtwYWwr?=
 =?utf-8?B?ZzhSbm9WYW9LTmRJeDdwZ25GOHpDcU1vZ3BQT1kwY3ByeEw0QytPRnZ0N2ZN?=
 =?utf-8?Q?oep8Wg6Oe8PvFu0tGMQYyUg9i?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cc4c194-8ae5-4ac4-bba5-08db8de114d3
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 14:03:26.1257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ynHqz01pKzZ51Cw1RThyDCBUBf2QkuwUquNZgSSkR9abeIP1Amdsd3ogveVv8SWdVk/rfiStIoh7lu2T8QX9eQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9217
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/25/23 21:41, Wu Zongyong wrote:
> Hi,
> 
> I try to boot a SEV VM (just SEV, no SEV-ES and no SEV-SNP) with a
> firmware written by myself.
> 
> But when the linux kernel executed the int3_selftest(), a #UD generated
> instead of a #BP.
> 
> The stack is as follows.
> 
>      [    0.141804] invalid opcode: 0000 [#1] PREEMPT SMP^M
>      [    0.141804] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.3.0+ #37^M
>      [    0.141804] RIP: 0010:int3_selftest_ip+0x0/0x2a^M
>      [    0.141804] Code: eb bc 66 90 0f 1f 44 00 00 48 83 ec 08 48 c7 c7 90 0d 78 83 c7 44 24 04 00 00 00 00 e8 23 fe ac fd 85 c0 75 22 48 8d 7c 24 04 <cc> 90 90 90 90 83 7c 24 04 01 75 13 48 c7 c7 90 0d 78 83 e8 42 fc^M
>      [    0.141804] RSP: 0000:ffffffff82803f18 EFLAGS: 00010246^M
>      [    0.141804] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 000000007ffffffe^M
>      [    0.141804] RDX: ffffffff82fd4938 RSI: 0000000000000296 RDI: ffffffff82803f1c^M
>      [    0.141804] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000fffeffff^M
>      [    0.141804] R10: ffffffff82803e08 R11: ffffffff82f615a8 R12: 00000000ff062350^M
>      [    0.141804] R13: 000000001fddc20a R14: 000000000090122c R15: 0000000002000000^M
>      [    0.141804] FS:  0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000^M
>      [    0.141804] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033^M
>      [    0.141804] CR2: ffff888004c00000 CR3: 000800000281f000 CR4: 00000000003506f0^M
>      [    0.141804] Call Trace:^M
>      [    0.141804]  <TASK>^M
>      [    0.141804]  alternative_instructions+0xe/0x100^M
>      [    0.141804]  check_bugs+0xa7/0x110^M
>      [    0.141804]  start_kernel+0x320/0x430^M
>      [    0.141804]  secondary_startup_64_no_verify+0xd3/0xdb^M
>      [    0.141804]  </TASK>^M
>      [    0.141804] Modules linked in:^M
>      [    0.141804] ---[ end trace 0000000000000000 ]--
> 
> I'm curious how this happend. I cannot find any condition that would
> cause the int3 instruction generate a #UD according to the AMD's spec.
> 
> BTW, it worked nomarlly with qemu and ovmf.

Does this happen every time you boot the guest with your firmware? What 
processor are you running on?

Thanks,
Tom

> 
> Any suggestion would be appreciated!
> 
> Thanks,
> Wu Zongyong