Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1181592rwb; Wed, 26 Jul 2023 08:41:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHgXW4yN1rYWPiqE6yxJ52dOJZywRbO+Lwr+nj70mjxDCpeXDXXfZ2Cf1ckZut3mg6qOPDG X-Received: by 2002:a50:fc16:0:b0:521:7ab6:b954 with SMTP id i22-20020a50fc16000000b005217ab6b954mr1845444edr.1.1690386089281; Wed, 26 Jul 2023 08:41:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690386089; cv=none; d=google.com; s=arc-20160816; b=R/KWycWMPD6QLvF7kO41EpKYAZSF5mA1qq6cZedgHlmfl8xOTgaJg/gSWQ6cAYJQLH iamitf/9rE2v39jCC+xiUFDYWswXM07oTu/Tj+NlHY93xdUq795ljT7Gs650htj2u1D5 9VuWirr1XBRaOG85HQrSsfKVWIGU+SnQpWgZ/LOmrxPdjI+ZN/KKYQxEPGQLnd5B2RL1 Y4Uxtmq3IDa5gGwXfq3dOwJ7nwtPtY3HRJroPr6GHnTEyOMHlt1yPfj1GOy2nzh6t0Mf Tl6z3LiosUgV4z4mgQ0K7Ourg+CTd3ToreG1IedskTzCLFeX3bK/lMpSRu3vHJxp2lAy FcoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=A+RJ9bjdJOKdVlmB8tH5nWBvWZOXyXeNxJfoIL0LKjo=; fh=4Lx2xuLC/eOUqjXA7WrKkFTg48ab1as1+dxUYGVy9Jo=; b=W9RbFOgb2+P21etXSQN56zvMPnJ/7+k9zg5WTnlCeBLDvTuThyG+zlS4dk5juJhRTd i2eLObwks5Xrwh5oV1+3GRYr0ulrI8Ij0oFRY+3qfdZ5UoqrqU9wk6H/fIyoztFImYrm Yd6slAjKH2CmfDQ+ew02bm67bJLUk/ReHOSO/FLdnvsemcWvY3xAqlVYjJnle6129aX5 Ery1mro1iM3RDwwUtkdPJSwOgyKHRYzB8lO7ZWHX+kuCep5XFtHrrdRPc0ZYI6qdHT1J m0S28OYh6OoI8oWRKNfxopR3xw2amtHED0nYYhyi5AZ4eigyrsoId8CQvk6mGI6EeCnx i7kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZxKmBNZa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a50ed82000000b00522294d0aa0si5521694edr.590.2023.07.26.08.41.03; Wed, 26 Jul 2023 08:41:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZxKmBNZa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234900AbjGZPOC (ORCPT + 99 others); Wed, 26 Jul 2023 11:14:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235088AbjGZPNT (ORCPT ); Wed, 26 Jul 2023 11:13:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F057530F4 for ; Wed, 26 Jul 2023 08:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690384209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A+RJ9bjdJOKdVlmB8tH5nWBvWZOXyXeNxJfoIL0LKjo=; b=ZxKmBNZaW3Q2ww6eSRy3WHN+E6NqsbDSKJeIyh9i6eWrJQem0P9J4es8fGXfurJd0VANP3 g1f4plHuotZxLfT2M2In2TdAgNhIUvtdyGu6xY9LRsCdbpZU8ZJYkTcjqTIs1/KjTFBh5d mhCKwFEmIk7i34YMr7R1RyvUYLKrz6w= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-vkyNeiwRM4eA3JvU8t_DXw-1; Wed, 26 Jul 2023 11:09:42 -0400 X-MC-Unique: vkyNeiwRM4eA3JvU8t_DXw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D80261C05AA7; Wed, 26 Jul 2023 15:09:28 +0000 (UTC) Received: from [192.168.37.1] (unknown [10.22.50.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F408145414B; Wed, 26 Jul 2023 15:09:27 +0000 (UTC) From: Benjamin Coddington To: Fedor Pchelkin Cc: Trond Myklebust , Anna Schumaker , Olga Kornievskaia , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH] NFSv4: fix out path in __nfs4_get_acl_uncached Date: Wed, 26 Jul 2023 11:09:26 -0400 Message-ID: In-Reply-To: <20230725115933.23784-1-pchelkin@ispras.ru> References: <20230725115933.23784-1-pchelkin@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25 Jul 2023, at 7:59, Fedor Pchelkin wrote: > Another highly rare error case when a page allocating loop (inside > __nfs4_get_acl_uncached, this time) is not properly unwound on error. > Since pages array is allocated being uninitialized, need to free only > lower array indices. NULL checks were useful before commit 62a1573fcf84 > ("NFSv4 fix acl retrieval over krb5i/krb5p mounts") when the array had > been initialized to zero on stack. > > Found by Linux Verification Center (linuxtesting.org). > > Fixes: 62a1573fcf84 ("NFSv4 fix acl retrieval over krb5i/krb5p mounts") > Signed-off-by: Fedor Pchelkin Nice one. Reviewed-by: Benjamin Coddington