Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1236052rwb; Wed, 26 Jul 2023 09:23:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlGR0lTrO2vNIIDvpUwqqHAJ2gWYf4nRzB+Y2/IFppMp9raOmKCsA5NUHh9VgHV2xmuj+Ieb X-Received: by 2002:a05:6a20:9188:b0:12c:f124:5b72 with SMTP id v8-20020a056a20918800b0012cf1245b72mr2383261pzd.43.1690388611197; Wed, 26 Jul 2023 09:23:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690388611; cv=none; d=google.com; s=arc-20160816; b=MGN2ca4sWOcGS9mDAMWULld3EJvc5LvSNiA2iL6sv+iHcVksgyd0+Vb8I+1IKArji9 GzOSOAyxT5HX74reRD0Otg1q8e6w1shv2uVxz4tf0x9ihv0LTBeUard8jYOrWaSn/PPW J4JEHHdB4QHPf5aOasadVgdRiP2+EeaBGbP7ZavjKxSh7ow1EriPTXdT7f8OGXs7sF+Q xQ5lcjh8jp3aupG0yYVfStJ2jd64OMWH6g7j/Yc3BJGDNJ3CtkPMOvXpVjNMhonFaaPj 8WYizVq2/lpVEu2QwliqBHdq3bLNdqgkt1Y9T6J/Tow/CAIQ0D/bXGMwANDgpEepdg06 pMlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=JHmWY93hRwD8/ZHoZ2iKlSkjyv+ADV+Toymh3fm3dXA=; fh=7XwpytWNJWz9RDezMNrW/rL2XV2qZuDON/LcrcvJR9o=; b=oTZ4vicRb8/dj+/xE6HaWQjqHH7pNcKmHiRSH5CU1kjL4lkIkcnLpOLdDnQwzRo1ef 2YP5YtOEKXZWFK5ybHyZBQ1jpqlDR2SpOziWuEV8aokljA302QQsUTlBDJ+urKtyFHF2 Gi3cato+ng9UxvdirLZdt2LDf5rcCgW2X/ndic2JN1n+GWlSWuzijhlSzNxFMLPXxNy2 SVNqPq3h9d6ngNOnURNcVYprHK/5YYwueYq8pscRYwPvXdBM43BQSnxwLaYqDNswme65 UBmaCy6MukiuMB/DOEumfSC+ciu9qzVv3LnpC75nZG6CUBoJTruaPdYkk23nKBfaFfaK 3jAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rKGZlp8L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020a63fc50000000b00563540798f1si12539574pgk.342.2023.07.26.09.23.17; Wed, 26 Jul 2023 09:23:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rKGZlp8L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234116AbjGZPjU (ORCPT + 99 others); Wed, 26 Jul 2023 11:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbjGZPjS (ORCPT ); Wed, 26 Jul 2023 11:39:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4504A1B0; Wed, 26 Jul 2023 08:39:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD6CC61B5D; Wed, 26 Jul 2023 15:39:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EA2EC433C7; Wed, 26 Jul 2023 15:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690385957; bh=mIOGi0gBMHEqkGdNbDH6LW1lZ3Ao6lr4wjejxd0zmN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rKGZlp8LCfTHU4nOTm5q1zIvNpqloNGZQT5n5WzPRJ02MVLq4ePApKs/YcHVrX+er KZ4/TCKkW1ETlfevpKlFrhg39pu0ZZ7roInTfdqAXsyrQE/yWMhiY8GVKqOoDWWiw0 VPKwLJmW++zUTqwR3/16foXuKSOpXnIamtITS0RvoRuqM+obd2mOuKwpUrSTmQ/77K 2wXRQkuq/RFwGkjunUqBUrXwfjnyZezX9sZ/tGD50YMPTJmyL71g62GrVMudd8mBY1 9S2EevaUtdF0zxMdl37QDa1Gg+xQvDPbBtfUc/Auv5ypPDvrsadTPIB8eF2sMiAoot wEzY0euh6PYfw== Date: Wed, 26 Jul 2023 08:39:15 -0700 From: Jakub Kicinski To: Md Danish Anwar Cc: MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Eric Dumazet , "David S. Miller" , , , , , , , Subject: Re: [EXTERNAL] Re: [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats Message-ID: <20230726083915.1323c501@kernel.org> In-Reply-To: <296b0e98-4012-09f6-84cd-6f87a85f095f@ti.com> References: <20230724112934.2637802-1-danishanwar@ti.com> <20230724112934.2637802-8-danishanwar@ti.com> <20230725205014.04e4bba3@kernel.org> <296b0e98-4012-09f6-84cd-6f87a85f095f@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jul 2023 16:06:06 +0530 Md Danish Anwar wrote: > > Are the bucket sizes configurable? Can we set the bucket sizes > > to standard RMON ones and use ethtool RMON stats? > > The bucket sizes are not configurable. Bucket size is read from hardware and is > fixed. I don't think we can configure bucket size and use ethtool RMON stats. > It's better to dump bucket sizes via ethtool -S. The buckets in the ethtool API are up to the device to define. Driver returns bucket ranges via struct ethtool_rmon_hist_range from struct ethtool_ops::get_rmon_stats.