Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1255448rwb; Wed, 26 Jul 2023 09:40:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlHMFdlarFkKIkCC856vaZ2LNWys7mTQ5tzOqyl+dSj0j1mjFCnYziB2aoXmNmv2+f+nRfMo X-Received: by 2002:a05:6a20:914d:b0:122:10f9:f635 with SMTP id x13-20020a056a20914d00b0012210f9f635mr2511855pzc.19.1690389645693; Wed, 26 Jul 2023 09:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690389645; cv=none; d=google.com; s=arc-20160816; b=xxBDyHA7g5RbXkl/SPAmSGKRrPLNCBNOi44igb0vIFdSOvqiFwJB81+w5elZe3xHZi B7aX9/f8jyy8rHmxQtp4AdViDfETFWd+ev3pZwqpC/6883rat5qkDze8HyyMNus4gA64 msduUOzGUn5R1zQ7sI8vghBvsjDk/giPxWseKQ5Hr5qAcBIlsrdkqpDQwq9nbpbabHEX b9I9tnmGx4HdXZnXiP1kH8R1hvfD4HPf8tBbuuyXLx2xBw2qY6VV+1E3vHomA4ITIwVY bSqhUAOtS4E+Has6yvQvEKgyWIRK7j9ZtmavKAYey0UpgwswKW1r/dmcDDmfQuSvq+uc xkzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7UDgfaBKbDx6HXbNdob8rAF7nTMRLH3Ebyzm12lV4pQ=; fh=iuVUWtRVk+jSDvXsgwiNtKzO7SsTWK3PMEtuXqLFda8=; b=LWvWuvnb+6eVHBYhyO4WRfK3KV4eTyK8hm/zmNsBRkfW9MFOpKH0T4ruL1UlZfMNFD L7Mv8tB+DKbE7vyf05Mp75eddg9EQCWo+dGh/nHDfusFza5KpYgQIojHC8zS1uAkS8H4 haB4/Gkkx4EVcRI9ifLgK8rugIRuvp2Qrvg6KDfGMiHScW0tpFttF0GU2Dyk/kvApbci IszICvSIu3w18a/VgEpuJr3Zv5CN5Z09Pee/nNX1Muv9jE7Qb2zH6wY3l9s5x6o1a+U1 ljtADDiRiSwFU+iB8QA6lGxdLXz5ssRmZk2dGPYRCV+aYjWZRPPgDTeA0+o6/9oQ6fDn Senw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=nyD1WleQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k72-20020a636f4b000000b00563a0c1bf06si8321698pgc.428.2023.07.26.09.40.32; Wed, 26 Jul 2023 09:40:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=nyD1WleQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233759AbjGZP4Y (ORCPT + 99 others); Wed, 26 Jul 2023 11:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231933AbjGZP4X (ORCPT ); Wed, 26 Jul 2023 11:56:23 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C079E100; Wed, 26 Jul 2023 08:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=7UDgfaBKbDx6HXbNdob8rAF7nTMRLH3Ebyzm12lV4pQ=; b=nyD1WleQwZllG/YbayTavTKoHL vWq30msw3K3zW2SynqSS0cEvRP4X5NrtrKIlZtOhkI9n8m84bt/U68ob57/c+OffL0asV1YdYzXBP EvbKartx1Y9G7J9lSG/tuNUaE6eBZJicKxZhl2AqoS10NjDbDnxw1n3wEpN/+kfDv3Lg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qOgrs-002NEQ-8B; Wed, 26 Jul 2023 17:56:04 +0200 Date: Wed, 26 Jul 2023 17:56:04 +0200 From: Andrew Lunn To: "Hawkins, Nick" Cc: "Verdun, Jean-Marie" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 3/5] dt-bindings: net: Add HPE GXP UMAC Message-ID: References: <20230721212044.59666-1-nick.hawkins@hpe.com> <20230721212044.59666-4-nick.hawkins@hpe.com> <57d882ed-82e5-4584-8126-ca2007064126@lunn.ch> <4c19532d-a909-4ca6-a0a7-d4cd9cc828b0@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023 at 02:35:48PM +0000, Hawkins, Nick wrote: > > > > Do both ports get the sane MAC address? > > > > > > No they do not. The first one will get the MAC address, the second > > > will be an external phy we are managing via the MDIO path. > > > Then please put the mac-address property in the correct place, inside > port@0. > > Greetings Andrew, > > I was mistaken, the Mac address belongs with UMAC, > not the phys. The reason ports are listed here is > because having two separate phy-handles > in one node is not allowed. The layout of the > hardware inside the GXP is unconventional. It is not that unconventional. See Documentation/devicetree/bindings/net/marvell-orion-net.txt This is an Ethernet block, with two MACs inside it. Each MAC gets its own subblock containing MAC specific properties like the MAC address, phy-handle, etc. Andrew